Problem with call SUB with param

[PasPy]

when I call a sub, I check wich sub is called. When I call

http://www.exemple.com/cgi-bin/exemple.cgi?delete=1001

, I want to give the param 1001 to the sub delete. here my code, I don"t know how to make this . . .

$referer = $ENV{HTTP_REFERER};
if(($action eq "delete&quot && ($referer =~ "$scripturl&quot) {
&delete;
}
else {
&login;
}

#and here the sub delete

sub delete {

my $obj = new CGI;
my $todelete = $obj->param('delete');

#the message in the heat of the &main
$message = "The numbers $todelete was deleted";

#add the deleted numbers to the rest of the deleted numbers
push @did, $addoffers;
&main;

}

 

[raider2001]

In order to pass parameters to a subroutine you do the following:

1) call the subroutine with the parameters
&mysub("bob"

2) retrieve the parameter from the array @_

   sub mysub {
       my $arg = shift; # Implied shift(@_);
       print "hello $arg \n";
   }

 

[Krel]

Here ya go.

(my $sub,my $argument) = split /=/,$ENV{QUERY_STRING}; # Get the name of the sub and the argument to pass to it.
$sub->($argument); # Execute the subroutine.

sub delete {
  my $todelete = shift;

  #the message in the heat of the &main
  $message = "The numbers $todelete was deleted";

  #add the deleted numbers to the rest of the deleted numbers
  push @did, $addoffers;
  &main;

}

This is untested, so if you are actually deleting files and stuff inside delete, make sure you make a backup of the file(s).

 

[PasPy]

I have problem when I check wich sub is called when they have parameters ?

#here the code, it's in the delete and offer sub that I'va trouble, I'm not able to send param, check my code, you will understand, I wish.

(my $sub,my $argument) = split /=/,$ENV{QUERY_STRING}; $referer = $ENV{HTTP_REFERER};
if (($action eq "checklogin&quot && ($referer =~ "$scripturl&quot) {
&check_login;
}
elsif (($action eq "update&quot && ($referer =~ "$scripturl&quot) {
&update;
}
elsif (($action eq "delete=$argument&quot && ($referer =~ "$scripturl&quot) {
&delete;
}
elsif (($action eq "offer=$argument&quot && ($referer =~ "$scripturl&quot) {
&offer;
}
else {
&login;
}

Thanks againt

 

[Krel]

I'm not clear on how you're setting up your data. If I got the right impression before, you want the sub name to be on the left side of the equals sign and the argument on the right. Let's say you have two subs: delete and printit.
Here is an example of how to use a variable as a sub name:

sub delete {
  unlink $_[0];
}

sub printit {
  print $_[0];
}


$ENV{QUERY_STRING} = "delete=path/to/my/file";
($sub,$argument) = split /=/,$ENV{QUERY_STRING};
$sub->($argument); # This will delete the file specified as the argument

$ENV{QUERY_STRING} = "printit=hi there!";
($sub,$argument) = split /=/,$ENV{QUERY_STRING};
$sub->($argument); # This will print the argument.

Of course, you won't be setting $ENV{QUERY_STRING} manually; that variable refers to whatever is after the ? in the URL.

 

[PasPy]

This is with this line I'va trouble;

elsif (($action eq "delete=$argument&quot && ($referer =~ "$scripturl&quot) {
&delete;
}

#$action =

http://www.exemple.com/cgi-bin/program.cgi?

#Here the action"

so if I call "

http://www.exemple.com/cgi-bin/program.cgi?delete=1001"

the $action variable = "delete=1001", so my code doesn't work !

(($action eq "delete=($argument)&quot

I want know wath a should put here when I call the sub...

when I call

http://www.exemple.com/cgi-bin/program.cgi?delete=1001

or

http://www.exemple.com/cgi-bin/program.cgi?delete=1034

or

http://www.exemple.com/cgi-bin/program.cgi?delete=2054

If $action = " ??????? " then call &delete

I'm not sure you will understand, but It hard to explain !

thank againt

 

[Krel]

Oh, I understand you now! Replace this line of code:

elsif (($action eq "delete=$argument") && ($referer =~ "$scripturl")) {
        &delete;
}

...with this:

elsif (($action =~ /^delete/) && ($referer =~ /$scripturl/)) { &delete; }

The first condition checks whether the action starts with the word "delete".

I assume you're trying to see if $scripturl is in $referer in the second condition? If so, you need to code it as above. You can't use quotes for a regular expression.