problem in calling custom module function 1

[ranadhir]

I have define a custom module which contains 2 utility function to return matched/unmatched boolean.
Additionally there is a function which returns the result using these util functions.
So,if i need to filter files from a directory which are not directory themselves,i need to call
my @collfiles=modules::unixop::accumulatecoll($func,\@files,$filter) ;
where $func=\&modules::unixop::filterirrelevant;
@files contains the output of the dir command.
and $filter=DIR.
This will use the utility function filterirrelevant to return the non-dir files as a collection.
But i get an error as:
Too many arguments for modules::unixop::accumulatecoll at perlexecs\xmlfeed.pl li
ne 22, near "$filter) "
What am i doing wrong?
If i shift this function within the same unit,(rather than invoing from a module) I do not get this compilation error.

 

[KevinADC]

there is nothing technically wrong with this line:

my @collfiles=modules::unixop::accumulatecoll($func,\@files,$filter) ;

the problem must be with the function accumulatecoll() which seems to be expecting only 2 arguments. Can you post the accumulatecoll() function code?

 

[ranadhir]

The function is mentioned below.The surprising part is that if i pull in this function from the module into the unit itself(along with the util routines),i do not get any compilation errors.

sub accumulatecoll()
{

my $filterroutine=shift;
my $var=shift;
my $filter=shift;
my @contents=@$var;
my $matched;
my @collmatched;
foreach my $var (@contents)
{
next unless ($matched=&$filterroutine($var,$filter));
push(@collmatched,$matched);
}

return @collmatched;
}

 

[spookie]

Try

[b]my $self = shift ;[/b]
my $filterroutine=shift;
my $var=shift;
my $filter=shift;

--------------------------------------------------------------------------
I never set a goal because u never know whats going to happen tommorow.

 

[ranadhir]

whats the first parameter (self?) for?Is it a default parameter sent to external modules?

 

[ranadhir]

Anyways,this solution does not work either.I am still getting the compilation errors when the function are called from a external module.Why is this so - is there some calling convention for external modues which i am getting wrong?

 

[KevinADC]

change this:

sub accumulatecoll()

to:

sub accumulatecoll

the first one is a prototype the second is a regular sub routine. Prototypes work a bit differently than sub routines and you rarely see them used in perl scripts. I don't know if that will cure the problem you are having but give it a try and see.

 

[ranadhir]

that worked perfectly.Thanks a lot Kevin.
Also the strange point to notice is that ,this function signature gives me a problem only when it is invoked from a separate unit.

 

[KevinADC]

yea, prototypes are a little bit tricky, just don't use them. There really is never a need to use them that I am aware of.