very small upload script problem

[madcgimonk]

The upload script does upload the file, but it's alwaos 0k in size. For some reason it's uploading the file name but not the file. You notice that when you're uploading via the form, it takes a fraction of a second for it to say the file was uploaded.. so it's not even trying to upload data.

Can anyone see what the problem might be?

if (param("UploadFile"))
{
   ## collected from form field (the file itself)
   my $remotefile = param('upload');
   my $filename = $remotefile;
   
   ## collected from form field (username)
   my $user     = param("select");
   
   ## strip off directory paths
   $filename =~ s/^.*[\\\/]//;

   my $localfile = "/home2/spyders/public_html/member/$user/$filename";
   # full file path to upload directory (must include $filename)


  #############
  # Check to see if the file already exists
  #############
   if(-e "$localfile") 
   {
      print "<center><font color=red>ERROR: A file with that filename already exists.  Upload aborted.</font></center>";
      exit;
   }

   ####    
   # open a new file and transfer bit by bit from what's in the buffer
   ####
    open( SAVED, ">>$localfile" );
  
    my $buffer;
    while ( my $bytesread = read( $remotefile, $buffer, 1024 ) ) 
    {      
        print SAVED $buffer;
    }
    close SAVED;

    my $mode = 0755;
    chmod $mode, "$localfile";

    print "<center><font color=blue>File was uploaded to <b>$user</b> successfully.</font></center>";

}

 

[Xaqte]

In your form, do you have:

<FORM action="../cgi-bin/whatever.cgi" method="post"
enctype="multipart/form-data">

With attention to the "enctype". I hope this helps.

X

 

[madcgimonk]

Hi.

I didn't have enctype before and I added that. But it's still uploading 0k files.

This is what I have

<form action="" method="post" enctype="multipart/form-data">

Thanks.

 

[PaulTEG]

There's a few FAQ's on uploading files, hopefully they'll answer your question

--Paul

Nancy Griffith - songstress extraordinaire,
and composer of the snipers anthem "From a distance ...

 

[waiterm]

Take a look at

http://cgi.resourceindex.com/Programs_and_Scripts/Perl/File_Management/File_Uploading/

you'll find several examples of ready written CGI upload scripts, I would suggest either using one of these or finding out where your script differs.

Rob Waite

http://www.hostpipe.co.uk?src=TT

 

[Rieekan]

Also, you might want to add the line:

binmode SAVE;

to your script just before you read in the file. If the user sends a binary file, the way your script is now will corrupt the file upon upload.

- Rieekan