Validate Response from a Chomp 1

[AcidHawk]

Hi

I am trying to validate that the user only enters a (Yy/Nn)

this is what i have but it does not work.. it comes out of a bigger script but the validation is what im having a problem with

sub ques_noargs
{
		print "Fetch Performance Data for ALL servers in cube Directory [Yy/Nn]?\n\n";
		&check_args;
}

sub check_args
{
	chomp($_=<STDIN>);
	if ($_=~/[yn]/ig)
		{
			&response;
		} else {
			print &quot;\nYou Have Entered and Incorrect Option\n&quot;;
			print &quot;Valid Options are [Yy/Nn]\n\n&quot;;
			&ques_noargs;
		}
}

sub response
{
	if ($_=~/n/ig) 
		{ 
			print &quot;\nUsage: xPerfCollector <ServerName>\n&quot;;
			exit;
		} 
	if ($_=~/y/ig)
		{
			print &quot;\nI must search thru the DIR\n&quot;;
			exit;
		} 
}

the problem comes in when i enter a correct value.. i want the ques_noagrs to loop if the user puts in any thing other than Y,y,n,N - this part works if not beautifully it still works..(TIPS here would be great..)

if i enter a y/Y "I must search thru the DIR" gets printed out and the program exits.. BUT!!! if i enter n/N nothing gets printed out and the program continues from after the response subroutine..

any help would be much appreciated..(Feel free to critisize the style or methods of programming as i would like to improve my overall coding skills)

Rgds
AcidHawk

----
Of All the things I've lost in my life it's my mind I miss the most.

 

[AcidHawk]

Do I get a Vote if I fix this myself.

This is what I did..

chomp($_ = <STDIN>);
  if (/^[yn]/i)
    {
      if (/^n/i) 
	{
          print &quot;\nUsage: xPerfCollector <ServerName>\n&quot;;
	  &e;
	} 
      if (/^y/i)
	{
	  print &quot;\nI must step thru ALL the servers DIRS\n&quot;;
	  print &quot;new subroutine\n&quot;;
	  &e;
	}
    } else {
	print &quot;\n=====================================\n&quot;;
	print &quot;You Have Entered and Incorrect Option\n&quot;;
	print &quot;Valid Options are [Y/N]\n&quot;;
	print &quot;=====================================\n&quot;;
	&noargs_ques;

Cleaner and a lot less lines..

----
Of All the things I've lost in my life it's my mind I miss the most.

 

[raider2001]

You're code verifies that the user entered something that started with yYNn, but it would also accept strings like "Nz" or "yes". If you want to make sure it was "y", "Y", "n" or "N", do the following:

if ($_=~/^[yn]$/i)

The "$" marks the end of the string.