Space calling a script

[tcardoso]

Hello, I want to call a script:

./my_script file1 file 2

My problem is that in the script $1 is file1 (OK), but $2 is file (WRONG), and i want it to be <file 2>

I tried:

./my_script file1 file\ 2 or ./my_script file1 "file\ 2"

But it doesn't work :|

Thanks in advance
Telmo Cardoso

 

[SamBones]

Just quoting it should work (with no back slash before the space). This...

#!/bin/ksh

VAR1=$1
VAR2=$2

print "Var 1 = $VAR1"
print "Var 2 = $VAR2"

...gives me...

$ my_script file1 "file 2"
Var 1 = file1
Var 2 = file 2
$

What shell are you using? Can you post your code? It might be how you are using [tt]$2[/tt] that's causing the problem.

 

[tcardoso]

My script is

#!/bin/bash
echo $1
echo $2

/usr/bin/smbclient //machine/directory password
-c "put /home/$1/$2 /remote_directory/filename" (this two lines is only one line, this works correctly in bash mode).

The result to ./myscript file1 file 2 is:
file1
file 2
/home/file1/file does not exist

Telmo Cardoso

 

[SamBones]

Ok, the problem isn't that it can't take in the variable with a space. Your [tt]echo $2[/tt] shows that. The problem is with the parameter of your [tt]smbclient[/tt] command.

Just a guess, try this...

#!/bin/bash
echo $1
echo $2

FILE="/home/$1/$2/remote_directory/filename"

/usr/bin/smbclient //machine/directory password -c "put \"${FILE}\" "

That will try to pass the quotes around the filename with the command. The filename needs to be quoted if there are spaces anywhere in the path or filename.

Another way to fix it is to not have any spaces in directory or file names.

Also, please enclose your code in [tt][ignore]

[/ignore][/tt] and [tt][ignore]

[/ignore][/tt] tags. It makes it much easier to read.

 

[tcardoso]

Thanks

it worked! Sorry for the code mixed with the text, next time wont happen.

Telmo Cardoso

 

[SamBones]

No problem, glad to help!