Searching through files in a directory 2

[carthoris5]

I am trying to write a perl program that will search for specific information in every file in the specified directory.


opendir(a, '.');

@t = readdir(a);

foreach $filename (@t) {

open (infile, '$filename');

while (infile) {

i am then using grep to search for the information.

when I print it out, all it shows is the commas I used to seperate the variables in the print statement.

 

[MillerH]

Don't forget your read operator:

while ([COLOR=red]<[/color]infile[COLOR=red]>[/color]) {

It would also be a good idea if you added some error checking as a reflex whenever you do file opens.

open (infile, '$filename') or die "open $filename failed: $!";

 

[MillerH]

Also ... your open current is not using an interpolated string. Change:

open (infile, [COLOR=red]'[/color]$filename[COLOR=red]'[/color]);

to

open (infile, [COLOR=green]"[/color]$filename[COLOR=green]"[/color]) or die "open $filename failed: $!";

 

[KevinADC]

really, just drop all quotes around scalar variables unless they are really needed, there is no need to use "$variable". This just forces perl to make an un-needed copy of the original scalar.




- Kevin, perl coder unexceptional!

 

[carthoris5]

The information I'm searching through as a line that reads
"DOI: 02 NOV 06"

I have my program set up to searh for it using the grep function:

@thefile = infile;

@date = grep(/DOI: {9}/, @thefile);

but it retuns 0 results.

can anyone explain this to me?

 

[KevinADC]

/DOI: {9}/ doesn't make a lot of sense. Are you looking for "DOI:" followed by 9 spaces or "DOI:" followed by a space and
a date string consisting of 9 characters? Maybe your regexp should be more like:

/DOI: \d{2} [A-Z]{3} \d{2}/

are you looking for the lines that have that pattern or only need to count the number of times the patten is found?

- Kevin, perl coder unexceptional!

 

[MillerH]

Once again you forgot your readline operator.

http://perldoc.perl.org/functions/readline.html

@thefile = [COLOR=red]<[/color]infile[COLOR=red]>[/color];

Also, listen to what Kevin said concerning your regex expression. It looks very suspect.