Searching control for negitive (-) sign. 1

[timmbo]

Hi All,

I have an input textbox the user enters numbers into. I only want the user to enter positive numbers. I wrote this function that checks the contents of the control - searching for letters or "-" negitive sign. It picks up the letters fine. But does not pick up the "-" sign. My code is below:

Being called from the input textbox onBlur method.

function chkMinAmount(frmName) {
	var tempNum = document.forms[frmName].fromAmt.value;
	
	if (tempNum.length != 0) {
		if (amountCheck(frmName,tempNum)) {
			alert("Enter positive numbers only.");
			document.forms[frmName].fromAmt.value = "";
			document.forms[frmName].fromAmt.focus();
		}else {
			var newValue = formatNumber(tempNum);
			document.forms[frmName].fromAmt.value = newValue;
			document.forms[frmName].amountRange.checked = true;
		}
	}	
}

Called from the ckMinAmount function.

function amountCheck(frmName,amountIn) {

	var amt = amountIn;
	
	if (!amt) return false;
	
	var iChars = "-AaBbCcDdEeFfGgHhIiJjKkLlMmNnOoPpQqRrSsTtUuVvWwXxYyZz";
	
	for (var i = 0; i < amt.length; i++) {
		if (iChars.indexOf(amt.charAt(i)) == -1)
			return false;		
	}
	return true;
}

Any help would be most appreciated.

TIA,
Tim

 

[adam0101]

Try regular expressions:

function amountCheck(frmName,amountIn) {
  return amountIn.match(/(^\d*\.?\d*[1-9]+\d*$)|(^[1-9]+\d*\.\d*$)/);
}

Pattern from

http://www.regexlib.com/DisplayPatterns.aspx?cattabindex=2&categoryId=3

Adam

Whatever I feel like I wanna do, gosh!

 

[adam0101]

Whoops, did it wrong:

function amountCheck(frmName,amountIn) {
  return /(^\d*\.?\d*[1-9]+\d*$)|(^[1-9]+\d*\.\d*$)/.test(amountIn);
}

Adam

Whatever I feel like I wanna do, gosh!

 

[cLFlaVA]

or this change:

function chkMinAmount(frmName) {
    var tempNum = document.forms[frmName].fromAmt.value;
    
    if (tempNum.length != 0) {
        if (amountCheck(frmName,tempNum)) {
            var newValue = formatNumber(tempNum);
            document.forms[frmName].fromAmt.value = newValue;
            document.forms[frmName].amountRange.checked = true;
        }else {
            alert("Enter positive numbers only.");
            document.forms[frmName].fromAmt.value = "";
            document.forms[frmName].fromAmt.focus();
        }
    }    
}

function amountCheck(frmName,amountIn) {

    var amt = amountIn;
    if (!amt) return false;
    
    var iChars = "-AaBbCcDdEeFfGgHhIiJjKkLlMmNnOoPpQqRrSsTtUuVvWwXxYyZz";
    
    for (var i = 0; i < amt.length; i++) {
        if (iChars.indexOf(amt.charAt(i)) > -1)
            return false;        
    }
    return true;
}

*cLFlaVA
----------------------------
[tt]a frickin' twelve-gauge, what do you think?[/tt]
[URL unfurl="true"]http://www.coryarthus.com/[/url]

 

[timmbo]

Thanks Adam. Will try your suggestion.

 

[timmbo]

That did it cLFlaVA! Thanks.

 

[adam0101]

That's if you want a decimal. If you want an integer, you could use this:

function amountCheck(frmName,amountIn) {
  return /^\d+$/.test(amountIn);
}

Adam

Whatever I feel like I wanna do, gosh!

 

[timmbo]

Thanks Adam.