Safari and OnChange/OnClick Etc.

[Jawa]

Hi,

I have some simple code:

<select name="Var#ctr#" style="width: (#Len(VarientName)# + 8)px;" class="textfield" onClick="javascript: a(this.value, #ctr#);document.frmProductDetail.SKU.value = varSKU;">

Where the "document.frmProductDetail.SKU.value = varSKU;" should change the value of a text box:

<input type="text" name="SKU">

It works fine except on Safari. Any Ideas?

Thank you!!

 

[cLFlaVA]

1) get rid of the "javascript:" in your onclick event
2) use references such as: [tt]document.forms['frmProductDetail'].elements['SKU'].value[/tt]
3) show us code AFTER it's been generated by the browser (view > source).



*cLFlaVA
----------------------------

[URL unfurl="true"]http://www.coryarthus.com/[/url]

 

[BabyJeffy]

Could you also confirm that you have run your page code through the HTML validator at

http://validator.w3.org

? If it passes that, then you know your markup is valid (most problems are caused by invalid markup that one browser may handle whilst another may not).

Cheers,
Jeff

[tt]Jeff's Page @ Code Couch

http://www.codecouch.com/jeff/

http://www.codecouch.com/jeff/blog/

[/tt]

What is Javascript? FAQ216-6094

 

[Jawa]

I tried the new code to no avail:


<select name="Var3" style="width: (13 + 8)px;" class="textfield" onClick="a(this.value, 3);document.forms['frmProductDetail'].elements['SKU'].value = varSKU;">
<option value="0">Select Gift Set Size</option>
</select>


<input type="text" name="SKU" value="">

 

[cLFlaVA]

next questions become,

is width: (13 + 8)px even valid?
where are you setting varSKU? is it a global variable?
shouldn't you be using onchange, not onclick?



*cLFlaVA
----------------------------

[URL unfurl="true"]http://www.coryarthus.com/[/url]

 

[Jawa]

I thought onChange was not valid in Safari?

varSKU is global

The "is width: (13 + 8)px even valid?" is dynamically set. It works in all browsers so I think I am OK there.

This is so odd as it works across the board minun Safari.

Thanks!!

 

[BillyRayPreachersSon]

Change this:

style="width: (13 + 8)px;"

to this:

style="width: 21px;"

I'm surprised it works in any browser, to be honest.

onChange does work, and is valid in Safari.

Perhaps you are getting a JavaScript error at an earlier stage, stopping that JS from working?

Perhaps you can post a complete cut-down test harness, or a URL to your page?

Dan



[tt]Dan's Page [blue]@[/blue] Code Couch

http://www.codecouch.com/dan/

[/tt]

 

[BillyRayPreachersSon]

I thought onChange was not valid in Safari

But you never actually tried it to find out?

Suggest you give it a try.

Dan

[tt]Dan's Page [blue]@[/blue] Code Couch

http://www.codecouch.com/dan/

[/tt]

 

[BabyJeffy]

Could you also confirm that you have run your page code through the HTML validator at

http://validator.w3.org

?

You may have missed it first time.

I thought onChange was not valid in Safari?

No. It's totally valid. You should consider using it without the capitalisation, however.
Cheers,
jeff

[tt]Jeff's Page @ Code Couch

http://www.codecouch.com/jeff/

http://www.codecouch.com/jeff/blog/

[/tt]

What is Javascript? FAQ216-6094

 

[Jawa]

All your help is greatly appreciated.

I ran the site through a validator and it does some up with a bunch of issues (216) which I need to tak up with someone here. However, none of those errors are haulting its operation on PC/IE/FF. The safari thing is the debacle.

The page in question is:

http://puddin.foureyesweb.com/product_detail.cfm/Pid:220/SKU:BWB002-P

In safari the SKU switches out fidn using the get elementbyID in a DIV, but not in the text box ODD.

Thanks

 

[Jawa]

This does work

<input type="text" name="SKU" id="SKU" onmouseover="document.forms['frmProductDetail'].elements['SKU'].value = varSKU;">

 

[BillyRayPreachersSon]

I ran the site through a validator and it does some up with a bunch of issues (216) which I need to tak up with someone here. However, none of those errors are haulting its operation on PC/IE/FF. The safari thing is the debacle.

There you go again, blaming Safari.

You've just admitted your site is stuffed full of errors, but aren't willing to accept the possibility that any of them might just be stopping Safari working just because other browsers don't break.

Some browsers are more tolerant than others. I strongly suggest you come up with a cut-down, absolute minimum test harness that you can show to break in Safari, [!]and which validates[/!], before attempting to fix this one.

Dan

[tt]Dan's Page [blue]@[/blue] Code Couch

http://www.codecouch.com/dan/

[/tt]