Random while statement does not exit

[NateBro]

i'm trying to write a script that will generate 95 random numbers. basically i have a file that has 95 lines in it and i want it to randomly mix them up. i tried writing the below code, but it does not exit and keeps crashing.

open(FILE, "Format.txt");
@Coded = <FILE>;
close(FILE);

@MyUsed;
$NumberCheck;
for($i=0;$i<=$#Regulare;$i++){
# $Regulare[$i] =~ s/\n//g;
$lower=0;
$upper=$#Coded;
$random = int(rand( $upper-$lower+1 ) ) + $lower; 
	while (! $NumberCheck){
	CheckRandom($random);
	}
@MyUsed = (@MyUsed, "$random");
}
open(FILE, "> DoneCode.txt");
print FILE "@MyUsed";
close(FILE);


sub CheckRandom(){
    my ($rand) = @_;
    for($n=0;$n<=$#MyUsed;$n++){
    $myNumber = $MyUsed[$n];
    if ($myNumber == $rand){
    $random = int(rand( $upper-$lower+1 ) ) + $lower;
    } else {
    $NumberCheck = 1;
    }
    }
}

if there is another way to do this please let me know,
thanks so much for your time!

~ Nate_Bro

 

[PaulTEG]

I'd start by using strict.

What is @Regulare, and where is it created?

--Paul

Spend an hour a week on CPAN, helps cure all known programming ailments ;-)

 

[spyderco]

I concur.

Not using strict is flirting with the devil... but be careful, he has a nasty bite!

 

[TrojanWarBlade]

Just for fun, try this and see if it's any use:

perl -lne 'print sort { rand() <=> rand() } <>;' file_to_mix

Trojan.

 

[rharsh]

Here's another one-liner:

perl -MList::Util -le  "map {chomp; print} List::Util::shuffle(<>)" file_to_mix

 

[KevinADC]

thats what the module rharsh used is for, along with a few other options:

List::Util

I'm pretty sure it's a core module so you should hopefully have it in your perl installation.

 

[NateBro]

ok, very nice, I'll try those!
thanks for your help!

 

[NateBro]

Ok, this was exactly was i was looking for!

my @MyRandSort = sort { rand() <=> rand() } @Regulare;

Thank you soooooo much!

 

[KevinADC]

perl -lne 'print sort { rand() <=> rand() } <>;' file_to_mix

when I looked at that I thought it would generate duplictes in the new list, but it doesn't.

 

[NateBro]

Thanks agin guys, your such a big help!