Problems dynamically changing SELECT box

[phpPete]

The below code should add an option to a select box for each element in ana array.

I get one item added then an invalid argument error.

Any ideas?

function addToSelect(arr)
    {
    var oOption = document.createElement("OPTION");
    
    for(var i = 0; i < arr.length; i++ )        
          {
                
                oOption.text = arr[i];
                oOption.value = arr[i];
                t1.add(oOption);
          } 
        
      
    }

 

[Tarwn]

Try instantiating the option object inside your loop. What you have now will loop once, add the option, then loop again and attempt to add the same object a second time.

function addToSelect(arr)
    {
    var oOption;
    for(var i = 0; i < arr.length; i++ )        
          {
          oOption = new Option(arr[i],arr[i])
          t1.add(oOption);
          }
    }

On the fly, and my js usually has some rough edges, but this should be what your looking for. By instantiating a new option each time around you don't run into the problem of attempting to ad the same object twice.
-Tarwn ------------ My Little Dictionary ---------
Reverse Engineering - The expensive solution to not paying for proper documentation

 

[phpPete]

Thank You Thank You Thank YOU!!!
I was at my wits end!
You just saved what little hair I have left!!

Pete