problem with validation of a simple form Help

hemal666 · Oct 21, 2002

Hi i ve just writen some code to validate a simple form

the JS is not working at all, im completely lost please help!
heres the code::

<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN">
<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
<title>Untitled Document</title>
<SCRIPT LANGUAGE="JAVASCRIPT" TYPE="TEXT/JAVASCRIPT">
<!-- Hide Script From Old Browsers
function validfname(fname) {
if (fname == "&quot

{
return false // Check not empty
}
return true
}
function validsname(sname) {
if (sname == "&quot

{
return false // Check not empty
}
return true
}

function submitform(check) {
if(!validfname(check.fname.value)) {
alert("No First Name Entered&quot

check.fname.focus()
check.fname.select()
return false
}
if(!validsname(check.sname.value)) {
alert("No First Name Entered&quot

check.sname.focus()
check.sname.select()
return false
}
else
return true
}
// end hiding -->
</SCRIPT>
</head>
<body bgcolor="#FFFFFF" text="#000000"><font face="Arial, Helvetica, sans-serif">
<CENTER>
<p>
Please Enter the Following Details
<p>
Boxes marked with an asterix are Required
<FORM METHOD=POST onSubmit="Submitform(this)" ACTION="registerinterest.asp">
First Name <INPUT TYPE="TEXT" NAME="fname" SIZE="20">
<P>
Surname <INPUT TYPE="TEXT" NAME="sname" SIZE="20">
<P>
House Number <INPUT TYPE="TEXT" NAME="hfno" SIZE="4">
<p>
Address Line 1 <INPUT TYPE="TEXT" NAME="add1" SIZE="50">
<P>
Address Line 2 <INPUT TYPE="TEXT" NAME="add2" SIZE="50">
<P>
Post Code <INPUT TYPE="TEXT" NAME="pcode" SIZE="8">
<P>
Day Time Tel <INPUT TYPE="TEXT" NAME="daytel" SIZE="12">
<P>
Evening Tel <INPUT TYPE="TEXT" NAME="evetel" SIZE="12">
<P>
Mob Tel <INPUT TYPE="TEXT" NAME="mobtel" SIZE="12">
<P>
Best Time to Contact You <INPUT TYPE="TEXT" NAME="btoc" SIZE="30">
<P>
<TEXTAREA NAME="detreq" ROWS="3" COLS="75">Your Requirments.......... This section is MANDATORY!!</TEXTAREA>
<P>
<INPUT TYPE=RESET><INPUT TYPE="SUBMIT">
</FORM>
<CENTER>
</body>
</html>

ts2032 · Oct 21, 2002

hemal,
you might try onSubmit="return Submitform(this)"

good luck,

tsmith

starway · Oct 22, 2002

There are several errors in your code.

1. In your validsname() and validfname() functions, instead of this:
. . .
}
return true
}

do this:
. . .
}
else
return true
}

2. In html you have this: onSubmit="Submitform(this)"
but in your script I see this: function submitform(check)
Javascript is case-sensitive language, therefore "Submitform" and "submitform" are two different things. Make it all the same (I recommend changing all to lowercase).

3. Change onSubmit="submitform(this)"
to onSubmit="return submitform(this)"

4. If the field is empty, I don't know why you do this:
check.sname.select()
as there's nothing to select there.

Also, I'd recommend you to change the validation method to more simple, like looping through the form elements and checking their values. Search this forum and you'll find examples (I posted them several times).

hemal666 · Oct 22, 2002

thax peeple it works now

Tek-Tips is the largest IT community on the Internet today!

Members share and learn making Tek-Tips Forums the best source of peer-reviewed technical information on the Internet!

problem with validation of a simple form Help

hemal666

Programmer

ts2032

Technical User

starway

Programmer

hemal666

Programmer

Similar threads

Part and Inventory Search

Sponsor