Problem with IF/Else syntax

rry2k · Mar 18, 2002

I'm creating a menu and have started to add if/else logic.
I'm getting errors which I think are being generated by the braces being wrong. Please help. Thanks..Russ

<html>
<head>
<title>menu</title>
<script language="javascript">
function Navigate() {
prod = document.menuform.woodtype.selectedIndex;
val = document.menuform.woodtype.options[prod].value;
icolor = document.menuform.woodcolor.selectedIndex;
ival = document.menuform.woodcolor.options[icolor].value;
if (val = "cherry&quot

{
document.write("The type selected is " + val + "<br>&quot

;
else
document.write("The color selected is " + ival);
}
}
</script>
</head>
<body>
<form name="menuform">
<b>type of wood</b>
<select name ="woodtype">
<option value="mahogony">mohogany
<option value="maple">maple
<option value="pine">pine
<option value="cherry">cherry
</select>     &nbsp
<input type="button" name="go" value = Go to Function"
onClick="Navigate();">
<b>color of wood</b>
<select name ="woodcolor">
<option value="Red">red
<option value="brown">brown
<option value="white">white
<option value="beige">beige
</select>
</body>

</form>
</html>

jlsmithhartfiel · Mar 18, 2002

Try:

Code:

<script language=&quot;javascript&quot;>
function Navigate() {
prod = document.menuform.woodtype.selectedIndex;
val = document.menuform.woodtype.options[prod].value;
icolor = document.menuform.woodcolor.selectedIndex;
ival = document.menuform.woodcolor.options[icolor].value;
if (val = &quot;cherry&quot;) {
document.write(&quot;The type selected is &quot; + val + &quot;<br>&quot;); 
}
else {
document.write(&quot;The color selected is &quot; + ival);
}
}
</script>

DoubleV · Mar 18, 2002

Code:

<html>
<head>
<title>menu</title>
<script language=&quot;javascript&quot;>
function Navigate() {
 prod = document.menuform.woodtype.selectedIndex;
 val = document.menuform.woodtype.options[prod].value;
 icolor = document.menuform.woodcolor.selectedIndex;
 ival = document.menuform.woodcolor.options[icolor].value;
 if (val == &quot;cherry&quot;) {
 document.write(&quot;The type selected is &quot; + val + &quot;<br>&quot;);
 }
 else {
 document.write(&quot;The color selected is &quot; + ival);
 }
}
</script>
</head>
<body>
<form name=&quot;menuform&quot;>
<b>type of wood</b>
    <select name =&quot;woodtype&quot;>
    <option value=&quot;mahogony&quot;>mohogany
    <option value=&quot;maple&quot;>maple
    <option value=&quot;pine&quot;>pine
    <option value=&quot;cherry&quot;>cherry
    </select>      
    <input type=&quot;button&quot; name=&quot;go&quot; value = Go to Function&quot;
    onClick=&quot;Navigate();&quot;>
<b>color of wood</b>
<select name =&quot;woodcolor&quot;>
<option value=&quot;Red&quot;>red
<option value=&quot;brown&quot;>brown
<option value=&quot;white&quot;>white
<option value=&quot;beige&quot;>beige
</select>
</body>
</form>
</html>

here's your fixed code and a couple of tips:
1. you have only enclosed an entire if/else statements into brackets, but in js you actually need to enclose each if and else statement into its own brackets like:
if (condition) {
do if condition is true
}
else {
do else
}

2. please note that I have changed your condition from (val = "cherry&quot

to (val == "cherry&quot

when you only write one "=" it means assigning a value.
i.e. when you say val = "cherry" you assing a value "cherry" to the variable named val
on the other hand, when you use double "==" it means comparison. I was told a neat thing once. think of it as "exactly equals" and then you will always remember to put two equal signs.
when you say if (val == "cherry&quot

you are saying does a variable of val exactly equal "cherry"?

HTH --------------------------------------------------
Goals are dreams with deadlines

spewn · Mar 18, 2002

assing.

- spewn

Tek-Tips is the largest IT community on the Internet today!

Members share and learn making Tek-Tips Forums the best source of peer-reviewed technical information on the Internet!

Problem with IF/Else syntax

rry2k

Programmer

jlsmithhartfiel

Programmer

DoubleV

Programmer

spewn

Programmer

Similar threads

Part and Inventory Search

Sponsor