Problem with displaying message box? 1

[DazzaC]

Hello guys,
I require a little assistance with a problem I am experiencing?
I have a VBScript that calls an application using the Shell command

Shell "c:\di_diver\version1\integ.bat", vbNormalFocus

This opens a cmd window and the application executes in this window.
What I cannot figure out is how to only display the Msgbox "Extract Complete" when this has finished?
As it stands the Message box appears as soon as the extract starts?
Any ideas how to only show this when the extract completes?
At the moment sometimes it does not complete properly (no drive mapping) but appears to the operators as though it has worked?
Thanks

 

[tsuji]

Hello DazzaC,

Specify the bWaitOnReturn like this.

Shell "c:\di_diver\version1\integ.bat", vbNormalFocus, true

regards - tsuji

 

[DazzaC]

I tried this and received an error message:

This is the code:

Private Sub Command3_Click()
'Execute script. Script uses integ.exe and liverpool1.int to capture date range
Shell "c:\di_diver\version1\integ.bat", vbNormalFocus, True
MsgBox "Daily Extract Completed. Please proceed to next step", vbInformation, "Extract Complete"
End Sub

Error message:

Wrong number of arguements or invlaid property assignment?

 

[tsuji]

DazzaC,

What is Shell? What does the line look like where you instantiate it?

- tsuji

 

[tsuji]

Correction:

Of course, you need .run. (I've copy & paste your line!)

set Shell=createobject("wscript.shell")
Shell.run "c:\di_diver\version1\integ.bat", vbNormalFocus, true

- tsuji

 

[DazzaC]

Hi tsuji,

Thanks for your help. Still experiencing problems tho?

When I attempt to compile the program I get an error on the line:

Set Shell = CreateObject("wscript.shell")

Compile Error: Argument not optional

Thanks

 

[tsuji]

DazzaC,

Are you doing in vb? If yes, pose to vb forum.

- tsuji

 

[DazzaC]

I had it posted there and others advised me to post it here!!

I will post it there as well thanks

 

[DazzaC]

Sorry, yes I am doing it ib VB as well Vb 6?

 

[tsuji]

DazzaC,

To do synchronous execution using shell, you need more coding. You monitor the process from the return value of shell(), the handle of it, by OpenProcess(). Then use GetExitCodeProcess() to check whether the process is still alive. If no longer, CloseHandle() of it. I think, vb forum will give you better advice.

- tsuji

 

[PHV]

As you're in VB, Shell is a reserved word (in fact a function).
You may try something like this:
Set Sh = CreateObject("WScript.Shell")
Sh.Run "c:\di_diver\version1\integ.bat", vbNormalFocus, True

Hope This Helps, PH.
Want to get great answers to your Tek-Tips questions? Have a look at FAQ219-2884 or FAQ222-2244

 

[DazzaC]

PHV, Many thanks this resolved my problem!!!

A star for you!!