This is a very good question. The answer is, "It depends". You can use the configuration you mentioned above to give priority on the ourbound for all destined for the other site. This should work pretty well since the PIX will encapsulate the packets as it gets them. You can set up a Cisco 806 as the IOS router to forward all packets to the PIX firewall destined for the VPN before other traffic. You can even bump up its QoS value and the PIX will retain that once it is decapsulated. However, the PIX doesn't understand, yet, QoS and doesn't prioritize traffic either. So weighted queueing would probably be the answer here.
There may be an easier way to do this. If you have routers connecting you to the internet (versus a cable modem), you can set up queueing on them instead. You can set all traffic desitined from the local PIX to the remote PIX to be sent out before other traffic. Granted this is all VPN traffic, but most companies won't mind that. You may have everything you need to do it already.
As far s the Avaya PBX, scrap it for a new callmanager system. It is typically cheaper and works better with your PIX and, hopefully, Cisco infrastructure.
It is what it is!!
__________________________________
A+, Net+, I-Net+, Certified Web Master, MCP, MCSA, MCSE, CCNA, CCDA, and few others (I got bored one day)