Setting Avaya phones up as VPN phones. Used that setup for years. but you can have issue with some Internet Providers, and when they need to change the user password.
Softphones work to, could see issue with PC that or over tasked. And on both setup you have to remember that you are at the mercy of the internet provider. It will be Voice Over the internet.