Passing Data

[JamesHanley]

I am trying to Pass whatever is selected in cboApps from Form1.cs(gui) to SLAFunctions.cs(code only).

Whatever is selected in drop down menu needs to be passed to another form, how do i do this?

Please..

 

[earthandfire]

Unless I've misunderstood (quite probable ), why not have a public / shared variable in SLAFunctions which could then be accessed from anywhere with a reference to SLAFunctions e.g.

in Form1 you could have ...
SLAFunctions.MySharedVariable = cboApps.SelectedItem.ToString


Hope I'm not way off the mark and that this helps.

 

[JamesHanley]

Can i uplad my .cs fils to the web and have u look at them. I really do appriciate the help. I am a graphic designer and web programmer lol. I took this project on to help the old people at work lol, they needed new ideas.

 

[earthandfire]

A quick look at your sample:

string sSQL = "SELECT textcombo, last_name, first_name, fin_unit_no, rpt_to_user_id, line_of_business, emp_status from nonsensitive_hr_general_use WHERE user_id = @userid";


should this not be:

string sSQL = "SELECT " + textcombo + ", last_name, first_name, fin_unit_no, rpt_to_user_id, line_of_business, emp_status from nonsensitive_hr_general_use WHERE user_id = @userid";


Hope this helps.

 

[JamesHanley]

textcombo is not defined as cboApps.Text.

if it were then yes, but that is the problem for some reason
I can't get it to recognize what cboApps.Text is

when i typed in:

Form1 textcombo = new Form1(cboApps.Text);
textcombo.show();

It had no idea what cboApps.text is.


HERE IS CODE FROM BOTH FORMS:


--------------------FORM1 Includes cboApps------------------

using System;
using System.Drawing;
using System.Collections;
using System.ComponentModel;
using System.Windows.Forms;
using System.Collections.Specialized;
using System.Configuration;
using System.Data;

namespace ServiceLevelAgreement
{
/// <summary>
/// Summary description for Form1.
/// </summary>
public class Form1 : System.Windows.Forms.Form
{
public System.Windows.Forms.ComboBox cboApps;

private SLAFunctions sla;
private System.Windows.Forms.DataGrid dataGrid1;
private System.Windows.Forms.Button button1;

/// <summary>
/// Required designer variable.
/// </summary>
private System.ComponentModel.Container components = null;

public Form1()
{
//
// Required for Windows Form Designer support
//

InitializeComponent();
//
// TODO: Add any constructor code after InitializeComponent call
//
}

/// <summary>
/// Clean up any resources being used.
/// </summary>
protected override void Dispose( bool disposing )
{
if( disposing )
{
if (components != null)
{
components.Dispose();
}
}
base.Dispose( disposing );
}

#region Windows Form Designer generated code
/// <summary>
/// Required method for Designer support - do not modify
/// the contents of this method with the code editor.
/// </summary>
private void InitializeComponent()
{
this.cboApps = new System.Windows.Forms.ComboBox();
this.dataGrid1 = new System.Windows.Forms.DataGrid();
this.button1 = new System.Windows.Forms.Button();
((System.ComponentModel.ISupportInitialize)(this.dataGrid1)).BeginInit();
this.SuspendLayout();
//
// cboApps
//
this.cboApps.DropDownStyle = System.Windows.Forms.ComboBoxStyle.DropDownList;
this.cboApps.Location = new System.Drawing.Point(48, 32);
this.cboApps.Name = "cboApps";
this.cboApps.Size = new System.Drawing.Size(184, 21);
this.cboApps.TabIndex = 0;
this.cboApps.SelectedIndexChanged += new System.EventHandler(this.cboApps_SelectedIndexChanged);
//
// dataGrid1
//
this.dataGrid1.DataMember = "";
this.dataGrid1.HeaderForeColor = System.Drawing.SystemColors.ControlText;
this.dataGrid1.Location = new System.Drawing.Point(280, 16);
this.dataGrid1.Name = "dataGrid1";
this.dataGrid1.Size = new System.Drawing.Size(312, 328);
this.dataGrid1.TabIndex = 1;
//
// button1
//
this.button1.Location = new System.Drawing.Point(160, 64);
this.button1.Name = "button1";
this.button1.TabIndex = 2;
this.button1.Text = "button1";
this.button1.Click += new System.EventHandler(this.button1_Click);
//
// Form1
//
this.AutoScaleBaseSize = new System.Drawing.Size(5, 13);
this.ClientSize = new System.Drawing.Size(608, 373);
this.Controls.Add(this.button1);
this.Controls.Add(this.dataGrid1);
this.Controls.Add(this.cboApps);
this.Name = "Form1";
this.Text = "Form1";
this.Load += new System.EventHandler(this.Form1_Load);
((System.ComponentModel.ISupportInitialize)(this.dataGrid1)).EndInit();
this.ResumeLayout(false);

}
#endregion

/// <summary>
/// The main entry point for the application.
/// </summary>
[STAThread]
static void Main()
{
Application.Run(new Form1());


}

private void Form1_Load(object sender, System.EventArgs e)
{
NameValueCollection nvcApplications = (NameValueCollection) ConfigurationSettings.GetConfig("SLAApplications/Applications");
for (int i=0;i<nvcApplications.Count;i++)
{
cboApps.Items.Add(nvcApplications.Keys);
}

sla = new SLAFunctions();

}

private void button1_Click(object sender, System.EventArgs e)
{
MessageBox.Show("This May Take A Few Moments. Thank You.");
DataSet lstDataSet = new DataSet();
sla.HRDataSet(lstDataSet, cboApps.Text);
dataGrid1.DataSource = lstDataSet.Tables[0];
}

private void cboApps_SelectedIndexChanged(object sender, System.EventArgs e)
{
return;{}
}
}
}

-------------------------SLAFunctions.cs--------------------

using System;
using PinnacleWest.CommonBaseServices.APSDSA;
using System.DirectoryServices;
using System.Collections;
using System.Data.SqlClient;
using System.Data;

namespace ServiceLevelAgreement
{
/// <summary>
/// Summary description for SLAFunctions.
/// </summary>

public class SLAFunctions
{

internal Hashtable h_Logins = new Hashtable();

public SLAFunctions()
{

}

internal string Init_DSAHR()
{
string s_Tranname = System.Configuration.ConfigurationSettings.AppSettings["dsa_HRData"] ;
string sDatabase = System.Configuration.ConfigurationSettings.AppSettings["HRDATABASE"];

DSACheck od = new DSACheck();
od.DSA_tran_name = s_Tranname;

od.GetConnectInfo();
string s_Password = od.DSA_tran_ticket;//+ "123";;
string s_Username = od.DSA_tran_id;// + "123";
string sServer = od.DSA_server_name;
SqlConnection HRCONN = new SqlConnection();
return GetConnectionHR(s_Username,s_Password, sServer, sDatabase);
}


internal string GetConnectionHR(string sUser, string sPass, string sServer, string sDatabase)
{

return "Server=" + sServer + ";database=" + sDatabase + ";User ID=" +
sUser + ";Password=" + sPass + ";";

}



public void HRDataSet(DataSet ds, string sGroup)
{
h_Logins.Clear();

LoadAppMembers(sGroup);

SqlConnection conn = new SqlConnection(Init_DSAHR());
conn.Open();

ds.Tables.Add();

ds.Tables[0].Columns.Add("Application",System.Type.GetType("System.String"));
ds.Tables[0].Columns.Add("Last Name",System.Type.GetType("System.String"));
ds.Tables[0].Columns.Add("First Name", System.Type.GetType("System.String"));
ds.Tables[0].Columns.Add("User ID", System.Type.GetType("System.String"));
ds.Tables[0].Columns.Add("Financial Unit", System.Type.GetType("System.String"));
ds.Tables[0].Columns.Add("Manager ID", System.Type.GetType("System.String"));
ds.Tables[0].Columns.Add("Line Of Business", System.Type.GetType("System.String"));
ds.Tables[0].Columns.Add("Employee Status", System.Type.GetType("System.String"));


string sSQL = "SELECT textcombo, last_name, first_name, fin_unit_no, rpt_to_user_id, line_of_business, emp_status from nonsensitive_hr_general_use WHERE user_id = @userid";


SqlCommand cmd = new SqlCommand(sSQL, conn);

cmd.CommandType = CommandType.Text;

SqlParameter param = new SqlParameter("@userid", SqlDbType.VarChar, 6, "user_id");
cmd.Parameters.Add(param);

// SqlDataAdapter da = new SqlDataAdapter(cmd);

foreach (DictionaryEntry myDE in h_Logins)
{
SqlDataReader rdr = null;
cmd.Parameters["@userid"].Value = myDE.Value;
try
{
rdr = cmd.ExecuteReader();
}
catch (Exception ex)
{
int icount = 5;
}

while (rdr.Read())
{
DataRowCollection drc = ds.Tables[0].Rows;
DataRow dr;
object[] mynewrow = new object[7];
mynewrow[0] = rdr["last_name"].ToString();
mynewrow[1] = rdr["first_name"].ToString();
mynewrow[2] = myDE.Value;
mynewrow[3] = rdr["fin_unit_no"].ToString();
mynewrow[4] = rdr["rpt_to_user_id"].ToString();
mynewrow[5] = rdr["line_of_business"].ToString();
mynewrow[6] = rdr["emp_status"].ToString();

dr = drc.Add(mynewrow);

}
rdr.Close();

}

}

private void LoadAppMembers(string sGroup)
{
ActiveDs.IADsMembers MembersCollection = null;

DirectoryEntry groupEntry = new DirectoryEntry("LDAP://cn=" + sGroup + ",cn=Users,dc=apsc,dc=com");

System.DirectoryServices.PropertyCollection pcoll = groupEntry.Properties;

MembersCollection = groupEntry.Invoke("Members") as ActiveDs.IADsMembers;

object[] filter = {"user"};


foreach (ActiveDs.IADsUser member in MembersCollection)
{
if (member.FullName.IndexOf("(") != -1)
{
string userid = member.FullName.Substring(member.FullName.IndexOf("("));

userid = userid.Substring(1, userid.Length - 2);
if (userid.Length == 7) userid = userid.Substring(0, userid.Length-1);
h_Logins.Add(userid, userid);
}
}

return;
}
}
}





I Removed Everything Reccommended To Have A Clean Start...

 

[JurkMonkey]

A Form is simply a view of data. It should not control or store your data in any way.

What you need is a type of data storage class, otherwise known as a model. This could be connected to a database, xml, textfiles, or just in memory.

You then need a class that will access and manipulate that storage class. This class is known as a Controller.

Your Form, the view, should then make requests to the controller to manipulate the data.

myController.UpdateUserInformation(usrname, password, firstname, lastname);

Then you can create another form in the future, that simply acts as another view of the data without re-writing your application.

This is known as the Model View Controller Design Pattern. I have greatly simplified it in this case.

 

[JamesHanley]

Dude, that is 100% not necessary!

If u really looked through code you would see that i am pulling data from a database. This data is then put onto a Datagrid. organized by colums. I am trying to add another colum that simply shows which cboApps.Text they selected.

for example App-MSProject 200 is one of the items on the drop menu.

when that is selected to connects to Active directory nabs the users found in the MSProject 2000 group, then compares the user information with that of the database also stored somewhere on our network.

This information is posted onto a data grid.

Just need to add a single colum on the datagrid that shows, which group they found the user in. AKA cboApps.Text

Need SLAFunctions form to know what cboApps.Text is from Form1

 

[earthandfire]

You are trying read the combobox from SLAFunctions.

Try this instead:

private void cboApps_SelectedIndexChanged(object sender, System.EventArgs e)
{
assign textcombo here
return;{}
}


In other words, assign textcombo from the form whenever the combobox changes.


Hope this helps.

 

[chiph]

Dude, that is 100% not necessary

It is if you want your code to be maintainable.

Chip H.


____________________________________________________________________
If you want to get the best response to a question, please read FAQ222-2244 first

 

[JurkMonkey]

You should use design patterns wherever possible. Your applications become maintainable and scalable. It may seem like extra work now - but it is well worth it.

 

[JamesHanley]

Chiph, why would i want to store drop down menu items on a DBA. Lol that is what you are saying.

earthandfire - where do i place that code, which form. cause if i was to put it on the Form1.cs i would not not beable to access it from SLAFunctions.cs.

so the only thing i need to add is this to form1:

public string textcombo;

private void cboApps_SelectedIndexChanged(object sender, System.EventArgs e)
{
textcombo = cboApp.Text
return;{}
}

then on SLAFunctions what do i put?

 

[chiph]

Sorry - thought you were replying to JurkMonkeys advice to use a Model class to hold the View's data.

Chip H.


____________________________________________________________________
If you want to get the best response to a question, please read FAQ222-2244 first

 

[earthandfire]

From you reply (20 Jun 06 10:45 )

public class SLAFunctions
{
public string textcombo;
internal Hashtable h_Logins = new Hashtable();

public SLAFunctions()
{

}

but you seem to have removed this from your later listing

In you form you have

sla = new SLAFunctions();


so:

public string textcombo;

private void cboApps_SelectedIndexChanged(object sender, System.EventArgs e)
{
sla.textcombo = cboApp.Text // I would use cboApp.SelectedItem.ToString (but that's personal preference)
return;{}
}


This should do what you want (I think) - if you wrote it in VB it would be much easier to understand


Hope this helps.

 

[JamesHanley]

I dont know where to put all that code... lol... this is messy giving me a headache, should take 5 minutes to do this. I am sorry everyone. Thanks for all your help

 

[JamesHanley]

sla is already being used by another function.

 

[earthandfire]

I've just read you SLAFunctions a bit more closely.

I don't think you need textcombo anywhere.


Try this:

  private void cboApps_SelectedIndexChanged(object sender, System.EventArgs e)
        {
          button1.PerformClick()
        }

Since button1's click handler picks up and passes the text in the combobox - that should be all that you need.


Before Chiph and JurkMonkey comment, it would be better (but not necessary) if you took the code out of button1's click handler and put it into a separate function within the form, which you could then call directly from the button's click and the combobox's SelectedIndexChanged handlers.


Hope this helps.

 

[JurkMonkey]

 

[JamesHanley]

Ok, this is goign to far..... I do not understand what that is supposed to do.

This should be so damn simple. Ok Lets Act Like This is my first post, and i have code that is working properly so far.
I have not added any features onto my code that would signify me trying to use cboApps.text on the SLAFunctions form. Here is my current working code: (without text bs)

http://justborndesigns.com/Form1.cs

(main form with graphic)

http://justborndesigns.com/SLAFunctions.cs

(code only)

How do i use cboApps.Text on SLAFunctions.cs?

 

[earthandfire]

I assume that the button1 code works as expected - if so

try replacing:

		private void Form1_Load(object sender, System.EventArgs e)
		{
			NameValueCollection nvcApplications = (NameValueCollection) ConfigurationSettings.GetConfig("SLAApplications/Applications");
			for (int i=0;i<nvcApplications.Count;i++)
			{
				cboApps.Items.Add(nvcApplications.Keys[i]);
			}		

			sla = new SLAFunctions();

		}

		public void cboApps_SelectedIndexChanged(object sender, System.EventArgs e)
		{
			sla.textcombo = cboApps.Text; // I would use cboApp.SelectedItem.ToString (but that's personal preference)
			return;{} 
		}

		private void button1_Click(object sender, System.EventArgs e)
		{
			MessageBox.Show("This May Take A Few Moments. Thank You.");
			DataSet lstDataSet = new DataSet();
			sla.HRDataSet(lstDataSet, cboApps.Text);
			dataGrid1.DataSource = lstDataSet.Tables[0];
		}

with

		private void Form1_Load(object sender, System.EventArgs e)
		{
			NameValueCollection nvcApplications = (NameValueCollection) ConfigurationSettings.GetConfig("SLAApplications/Applications");
			for (int i=0;i<nvcApplications.Count;i++)
			{
				cboApps.Items.Add(nvcApplications.Keys[i]);
			}		

			sla = new SLAFunctions();

		}

		public void cboApps_SelectedIndexChanged(object sender, System.EventArgs e)
		{
			button1.PerformClick
		}

		private void button1_Click(object sender, System.EventArgs e)
		{
			MessageBox.Show("This May Take A Few Moments. Thank You.");
			DataSet lstDataSet = new DataSet();
			sla.HRDataSet(lstDataSet, cboApps.Text);
			dataGrid1.DataSource = lstDataSet.Tables[0];
		}

and remove the line shown in bold from here:

namespace ServiceLevelAgreement
{
	/// <summary>
	/// Summary description for SLAFunctions.
	/// </summary>
	public class SLAFunctions
	{
		internal Hashtable h_Logins = new Hashtable();
		[b]public string textcombo;[/b]
		public SLAFunctions()
		{
			//
			// TODO: Add constructor logic here
			//
		}

Hope this helps.

 

[JamesHanley]

Ok, that made it so i actually have no use for my button, but i can deal with that.

Did exactly what u reccomend, now, how do i tell textcombo on SLAFunctions.cs that it is attatched to cboApps.text?