... it's quite a common construction because it doesn't change the value of any register except the flags, and it's often shorter than cmp.
But if you can use test, test is sometimes quicker; because or would usually change the value of the destination register, any subsequent instruction using that register as a source will be delayed in the pipeline (even though this particular or won't change anything) until the or is completed. Not usually a big issue, but...