Tek-Tips is the largest IT community on the Internet today!

Members share and learn making Tek-Tips Forums the best source of peer-reviewed technical information on the Internet!

Register Log in

Congratulations TouchToneTommy on being selected by the Tek-Tips community for having the most helpful posts in the forums last week. Way to Go!

Opening External javscript function through a link 1

Thread starter DBSSP
Start date Feb 13, 2003

Status: Not open for further replies.

Feb 13, 2003

#1

DBSSP

Programmer

I have coded a frameless popup window as a function but I would like to make the code an external file. I have created the external file but can't figure out how to call the function from my html page with a link or button. I've been fighting with this for for a day now! [mad]

[mad]

Any ideas on how I can do this? [idea]

[idea]

Jay

[infinity]

"If the words up and down were reversed, would you trip and fall or trip and fly?"

Sort by date Sort by votes

Feb 13, 2003

1

#2

jemminger

Programmer

eh?
<script language="javascript" src="externalFile.js"></script>

<input type="button" value="Click Me" onclick="functionName();"/>

<a href="#" onclick="functionName();">Click Me</a>
=========================================================
if (!succeed) try();
-jeff

Upvote 0 Downvote

Feb 14, 2003

Thread starter
#3

DBSSP

Programmer

I've tried both of those and keep getting an error "Object Expected". Same thing that happening to me before. Any ideas why? I do appreciate the input though! Jay [infinity]

[infinity]

"If the words up and down were reversed, would you trip and fall or trip and fly?"

Upvote 0 Downvote

Feb 14, 2003

#4

jemminger

Programmer

"Object expected" means it cannot find the function you're calling.

let me see if I understand: you have a function in an external js include (.js file), and you want to be able to access that function from a pop-up window?

=========================================================
if (!succeed) try();
-jeff

Upvote 0 Downvote

Feb 14, 2003

Thread starter
#5

DBSSP

Programmer

Close!
I'm trying to call the external function from an html document. The function then opens a popup window. Does this make a little better sense?

It works, of course, if I include the whole script in the html document that calls the function, but I want it external (less clutter, easier maintanance). Jay [infinity]

[infinity]

"If the words up and down were reversed, would you trip and fall or trip and fly?"

Upvote 0 Downvote

Feb 14, 2003

#6

jemminger

Programmer

this is the proper syntax for including an external js file:
[tt]
<html>
<head>

<script language="javascript" src="myFile.js"></script>

</head>
<body>
My page contents here...
</body>
</html>
[/tt]

make sure NOT to include the <script> & </script> tags inside the myFile.js file!

myFile.js:[tt]
// beginning of file

function myFunction() {

}

// end of file
[/tt]

=========================================================
if (!succeed) try();
-jeff

Upvote 0 Downvote

Feb 14, 2003

Thread starter
#7

DBSSP

Programmer

It's not working at all. I still get the same thing. let me show you the code so that you can get a better understanding of how it's suppossed to work. Maybe the remedy is right in front of me, I'm just not seeing it! lol

Begin Code
***************************
// set the popup window width and height

var windowW=583 // wide
var windowH=330 // high
//~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
//Set the screen position where the popup should appear.
// See the following settings.
//***************************************************************
//Programmer Specifies Window Position *
// Un-comment Set 1 & Comment Set 2 out*
//Automatically center on screen *
// Un-comment Set 2 & Comment Set 1 out
//**********************************************************
//---------------
//Set 1 |
//---------------
//var windowX = 260 // from left
//var windowY = 100 // from top
//---------------
//Set 2 |
//---------------
var windowX = (screen.width/2)-(windowW/2);
var windowY = (screen.height/2)-(windowH/2);
//~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
// set the url of the page to show in the popup

var urlPop = "The web site.htm"

// set the title of the page

var title = "Calculator"

// set this to true if the popup should close
// upon leaving the launching page; else, false

var autoclose = true

// ============================
// do not edit below this line
// ============================

s = "width="+windowW+",height="+windowH;
var beIE = document.all?true:false

function openFrameless(){
if (beIE){
JMS = window.open("","popFrameless","fullscreen,"+s)
JMS.blur()
window.focus()
JMS.resizeTo(windowW,windowH)
JMS.moveTo(windowX,windowY)
var frameString=""+
"<html>"+
"<head>"+
"<title>"+title+"</title>"+
"</head>"+
"<frameset rows='*,0' framespacing=0 border=0 frameborder=0>"+
"<frame name='top' src='"+urlPop+"' scrolling=auto>"+
"<frame name='bottom' src='about:blank' scrolling='no'>"+
"</frameset>"+
"</html>"
JMS.document.open();
JMS.document.write(frameString)
JMS.document.close()
} else {
JMS=window.open(urlPop,"popFrameless","scrollbars,"+s)
JMS.blur()
window.focus()
JMS.resizeTo(windowW,windowH)
JMS.moveTo(windowX,windowY)
}
JMS.focus()
if (autoclose){
window.onunload = function(){JMS.close()}
}
}
**********************************
End Code

So there's my java script file. I'll keep trying things, thanks for your help so far though! Anyone who wants to use this code, please feel free to do so! Jay [infinity]

[infinity]

"If the words up and down were reversed, would you trip and fall or trip and fly?"

Upvote 0 Downvote

Feb 14, 2003

#8

jemminger

Programmer

i made two test pages:

1. has the above script directly on it
2. uses the above script in an external include.

both work properly.

look at the line that it says "Object expected" at ... make sure you're spelling the function correctly. javascript is case sensitive.

=========================================================
if (!succeed) try();
-jeff

Upvote 0 Downvote

Feb 14, 2003

Thread starter
#9

DBSSP

Programmer

<html>
<head>
<title>Test Page</title>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
<script src="/JavaScripts/TestPop3calc.js"></script>
</head>
<body bgcolor="#FFFFFF" text="#000000">

<a href="#" onclick="openFrameless();">Click Me</a>
</body>
</html>

This is how I have it in the calling html page, and I'm still getting an error. Arrrgggg! This is very frustrating and I know I'm missing something extremely dumb. I also tried the full path for the javascript. Here is what I get.

Line 9, char 1 (referring to the above link), Object Expected, code 0.... Jay [infinity]

[infinity]

"If the words up and down were reversed, would you trip and fall or trip and fly?"

Upvote 0 Downvote

Feb 14, 2003

#10

jemminger

Programmer

<script src="/JavaScripts/TestPop3calc.js"></script>

beginning your src URI with the forward slash "/" instructs the browser to start in the ROOT of your directory...so if your page is running from "c:/folder/web/page.html", then the above include will start in C:
if your include actually resides in c:/folder/web/JavaScripts/ then remove the leading forward slash.

hope this helps
=========================================================
if (!succeed) try();
-jeff

Upvote 0 Downvote

Feb 14, 2003

Thread starter
#11

DBSSP

Programmer

Your not gonna believe this, but I tried the full path and I'm still getting the same error...But I tried something else, I tried uploading the file to my webserver (duh!) and used an http reference and it works! I knew it was something dumb I was doing! Thank you for your help, it was greatly appreciated! Star For you! Jay [infinity]

[infinity]

"If the words up and down were reversed, would you trip and fall or trip and fly?"

Upvote 0 Downvote

Mar 30, 2003

#12

KEN954

Programmer

I had the same problem as DBSSP and I did what he did.

I uploaded my files to the server and bingo...

I know why I couldn't src my .js file on my local windows machine. I put it directly in the same directory as my HTML page.

!!! I also removed the <SCRIPT></SCRIPT> tags and just used the bare functions in my scripts.js file. I don't know if this was important, but I think it makes sense.

Ken954

Upvote 0 Downvote

Mar 31, 2003

#13

jemminger

Programmer

Ken954,

yes, you should not include <script></script> in the actual .js include.

what version windows are you running?
=========================================================
while (!succeed) try();
-jeff

Upvote 0 Downvote

Mar 31, 2003

#14

KEN954

Programmer

I am using windows 2000, but I don't have a problem any longer... I work locally with the scripts on the page and then I cut the scripts and save them to a .js file and upload the works to the server.

I strip the script tags on the .js file.

Everything works fine then.

Thanks for your help... I wouldn't have know to strip the script tags.

Ken

Upvote 0 Downvote

Mar 31, 2003

#15

EdwardMartinIII

Technical User

DBSSP,

Just on a lark, try putting a copy of your .js file in the same directory as your calling HTML file. Then -- again, temporarily -- change the line in your HTML to read

Code:

<script language=&quot;javascript&quot; src=&quot;TestPop3calc.js&quot;></script>

Using the full http might have done the trick, but could kill your portability. If you can get it to run this way, then your trouble was with the path as previously described. Fixing a bad path is always a good idea.

Cheers,
[monkey]

[monkey]

Edward

[monkey]

"Cut a hole in the door. Hang a flap. Criminy, why didn't I think of this earlier?!" -- inventor of the cat door

Upvote 0 Downvote

Status: Not open for further replies.

Similar threads

Locked
Question

Passing fields from (html-JavaScript) table to JavaScript Function

Replies: 0

Views: 826

Apr 18, 2024

lexer

Locked
Question

Anyone here got any experience of Grid.JS (a sortable Javascript grid) 1

Replies: 5

Views: 2K

Oct 4, 2024

Mike Lewis

Locked
Question

jquery function always returns contents of the same table cell, no matter which table cell i click

Replies: 0

Views: 751

Apr 20, 2023

coldbohemia

Locked
Question

Graph the selection of a html table row

Replies: 0

Views: 838

Jun 30, 2023

malpa

Locked
Question

Buttons not aligned after another button is clicked

Replies: 2

Views: 434

Jan 21, 2025

gmmastros

Share:

Facebook X (Twitter) Reddit Pinterest Tumblr WhatsApp Email Link

Part and Inventory Search

Sponsor

This site uses cookies to help personalise content, tailor your experience and to keep you logged in if you register.
By continuing to use this site, you are consenting to our use of cookies.

Accept Learn more…

Top