Need help with Stored Procedure Syntax

[Cenedra]

I've got this stored procedure, and I know it is wrong, but am not sure how to make it right.

CREATE PROCEDURE [dbo].[sp_CreateNewConnection]

(
@UserID int = NULL,
@FriendID varchar = NULL
)
AS
INSERT INTO CONNECTIONS (userid, friendid)
values (@UserID, (select id from users where username = @FriendUserName))

Can anyone show me how to do what I'm really trying to do here?

Much thanks
Cen

 

[Cenedra]

@FriendID should really be @FriendUserName in the variable declaration section, btw.

 

[swampBoogie]

CREATE PROCEDURE dbo.CreateNewConnection
(
    @UserID int = NULL,
    @FriendUserName varchar(30) = NULL
)
AS
    INSERT INTO CONNECTIONS (userid, friendid)
    select @UserID, id 
      from users 
     where username = @FriendUserName

You shouldn't name your procedures with the prefix sp_
Yuo must supply the maximum length for the varchar otherwise it defaults to 1