Need help on regular expressions in improving code

vpalag · Apr 28, 2002

Hi All,
I am a beginer to regular expressions.
My requirement is to change / with + for the urls in html.
I dont need to do this for http:// urls though.
I wrote a peice of code, but looked to me that there should
be more efficient way to do this....Please suggest me, I will be grateful. I 've to do the appending yet though

If my original html has:
<HTML>TEST <ahref="/planning/pandu/index.html">Planning</a><HTML>TEST <ahref="/Home/Bank/Aboutus.html">Aboutus</a>';

I need to change it as

<HTML>TEST /some/custom/appending?planning+pandu+index.html">Planning</a><HTML>TEST Home+Bank+Aboutus.html">Aboutus</a>

Thanks,

**************************************************

my $orightml = ' <HTML>TEST <ahref="/planning/pandu/index.html">Planning</a><HTML>TEST <ahref="/Home/Bank/Aboutus.html">Aboutus</a>';

$orightml =~ s/\/n//g;
my $origahref;
my $changedaref;
my $count;

my @list = split(/<ahref/,$orightml);
#print @list;

foreach(@list)
{

$count++;
if($count != 1)
{
$origahref = "<ahref".$_;
$origahref =~ m|(<ahref=&quot

(.*)(">)(.*)|;
$ahref_begin = $1;
$ahrefend = $3;
$restofit = $4;
$url = $2;
$url=~ s|/|+|g;
$url=~ s|\+?||;
$changedaref .= $ahrefbegin.$url.$ahrefend.$restofit;
}
else
{
$changedaref = $_;
}
}

print $changedaref;

*******************************************

markbanker · Apr 28, 2002

vpalag,

Here's a simple way to make the match and substitution:

$ahref ="/planning/pandu/index.html";
$match ="\/([a-z]*)\/([a-z]*)\/([a-z]*\.html)";

$ahref =~ s/$match/$1+$2+$3/;

print($ahref);

Does this fit your needs?

Mark Banker

vpalag · Apr 29, 2002

Hi Mark,

That works fine. Thanks for the short cut.
One thing is I might have many <a href>s in the html paragraph. I need them all of them to change in this fashion. As of now it does for only the first ahref.

Please let me know ,
Thanks again,
V

tsdragon · Apr 30, 2002

My preferred way of doing this may sound silly, but I think it's simpler and more robust. First I'd change any http:// to http:!! then I'd change all (remaining) / to + and then I change http:!! back to http://

The regular expressions involved in each case are MUCH simpler, so I suspect it might actually be faster.

Code:

$str =~ s[http://][http:!!]g;
$str =~ s[/][+]g;
$str =~ s[http:!!][http://]g;

Comments? Tracy Dryden
tracy@bydisn.com

http://www.bydisn.com

Meddle not in the affairs of dragons,
For you are crunchy, and good with mustard. [dragon]

MikeLacey · Apr 30, 2002

Yeah, I like that - I can read it. Mike
______________________________________________________________________
"Experience is the comb that Nature gives us after we are bald."

Is that a haiku?
I never could get the hang
of writing those things.

Tek-Tips is the largest IT community on the Internet today!

Members share and learn making Tek-Tips Forums the best source of peer-reviewed technical information on the Internet!

Need help on regular expressions in improving code

vpalag

Programmer

markbanker

Programmer

vpalag

Programmer

tsdragon

Programmer

MikeLacey

MIS

Similar threads

Part and Inventory Search

Sponsor