looping through selects

[tiamat2012]

Hey all,

I was wondering if there were any way to loop through selects? It looks really sloppy to write out 12 different assignments, here's my code:

					  		document.MyForm.pic1.options[i] = new Option(picarray[i], picarray[i]);
					  		document.MyForm.pic2.options[i] = new Option(picarray[i], picarray[i]);
					  		document.MyForm.pic3.options[i] = new Option(picarray[i], picarray[i]);
					  		document.MyForm.pic4.options[i] = new Option(picarray[i], picarray[i]);
					  		document.MyForm.pic5.options[i] = new Option(picarray[i], picarray[i]);
					  		document.MyForm.pic6.options[i] = new Option(picarray[i], picarray[i]);
					  		document.MyForm.pic7.options[i] = new Option(picarray[i], picarray[i]);
					  		document.MyForm.pic8.options[i] = new Option(picarray[i], picarray[i]);
					  		document.MyForm.pic9.options[i] = new Option(picarray[i], picarray[i]);
					  		document.MyForm.pic10.options[i] = new Option(picarray[i], picarray[i]);
					  		document.MyForm.pic11.options[i] = new Option(picarray[i], picarray[i]);
					  		document.MyForm.pic12.options[i] = new Option(picarray[i], picarray[i]);

I would like to do a loop through the pic1, pic2, etc. (which are <selects>)

anyone know how I could do that?

something like document.MyForm.select wouldn't work because I have many more selects than just these on the page, unless I were to find which number select it was.

Thank you,
-Kerry

 

[tsuji]

Like this.
[tt]
for (var i=1;i<=12;i++) {
document.MyForm.elements["pic"+i].options = new Option(picarray, picarray);
}
[/tt]

 

[tsuji]

Correction

My mixed up of indices. A re-take.
[tt]
//i given from another loop, for instance
for (var [red]j[/red]=1;[red]j[/red]<=12;[red]j[/red]++) {
document.MyForm.elements["pic"+[red]j[/red]].options = new Option(picarray, picarray);
}
[/tt]

 

[cLFlaVA]

here's another method, based on your code above:

var sColl = document.forms['myForm'].getElementsByTagName("select");

for ( var s = 0; s < sColl.length; s++ ) {
    sColl[s].options[i] = new Option( picarray[i], picarray[i] );
}

*cLFlaVA
----------------------------
[tt]( <P> <B>)¹³ * (<P> <.</B>)[/tt]

[URL unfurl="true"]http://www.coryarthus.com/[/url]

 

[tiamat2012]

Thank you!

tsuji I used your method, but tweaked it with the eval function. I did this

for(var j = 1; j <= 12; j++) {
rselobject[j] = "document.MyForm.pic" + j;			
}

then

for (var i = 0; i < piclength-1; i++) {
  for(var k = 1; k <=12; k++) {
    eval(rselobject[k]).options[i] = new Option(picarray[i], picarray[i]);
  }
}

I had to use the rselobject more than once which is why I set it as a variable.

and thank you cLFlaVA, only problem was I had about 20 other selects in my form that I didn't want to hit (which is why I didn't use that method).

Thank you,
Kerry

 

[cLFlaVA]

avoid using eval. it's antiquated, slow and should just plain not be used.



*cLFlaVA
----------------------------
[tt]( <P> <B>)¹³ * (<P> <.</B>)[/tt]

[URL unfurl="true"]http://www.coryarthus.com/[/url]

 

[tiamat2012]

This is an admin section of a website, speed is not required and runs perfectly fine for slow operations, but I'll definitely avoid it in the future

why should it just plain not be used? and is there another method?

-Kerry

 

[cLFlaVA]

of course, you can do this:

var e = document.forms['myForm'].elements;
for (var i = 0; i < piclength-1; i++) {
  for(var k = 1; k <=12; k++) {
    e['pic' + k].options[i] = new Option(picarray[i], picarray[i]);
  }
}

why should it just plain not be used?

didn't i give you three reasons above?

it's antiquated, slow and should just plain not be used.

*cLFlaVA
----------------------------
[tt]( <P> <B>)¹³ * (<P> <.</B>)[/tt]

[URL unfurl="true"]http://www.coryarthus.com/[/url]

 

[tiamat2012]

Ok cool, I'll try that.

If you say those are the three, then I queried the third... word for word.

and should "just plain not be used".
why should it "just plain not be used"?

Thanks,
Kerry