Loop for array

[buzzt]

I need a way to make a loop for the section in red below. I tried to write a loop, but it won't allow it. The $reqfiles is an array of 4 names ($reqfiles = array("1.php", "2.php", "3.php", "4.php") specified earlier in the code which I would like to add to in the future without having to add another of the lines in red each time.

Any ideas?

/////////////////////////////////////////////////////////////////////////////////////////////////////////////
function checkFileName($f) {
global $subdir, $thisfile, $hidedotfiles, $hidefilepattern, $trashcan, $trashcaninfofileext, $showimagesdir, $imagesdir, $readmefile, $loginfile, $logoutfile, $showreadmefile, $showloginfile, $showlogoutfile, $filealiases, $filealiasext,$reqfiles,$showreqfiles;

$f = basename($f);

return !( (($subdir == "&quot && (strtolower($f) == $thisfile))
|| (($subdir == "&quot && ($f == $trashcan))
|| (!$showimagesdir && ((($subdir == "&quot && ($f == $imagesdir)) || ($subdir == $imagesdir)))
|| ($hidedotfiles && ($f[0] == '.'))
|| (($hidefilepattern != "&quot && ereg($hidefilepattern, $f))
|| ($filealiases && ereg("^.*\.".strtolower($filealiasext)."$", strtolower($f)))
|| ($f == "..&quot
|| (!$showreadmefile && ($f == $readmefile)) // hides the readme file
|| (!$showloginfile && ($f == $loginfile)) // hides the login file
|| (!$showlogoutfile && ($f == $logoutfile)) // hides the logout file
|| (!$showreqfiles && ($f == $reqfiles[0]))
|| (!$showreqfiles && ($f == $reqfiles[1]))
|| (!$showreqfiles && ($f == $reqfiles[2]))
|| (!$showreqfiles && ($f == $reqfiles[3]))
|| (($subdir == $trashcan) && (($f == $readmefile) || ereg(".*\.".strtolower($trashcaninfofileext)."$", strtolower($f)))) );
}
////////////////////////////////////////////////////////////////////////////////////////////////////////

 

[skiflyer]

I'd do something like this, and then work this function into that statement...

function separateTest($f, $reqfiles) {
  foreach ($reqfiles as $file) {
    if ($f == $file) {
      ..
    } else {
      ..
    }
  }

  return whatever variable I set;
}

That is if I ever made such a crazy return statement that's how I would do it.

Personally I think the better way to do those kind of complex expressions is to write your boolean value to a variable, and then return that variable, that way if you need to break out one section like this it is trivial, rather than the situation you're in now.

-Rob

 

[sleipnir214]

I'd do something like this:

[tt]function checkFileName($f) {
global $subdir, $thisfile, $hidedotfiles, $hidefilepattern, $trashcan, $trashcaninfofileext, $showimagesdir, $imagesdir, $readmefile, $loginfile, $logoutfile, $showreadmefile, $showloginfile, $showlogoutfile, $filealiases, $filealiasext,$reqfiles,$showreqfiles;

$f = basename($f);

$return_value =
(($subdir == "&quot && (strtolower($f) == $thisfile))
|| (($subdir == "&quot && ($f == $trashcan))
|| (!$showimagesdir && ((($subdir == "&quot && ($f == $imagesdir)) || ($subdir == $imagesdir)))
|| ($hidedotfiles && ($f[0] == '.'))
|| (($hidefilepattern != "&quot && ereg($hidefilepattern, $f))
|| ($filealiases && ereg("^.*\.".strtolower($filealiasext)."$", strtolower($f)))
|| ($f == "..&quot
|| (!$showreadmefile && ($f == $readmefile)) // hides the readme file
|| (!$showloginfile && ($f == $loginfile)) // hides the login file
|| (!$showlogoutfile && ($f == $logoutfile)) // hides the logout file
|| (($subdir == $trashcan) && (($f == $readmefile) || ereg(".*\.".strtolower($trashcaninfofileext)."$", strtolower($f))));

foreach ($reqfiles as $filename)
{
$return_value |= (!$showreqfiles && ($f == $filename));
}

return !($return_value);
}[tt]


Want the best answers? Ask the best questions:

http://www.catb.org/~esr/faqs/smart-questions.html

TANSTAAFL!

 

[buzzt]

That works great! Thanks a bunch.