Tek-Tips is the largest IT community on the Internet today!

Members share and learn making Tek-Tips Forums the best source of peer-reviewed technical information on the Internet!

Register Log in
  • Congratulations Chriss Miller on being selected by the Tek-Tips community for having the most helpful posts in the forums last week. Way to Go!

How do i combine two scripts 1

Status
Not open for further replies.
DanClark86

DanClark86

MIS
Apr 11, 2003
105
US
I have a project where i have to print 30,000 indivdual files in 800 folders under a subfolder C:\00
How would i write a scrip to do this task or combine the follwing two scripts. The Top Script renames any file from *.1 to *.doc in any folder on a root, and the second scrip prints all of the files in a folder. If i could combine these two, it would server the purpuse

Code: 
And what about this ?
Set FSO = CreateObject("Scripting.FileSystemObject")
ShowSubfolders FSO.GetFolder("C:\work")

Sub ShowSubFolders(Folder)
For Each objFile In Folder.Files
    If Right(objFile.Name, 2) = ".1" Then
        objFile.Name = Left(objFile.Name, Len(objFile.Name)-1) & "doc"
    End If

Next
End Sub

Code: 
TargetFolder = "C:\00\" 
Set objShell = CreateObject("Shell.Application")
Set objFolder = objShell.Namespace(TargetFolder) 
Set colItems = objFolder.Items

For i = 0 to colItems.Count - 1
    colItems.Item(i).InvokeVerbEx("Print")
Next
 
Sort by date Sort by votes
Convert the 2nd script to a function or a sub with TargetFolder as argument.

Hope This Helps, PH.
Want to get great answers to your Tek-Tips questions? Have a look at FAQ219-2884 or FAQ222-2244
 
Upvote 0 Downvote
Hello DanClark86!

Try something like this..
Code: 
For Each objFile In Folder.Files
    If Right(objFile.Name, 2) = ".1" Then
        objFile.Name = Left(objFile.Name, Len(objFile.Name)-1) & "doc"
        objFile.InvokeVerbEx("Print")
    End If

Next
Good luck!

He who has knowledge spares his words, and a man of understanding is of a calm spirit. Even a fool is counted wise when he holds his peace; when he shuts his lips, he is considered perceptive. - King Solomon
 
Upvote 0 Downvote
I am still not too strong on scripting, i don't understand.
 
Upvote 0 Downvote
Wait, sorry, the script I suggested doesn't work. Go with PHV's suggestion. (I guess I should test my code before I post it huh :) ).

Thanks!

He who has knowledge spares his words, and a man of understanding is of a calm spirit. Even a fool is counted wise when he holds his peace; when he shuts his lips, he is considered perceptive. - King Solomon
 
Upvote 0 Downvote
snotmare, you confuse FileSystemObject and Shell.Application ...
 
Upvote 0 Downvote
Snotmare, Thanks for your help any sugestions are great at this time,

PHV, I dont know how to Convert the 2nd script to a function or a sub with TargetFolder as argument. Can you explain a little more?
 
Upvote 0 Downvote
PHV is suggesting something like this...
Code: 
Set FSO = CreateObject("Scripting.FileSystemObject")
ShowSubfolders FSO.GetFolder("C:\work")

Sub ShowSubFolders(Folder)
For Each objFile In Folder.Files
    If Right(objFile.Name, 2) = ".1" Then
        objFile.Name = Left(objFile.Name, Len(objFile.Name)-1) & "doc"
    End If

Next
Call subPrint(Folder)
End Sub 

Sub subPrint(TargetFolder)
   Set objShell = CreateObject("Shell.Application")
   Set objFolder = objShell.Namespace(TargetFolder) 
   Set colItems = objFolder.Items

   For i = 0 to colItems.Count - 1
      colItems.Item(i).InvokeVerbEx("Print")
   Next
End Sub

He who has knowledge spares his words, and a man of understanding is of a calm spirit. Even a fool is counted wise when he holds his peace; when he shuts his lips, he is considered perceptive. - King Solomon
 
Upvote 0 Downvote
So if i wanted to eliminate the renaming of the files then i could do something like this:

Code: 
Set FSO = CreateObject("Scripting.FileSystemObject")
ShowSubfolders FSO.GetFolder("C:\00")

Sub ShowSubFolders(Folder)
For Each objFile In Folder.Files
    
Next
Call subPrint(Folder)
End Sub 

Sub subPrint(TargetFolder)
   Set objShell = CreateObject("Shell.Application")
   Set objFolder = objShell.Namespace(TargetFolder) 
   Set colItems = objFolder.Items

   For i = 0 to colItems.Count - 1
      colItems.Item(i).InvokeVerbEx("Print")
   Next
End Sub
 
Upvote 0 Downvote
If you don't want to rename your files, then all you need is the second script that you provided in your first post. Keep in mind that this only prints out the files in your root folder. If you want to include all sub folders, then you'll need to do something like this...
Code: 
Set FSO = CreateObject("Scripting.FileSystemObject")
ShowSubfolders FSO.GetFolder("C:\00")

Sub ShowSubFolders(Folder)
   Call subPrint(Folder)
   For Each objFolder In Folder.SubFolders
      call ShowSubFolders(objFolderFolder)
   Next
End Sub 

Sub subPrint(TargetFolder)
   Set objShell = CreateObject("Shell.Application")
   Set objFolder = objShell.Namespace(TargetFolder) 
   Set colItems = objFolder.Items

   For i = 0 to colItems.Count - 1
      colItems.Item(i).InvokeVerbEx("Print")
   Next
End Sub

He who has knowledge spares his words, and a man of understanding is of a calm spirit. Even a fool is counted wise when he holds his peace; when he shuts his lips, he is considered perceptive. - King Solomon
 
Upvote 0 Downvote
When i run that script i get the following error:

WSH
Script: C:\...\file.vbs
line: 14
Char: 4
Error Object Required: 'objfolder'
Code: 80a01a8
source: Microsoft VBScript Runtime Error
 
Upvote 0 Downvote
I plaed the line
TargetFolder = "C:\00\"
in the script just before line 14 and then i get the error:

WSH
Script: C:\...\file.vbs
line: 6
Char: 4
Error Object Required: 'objfolder'
Code: 80a01a8
source: Microsoft VBScript Runtime Error
 
Upvote 0 Downvote
sorry scrath that last post. The error is

WSH
Script: C:\...\file.vbs
line: 6
Char: 4
Error Object Required: 'Folder'
Code: 80a01a8
source: Microsoft VBScript Runtime Error
 
Upvote 0 Downvote
The error might be caused by a type-o in the red line below...
Code: 
Set FSO = CreateObject("Scripting.FileSystemObject")
ShowSubfolders FSO.GetFolder("C:\00")

Sub ShowSubFolders(Folder)
   Call subPrint(Folder)
   For Each objFolder In Folder.SubFolders
      [red]call ShowSubFolders(objFolder)[/red]
   Next
End Sub 

Sub subPrint(TargetFolder)
   Set objShell = CreateObject("Shell.Application")
   Set objFolder = objShell.Namespace(TargetFolder) 
   Set colItems = objFolder.Items

   For i = 0 to colItems.Count - 1
      colItems.Item(i).InvokeVerbEx("Print")
   Next
End Sub

He who has knowledge spares his words, and a man of understanding is of a calm spirit. Even a fool is counted wise when he holds his peace; when he shuts his lips, he is considered perceptive. - King Solomon
 
Upvote 0 Downvote
i am still getting that error.
WSH
Script: C:\...\file.vbs
line: 6
Char: 4
Error Object Required: 'Folder'
Code: 80a01a8
source: Microsoft VBScript Runtime Error

Where dose the Folder object come from?
 
Upvote 0 Downvote
I got the code to work if I added a backslash in the red line...
Code: 
Set FSO = CreateObject("Scripting.FileSystemObject")
ShowSubfolders FSO.GetFolder("H:\Ferguson\HTML\Frames")

Sub ShowSubFolders(Folder)
   Call subPrint(Folder)
   For Each objFolder In Folder.SubFolders
      call ShowSubFolders(objFolder)
   Next
End Sub 

Sub subPrint(TargetFolder)
   Set objShell = CreateObject("Shell.Application")
   [red]Set objFolder = objShell.Namespace(TargetFolder & "\") [/red]
   Set colItems = objFolder.Items

   For i = 0 to colItems.Count - 1
      colItems.Item(i).InvokeVerbEx("Print")
   Next
End Sub

He who has knowledge spares his words, and a man of understanding is of a calm spirit. Even a fool is counted wise when he holds his peace; when he shuts his lips, he is considered perceptive. - King Solomon
 
Upvote 0 Downvote
It was PHV's idea, but thanks.

He who has knowledge spares his words, and a man of understanding is of a calm spirit. Even a fool is counted wise when he holds his peace; when he shuts his lips, he is considered perceptive. - King Solomon
 
Upvote 0 Downvote
Status
Not open for further replies.

Similar threads

wchull
  • Locked
  • Question
How do I resolve this permissions error in my script?
Replies
0
Views
429
wchull
wchull
stable-x
  • Locked
  • Question
How to set/define a variable from two variables?
Replies
3
Views
651
stable-x
stable-x
Alexvb6
  • Locked
  • Question
Deprecation of VBScript + Classic ASP: How to Ask Microsoft to cancel their planned craziness
Replies
0
Views
678
Alexvb6
Alexvb6
lunter
  • Locked
  • Question
How to create vbArray+vbByte (8209) in *.vbs stript
Replies
0
Views
413
lunter
lunter
EdScripts
  • Locked
  • Question
Using a Variable in the Run Method - I would sure like to be able to do this !
Replies
0
Views
310
EdScripts
EdScripts

Part and Inventory Search

Sponsor

Back
Top