Get data from a combo box via javascript 2

[dpk136]

i have a datagrid that i made in ASP, in each row there is a dropdown to change one of the fields, i have named it ShipMethod'i', where 'i' is the line number so the first one would be ShipMethod1. When i click on a link in that row, it passes the name ShipMethod1 and the FreightID. For some reason, it says that ShipMethod1 is undefined.

HEre is my code
getting passed in is
ShipDropDown = ShipMethod1
FreightReportID = 2809

function ConfirmShipMeth(ShipDropDown,FreightReportID) {
  var ShipMethod= document.forms['myForm'].elements[ShipDropDown].options[document.forms['myForm'].elements[ShipDropDown].selectedIndex].value;
  if (ShipMethod !== "") {
    if (confirm("Are you sure you would like to confirm this Shipment Method?") == 1) {
      window.location="ConfirmShipMeth.asp?ShipMethod=" + ShipMethod + "&FreightReportID=" + FreightReportID;
    }
  }
}

David Kuhn
------------------

http://www.davidpkuhn.com

 

[cLFlaVA]

please show how you're calling the function.



*cLFlaVA
----------------------------
[tt]"quote goes here"[/tt]
[URL unfurl="true"]http://www.coryarthus.com/[/url]

 

[dpk136]

holdThis = "ShipMethod" & i
Response.Write("<td><a href='javascript:ConfirmShipMeth(" & holdThis & "," & strFreightReportID & ")'>Confirm</a></td>")

David Kuhn
------------------

http://www.davidpkuhn.com

 

[cLFlaVA]

since this is a javascript forum, it really would be beneficial for us if you post the client-side code. in other words, the code as it appears in a view > source.

however, it seems you need single-quotes:

holdThis = "ShipMethod" & i
Response.Write("<td><a href='javascript:ConfirmShipMeth([red]'[/red]" & holdThis & "[red]'[/red]," & strFreightReportID & ")'>Confirm</a></td>")

*cLFlaVA
----------------------------
[tt]"quote goes here"[/tt]
[URL unfurl="true"]http://www.coryarthus.com/[/url]

 

[cLFlaVA]

actually, that'll cause an error. you need double-quotes. not sure how you do it in asp.



*cLFlaVA
----------------------------
[tt]"quote goes here"[/tt]
[URL unfurl="true"]http://www.coryarthus.com/[/url]

 

[cLFlaVA]

maybe it's two double-quotes next to eachother.



*cLFlaVA
----------------------------
[tt]"quote goes here"[/tt]
[URL unfurl="true"]http://www.coryarthus.com/[/url]

 

[kaht]

Depends on whether or not you're using JScript or VBScript. Since s/he's attempting concatenation with the ampersand:

holdThis = "ShipMethod" & i

it's reasonable to assume VBScript - in which case you would double up your quotes like cory suggested.

-kaht

http://www.silkypups.com

[small](All puppies have now found loving homes, thanks for all who showed interest)[/small]

 

[cLFlaVA]

that was a clear sw attempt.



*cLFlaVA
----------------------------
[tt]"quote goes here"[/tt]
[URL unfurl="true"]http://www.coryarthus.com/[/url]

 

[kaht]

actually not, I'm just really freakin bored

-kaht

http://www.silkypups.com

[small](All puppies have now found loving homes, thanks for all who showed interest)[/small]

 

[dpk136]

Why would i need double quotes...i'm passing in a variable of what the dropdown is called, not the value that is selected. that is what i want the javascript to do.

the ShipMethod1 goes in fine to the JavaScript, i have another script in which i do this for a textbox, and that works. i just don't know why it's not calling that element on the form.

David Kuhn
------------------

http://www.davidpkuhn.com

 

[tsuji]

[1] Main thing.

>Response.Write("<td><a href='javascript:ConfirmShipMeth(" & holdThis & "," & strFreightReportID & ")'>Confirm</a></td>")

[tt]Response.Write("<td><a href='javascript:ConfirmShipMeth([red]""[/red]" & holdThis & "[red]""[/red],[red]""[/red]" & strFreightReportID & "[red]""[/red])'>Confirm</a></td>")[/tt]

[2] Minor things

[2.1] "!==" is uncommon, though work. Orthodox form is "!=".

>if (ShipMethod !== "") {
Better this.
[tt]if (ShipMethod != "") {[/tt]

[2.2] true==1 works but very unorthodox, hence, confusing to reader/writer. true is represented as -1, but in this expression, curiously, it works. Better simply outright.

>if (confirm("Are you sure you would like to confirm this Shipment Method?") == 1) {
Better this.
[tt]if (confirm("Are you sure you would like to confirm this Shipment Method?")) {[/tt]

[2.3]

>var ShipMethod= document.forms['myForm'].elements[ShipDropDown].options[document.forms['myForm'].elements[ShipDropDown].selectedIndex].value;
Simply this.
[tt]var ShipMethod= document.forms['myForm'].elements[ShipDropDown].value;[/tt]

 

[dpk136]

A combo of point 1 and 2.3 made this work. i put both in and it worked. thanks for the help and tips on the other parts too.

David Kuhn
------------------

http://www.davidpkuhn.com