form submitting to self and not redirecting - unsure where to do redir

leeolive · Oct 29, 2003

Hi

I got this code from

http://www.asphonolulu.com/Samples/ASP/Forms/formvalidation.asp

I have stripped it down to the basics for example purposes.
At the moment, if user completes all required textboxes, it submits to itself. I need to set it so that if the form is completed properly, it sends all the values to validate page where I will set up my cnnection etc and submit to a db. Where am I going wrong and how can I get the form (after doing checks) to submit to another page?

Hm, not sure also what the DebugQS ia all about. Do I need to keep this in my code?

Much appreciated!
Lee

<%@ Language=VBScript %>
<% Response.Buffer = true %>

<%

Dim bError
Dim bIsSubmitted

bError = false

' IsSubmitted is hidden field in form
If Request.QueryString("IsSubmitted&quot

= "" Then
bIsSubmitted = false
Else
bIsSubmitted = true
End If
'Response.Write "bIsSubmitted: " & bIsSubmitted & "<br>"

Function EmailValidation(sFieldname, error)
If bIsSubmitted Then
Dim objRegExp
Set objRegExp = New regexp
objRegExp.Pattern = "^[a-zA-Z][\w\.-]*[a-zA-Z0-9]@[a-zA-Z][\w\.-]*[a-zA-Z0-9]\.[a-zA-Z][a-zA-Z\.]*[a-zA-Z]$"
If Not objRegExp.Test(Request.QueryString(sFieldname)) Then
EmailValidation = " <font color=""red"">""" & error & """</font>"
bError = true
Else
EmailValidation = ""

End If
End If
End Function

Function RequiredFieldValidation(sFieldname, error)
RequiredFieldValidation = ""
If bIsSubmitted Then
If Trim(Request.QueryString(sFieldname)) = "" Then
RequiredFieldValidation = " <font color=""red"">""" & error & """</font>"
bError = true
End If
End If
End Function

Sub DebugQS()
Response.Write "<b>ScriptName: " & ScriptName() & "</b><br>"
Response.Write "<b>QueryString Variables: </b><br>"
For i=1 to request.QueryString.count
response.write "  " & request.QueryString.key(i) & " = """ & request.QueryString.item(i) & """<br>"
If InStr(request.QueryString.item(i), ",&quot

> 0 Then
For Each item in request.QueryString.item(i)
Response.Write "    " & request.QueryString.key(i) & " = """ & item & """<BR>"
Next
End If
Next
End Sub

Function ScriptName()
ScriptName = Right(Request.ServerVariables("SCRIPT_NAME&quot

, Len(Request.ServerVariables("SCRIPT_NAME&quot

) - InStrRev(Request.ServerVariables("SCRIPT_NAME&quot

, "/&quot

)
End Function

Sub DisplayForm()
%>

<form method="GET">
<input type="hidden" name="IsSubmitted" value="Yes">

<table class="insettabletop" width="480" align="center" border="0" cellspacing="4" cellpadding="4">
<tr>
<td align="left">First Name(s) in full</td>
<td align="left" width="5">   </td>
<td align="left"><input type="text" name="FirstName" class="inputpension" value="<%=Request.QueryString("FirstName&quot

%>" /><img src="images/required_image.gif" width="10" height="9" alt="Expat Financial" />
<%=RequiredFieldValidation("FirstName", "*&quot

%>
</td>
</tr>
</table>

</form>
<%
DebugQS
End Sub
%>

<HTML>
<HEAD>
<META NAME="GENERATOR" Content="Microsoft Visual Studio 6.0">
<title>Form Validation Test</title>
</HEAD>

<BODY>
<h3>Form Validation Test</h3>
<%
If Not bIsSubmitted Then
DisplayForm
Else
DisplayForm
Response.Write "<br><a href=""javascript:void(location.replace('formtest.asp'));""><font color=""blue"">Start Again</font></a>"

If Not bError Then
' Clear headers and start over
Response.Clear
%>
<HTML>
<HEAD>
<META NAME="GENERATOR" Content="Microsoft Visual Studio 6.0">
<title>Form Validation Test</title>
</HEAD>
<BODY>
<h3>Form Validation Test</h3>
<%
DebugQS

' Update the DB
Response.Write "Updating the DB...<br>"
' Report errors (or crash)

' Close or whatever button(link)
Response.Write "<br><a href=""javascript:void(location.replace('formtest.asp'));""><font color=""blue"">Start Again</font></a>"
End If
End If
%>

</BODY>
</HTML>

j0em0mma · Oct 29, 2003

<form action="ValidationScript.asp">

also, use method="POST" unless you want to have the value pairs show up in the address.

if you use "POST" you can get the form variables from the response collection.

j0em0mma · Oct 29, 2003

Oops, the Forms collection, not the response collection.

i.e. variable = request("form field&quot

leeolive · Oct 30, 2003

Thanks for getting back!
If i put the form action in then it just redirects to that page immediately without performing the validation. How do I get it to do the validation first and then if it is succesful redirect to that page?

Also, I really don't understand what is happening with this part of the code below. Somewhere here it is redirecting to itself and printing out all the values, which is fine for testing but I don't want that to happen now. I can't figure out whether it's happening in the DebugQS part or where...

<BODY>
<h3>Form Validation Test</h3>
<%
If Not bIsSubmitted Then
DisplayForm
Else
DisplayForm
Response.Write "<br><a href=""javascript:void(location.replace('formtest.asp'));""><font color=""blue"">Start Again</font></a>"

If Not bError Then
' Clear headers and start over
Response.Clear
%>
<HTML>
<HEAD>
<META NAME="GENERATOR" Content="Microsoft Visual Studio 6.0">
<title>Form Validation Test</title>
</HEAD>
<BODY>
<h3>Form Validation Test</h3>
<%
DebugQS

' Update the DB
Response.Write "Updating the DB...<br>"
' Report errors (or crash)

' Close or whatever button(link)
Response.Write "<br><a href=""javascript:void(location.replace('formtest.asp'));""><font color=""blue"">Start Again</font></a>"
End If
End If
%>

</BODY>
</HTML>

j0em0mma · Oct 30, 2003

DebugQS is taking the query string and dumping out a list of all the key/value pairs. You don't need it unless you are having trouble with expected values, and you need to see what they're doing. This script is designed to use QueryStrings, not the forms collection, so my advice to use "POST" won't work unless you change lines like this:

Request.QueryString("IsSubmitted&quot

to this:

Request("IsSubmitted&quot

There are a couple of ways to do what you want. I prefer to use javascript for validation, and use javascript to submit the form based upon success or failure of the javascript validation function. The advantage of using javascript to validate and submit is that if the validation fails, the page doesn't go anywhere. You can set focus on the first failing field, etc...

the line in javascript that does the form submit (after validation) looks like this:

window.YourForm.submit();

There's no need to send this to another script if you don't want to. If you do want it to post to a new script, add the "action=" line shown in earlier post to do this.

Alternatively, you can leave out action, and the script will send the form back to itself. Then you need the following line to launch a new page:

Response.Redirect("/webroot/Database script.asp?Extras&quot

where extras are ALL of the form values you have collected in the following format:

formvariable1=Value1&formvariable2=Value2, etc...

This can get complex, and will run into the limitations on length of query string, which is why using POST form variables is much more desirable than using Request.QueryString to handle moving data around. Additionally, all fields are visible to the use when using QueryStrings, including hidden fields, passwords, etc...

QueryStrings are fine for setting non-vital or hackable pagestates, but not suited for sensitive data.

If you don't use javascript to validate the form, or the same script to do validation and db access, I don't know of a way to send the data to antoher script without using the QueryString method, except for using Session variables to store the data. You would write and refer to these in the following way:

Write to:
Session("SessionValue1&quot

= FormVariable1

Read:
NewScriptVariable1 = Session("SessionValue1&quot

Sessions use cookies, with their associated problems (Cookies turned off, partial blocking, etc...) so this is also not generally condiered an advisable method of moving data around.

You're best off using either the javascript validation method, or the same vbscript validation and datawriting method.

Tek-Tips is the largest IT community on the Internet today!

Members share and learn making Tek-Tips Forums the best source of peer-reviewed technical information on the Internet!

form submitting to self and not redirecting - unsure where to do redir

leeolive

Programmer

j0em0mma

Programmer

j0em0mma

Programmer

leeolive

Programmer

j0em0mma

Programmer

Similar threads

Part and Inventory Search

Sponsor