error in script

[murphyg]

Hello all,

Could somone help me with this search script please, it fails on the fuction, but haven't a clue why any help would be appriciated

~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Option Explicit

Dim ObjFSO
Dim ObjStartDrive
Dim ObjFolder
Dim Folder
Dim ObjFile

Set ObjFSO = CreateObject("Scripting.FileSystemObject")
Set ObjStartDrive = ObjFSO.GetFolder("c:\")

For Each ObjFolder In ObjStartDrive.SubFolders
FindFiles(Folder)

Function FindFiles(Folder)

Set Folder = ObjFSO.GetFolder(Folder)
For Each ObjFile In Folder.Files
If InStr(1, ObjFile.Name, ".zip", 1) Then
WScript.Echo ObjFile.Path
Wscript.Echo ObjFile.DateCreated
Else
End If
Next

If Folder.SubFolders.Count > 0 Then
For Each Folder In Folder.SubFolders
FindFiles(Folder.Path)
Next
End If

End Function

 

[FesterSXS]

why is the function within your For...Next loop? Take it out of the loop for starters.

If you still have problems then let us know - and please tell us the error you are getting too.


Tony

Spirax-Sarco - steam traps control valves heat exchangers
Sun Villa - Luxury Florida accommodation

 

[murphyg]

sorry forgot to mention the error
(15, 1) Microsoft VBScript compilation error: Syntax error

 

[tsuji]

>it fails on the fuction, but haven't a clue why...
You have practically mistakes in concept every three lines.
[1] Missing next for for-loop.
[2] Mistaken object and default string property of folder.
[3] Wrong method of calling function without return.
[4] Repeated folder variable for different thing.
[5] Liberal use/abuse of global scope.

Do a search for a better examples. To salvage your lines, this is how it is done and you may see more clear your mistakes or better practice.
[tt]
Option Explicit

Dim ObjFSO
Dim ObjStartDrive
Dim ObjFolder
[red]'[/red]Dim Folder
[red]'[/red]Dim ObjFile

Set ObjFSO = CreateObject("Scripting.FileSystemObject")
Set ObjStartDrive = ObjFSO.GetFolder("c:\")

For Each ObjFolder In ObjStartDrive.SubFolders
[red]call[/red] FindFiles([red]obj[/red]Folder[red].path[/red])
[red]Next[/red]

Function FindFiles([blue]s[/blue]Folder)

[blue]dim Folder,objFolder,objFile[/blue]
Set Folder = ObjFSO.GetFolder([red]s[/red]Folder)
For Each ObjFile In Folder.Files
If InStr(1, ObjFile.Name, ".zip", 1) Then
WScript.Echo ObjFile.Path
Wscript.Echo ObjFile.DateCreated
Else
End If
Next

If Folder.SubFolders.Count > 0 Then
For Each [blue]obj[/blue]Folder In Folder.SubFolders
[red]call[/red] FindFiles([blue]obj[/blue]Folder.Path)
Next
End If

End Function
[/tt]