display related table info also

frogjumps · Mar 18, 2002

I have 2 tables in Access, 1 customers, 1 notes. these are related by customer can have many notes.

I cannot get the notes to display for each customer. It displays ALL notes for ALL customers, instaed of just the notes for displayed customer.

here's the code:

<%@LANGUAGE="VBSCRIPT"%>

<%
set rsCust = Server.CreateObject("ADODB.Recordset&quot

rsCust.ActiveConnection = MM_cnDH_STRING
rsCust.Source = "SELECT Customers.CustID, Customers.CompanyName, Customers.ContactFirstName, Customers.ContactLastName, Customers.Address, Customers.Address2, Customers.Address3, Customers.City, Customers.State, Customers.ZipCode, Customers.PhoneNumber, Customers.FaxNumber, Customers.AltPhone, Notes.TaskID, Notes.nCustID, Notes.Employee, Notes.Time, Notes.Date, Notes.Notes FROM Customers LEFT OUTER JOIN Notes ON (Notes.nCustID = Customers.CustID)"
rsCust.CursorType = 0
rsCust.CursorLocation = 2
rsCust.LockType = 3
rsCust.Open()
rsCust_numRows = 0
%>
<%
Dim Repeat1__numRows
Repeat1__numRows = 1
Dim Repeat1__index
Repeat1__index = 0
rsCust_numRows = rsCust_numRows + Repeat1__numRows
%>
<%
' *** Recordset Stats, Move To Record, and Go To Record: declare stats variables

' set the record count
rsCust_total = rsCust.RecordCount

' set the number of rows displayed on this page
If (rsCust_numRows < 0) Then
rsCust_numRows = rsCust_total
Elseif (rsCust_numRows = 0) Then
rsCust_numRows = 1
End If

' set the first and last displayed record
rsCust_first = 1
rsCust_last = rsCust_first + rsCust_numRows - 1

' if we have the correct record count, check the other stats
If (rsCust_total <> -1) Then
If (rsCust_first > rsCust_total) Then rsCust_first = rsCust_total
If (rsCust_last > rsCust_total) Then rsCust_last = rsCust_total
If (rsCust_numRows > rsCust_total) Then rsCust_numRows = rsCust_total
End If
%>
<%
' *** Move To Record and Go To Record: declare variables

Set MM_rs = rsCust
MM_rsCount = rsCust_total
MM_size = rsCust_numRows
MM_uniqueCol = ""
MM_paramName = ""
MM_offset = 0
MM_atTotal = false
MM_paramIsDefined = false
If (MM_paramName <> "&quot

Then
MM_paramIsDefined = (Request.QueryString(MM_paramName) <> "&quot

End If
%>
<%
' *** Move To Record: handle 'index' or 'offset' parameter

if (Not MM_paramIsDefined And MM_rsCount <> 0) then

' use index parameter if defined, otherwise use offset parameter
r = Request.QueryString("index&quot

If r = "" Then r = Request.QueryString("offset&quot

If r <> "" Then MM_offset = Int(r)

' if we have a record count, check if we are past the end of the recordset
If (MM_rsCount <> -1) Then
If (MM_offset >= MM_rsCount Or MM_offset = -1) Then ' past end or move last
If ((MM_rsCount Mod MM_size) > 0) Then ' last page not a full repeat region
MM_offset = MM_rsCount - (MM_rsCount Mod MM_size)
Else
MM_offset = MM_rsCount - MM_size
End If
End If
End If

' move the cursor to the selected record
i = 0
While ((Not MM_rs.EOF) And (i < MM_offset Or MM_offset = -1))
MM_rs.MoveNext
i = i + 1
Wend
If (MM_rs.EOF) Then MM_offset = i ' set MM_offset to the last possible record

End If
%>
<%
' *** Move To Record: if we dont know the record count, check the display range

If (MM_rsCount = -1) Then

' walk to the end of the display range for this page
i = MM_offset
While (Not MM_rs.EOF And (MM_size < 0 Or i < MM_offset + MM_size))
MM_rs.MoveNext
i = i + 1
Wend

' if we walked off the end of the recordset, set MM_rsCount and MM_size
If (MM_rs.EOF) Then
MM_rsCount = i
If (MM_size < 0 Or MM_size > MM_rsCount) Then MM_size = MM_rsCount
End If

' if we walked off the end, set the offset based on page size
If (MM_rs.EOF And Not MM_paramIsDefined) Then
If (MM_offset > MM_rsCount - MM_size Or MM_offset = -1) Then
If ((MM_rsCount Mod MM_size) > 0) Then
MM_offset = MM_rsCount - (MM_rsCount Mod MM_size)
Else
MM_offset = MM_rsCount - MM_size
End If
End If
End If

' reset the cursor to the beginning
If (MM_rs.CursorType > 0) Then
MM_rs.MoveFirst
Else
MM_rs.Requery
End If

' move the cursor to the selected record
i = 0
While (Not MM_rs.EOF And i < MM_offset)
MM_rs.MoveNext
i = i + 1
Wend
End If
%>
<%
' *** Move To Record: update recordset stats

' set the first and last displayed record
rsCust_first = MM_offset + 1
rsCust_last = MM_offset + MM_size
If (MM_rsCount <> -1) Then
If (rsCust_first > MM_rsCount) Then rsCust_first = MM_rsCount
If (rsCust_last > MM_rsCount) Then rsCust_last = MM_rsCount
End If

' set the boolean used by hide region to check if we are on the last record
MM_atTotal = (MM_rsCount <> -1 And MM_offset + MM_size >= MM_rsCount)
%>
<%
' *** Go To Record and Move To Record: create strings for maintaining URL and Form parameters

' create the list of parameters which should not be maintained
MM_removeList = "&index="
If (MM_paramName <> "&quot

Then MM_removeList = MM_removeList & "&" & MM_paramName & "="
MM_keepURL="":MM_keepForm="":MM_keepBoth="":MM_keepNone=""

' add the URL parameters to the MM_keepURL string
For Each Item In Request.QueryString
NextItem = "&" & Item & "="
If (InStr(1,MM_removeList,NextItem,1) = 0) Then
MM_keepURL = MM_keepURL & NextItem & Server.URLencode(Request.QueryString(Item))
End If
Next

' add the Form variables to the MM_keepForm string
For Each Item In Request.Form
NextItem = "&" & Item & "="
If (InStr(1,MM_removeList,NextItem,1) = 0) Then
MM_keepForm = MM_keepForm & NextItem & Server.URLencode(Request.Form(Item))
End If
Next

' create the Form + URL string and remove the intial '&' from each of the strings
MM_keepBoth = MM_keepURL & MM_keepForm
if (MM_keepBoth <> "&quot

Then MM_keepBoth = Right(MM_keepBoth, Len(MM_keepBoth) - 1)
if (MM_keepURL <> "&quot

Then MM_keepURL = Right(MM_keepURL, Len(MM_keepURL) - 1)
if (MM_keepForm <> "&quot

Then MM_keepForm = Right(MM_keepForm, Len(MM_keepForm) - 1)

' a utility function used for adding additional parameters to these strings
Function MM_joinChar(firstItem)
If (firstItem <> "&quot

Then
MM_joinChar = "&"
Else
MM_joinChar = ""
End If
End Function
%>
<%
' *** Move To Record: set the strings for the first, last, next, and previous links

MM_keepMove = MM_keepBoth
MM_moveParam = "index"

' if the page has a repeated region, remove 'offset' from the maintained parameters
If (MM_size > 0) Then
MM_moveParam = "offset"
If (MM_keepMove <> "&quot

Then
params = Split(MM_keepMove, "&&quot

MM_keepMove = ""
For i = 0 To UBound(params)
nextItem = Left(params(i), InStr(params(i),"=&quot

- 1)
If (StrComp(nextItem,MM_moveParam,1) <> 0) Then
MM_keepMove = MM_keepMove & "&" & params(i)
End If
Next
If (MM_keepMove <> "&quot

Then
MM_keepMove = Right(MM_keepMove, Len(MM_keepMove) - 1)
End If
End If
End If

' set the strings for the move to links
If (MM_keepMove <> "&quot

Then MM_keepMove = MM_keepMove & "&"
urlStr = Request.ServerVariables("URL&quot

& "?" & MM_keepMove & MM_moveParam & "="
MM_moveFirst = urlStr & "0"
MM_moveLast = urlStr & "-1"
MM_moveNext = urlStr & Cstr(MM_offset + MM_size)
prev = MM_offset - MM_size
If (prev < 0) Then prev = 0
MM_movePrev = urlStr & Cstr(prev)
%>
<html>
<head>
<title>The Direct Hit</title>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
<script language="JavaScript">
<!--
function GP_AdvOpenWindow(theURL,winName,features,popWidth,popHeight,winAlign,ignorelink,alwaysOnTop,autoCloseTime,borderless) { //v2.0
var leftPos=0,topPos=0,autoCloseTimeoutHandle, ontopIntervalHandle, w = 480, h = 340;
if (popWidth > 0) features += (features.length > 0 ? ',' : '') + 'width=' + popWidth;
if (popHeight > 0) features += (features.length > 0 ? ',' : '') + 'height=' + popHeight;
if (winAlign && winAlign != "" && popWidth > 0 && popHeight > 0) {
if (document.all || document.layers || document.getElementById) {w = screen.availWidth; h = screen.availHeight;}
if (winAlign.indexOf("center&quot

!= -1) {topPos = (h-popHeight)/2;leftPos = (w-popWidth)/2;}
if (winAlign.indexOf("bottom&quot

!= -1) topPos = h-popHeight; if (winAlign.indexOf("right&quot

!= -1) leftPos = w-popWidth;
if (winAlign.indexOf("left&quot

!= -1) leftPos = 0; if (winAlign.indexOf("top&quot

!= -1) topPos = 0;
features += (features.length > 0 ? ',' : '') + 'top=' + topPos+',left='+leftPos;}
if (document.all && borderless && borderless != "" && features.indexOf("fullscreen&quot

!= -1) features+=",fullscreen=1";
if (window["popupWindow"] == null) window["popupWindow"] = new Array();
var wp = popupWindow.length;
popupWindow[wp] = window.open(theURL,winName,features);
if (popupWindow[wp].opener == null) popupWindow[wp].opener = self;
if (document.all || document.layers || document.getElementById) {
if (borderless && borderless != "&quot

{popupWindow[wp].resizeTo(popWidth,popHeight); popupWindow[wp].moveTo(leftPos, topPos);}
if (alwaysOnTop && alwaysOnTop != "&quot

{
ontopIntervalHandle = popupWindow[wp].setInterval("window.focus();", 50);
popupWindow[wp].document.body.onload = function() {window.setInterval("window.focus();", 50);}; }
if (autoCloseTime && autoCloseTime > 0) {
popupWindow[wp].document.body.onbeforeunload = function() {
if (autoCloseTimeoutHandle) window.clearInterval(autoCloseTimeoutHandle);
window.onbeforeunload = null; }
autoCloseTimeoutHandle = window.setTimeout("popupWindow["+wp+"].close()", autoCloseTime * 1000); }
window.onbeforeunload = function() {for (var i=0;i<popupWindow.length;i++) popupWindow.close();}; }
document.MM_returnValue = (ignorelink && ignorelink != "&quot ? false : true;
}
//-->
</script>
</head>
<body text="#000000" link="#0000FF" vlink="#FF0000" alink="#FFFF00" bgcolor="#FFFFFF">
 
 
 <A HREF="<%=MM_moveFirst%>">First</A>
| <A HREF="<%=MM_moveNext%>">Next</A>
| <A HREF="<%=MM_movePrev%>">Previous</A>
| <A HREF="<%=MM_moveLast%>">Last</A> 

<form name="Form1" action="/modify.asp" method="POST">
<A HREF="/modify.asp?<%= MM_keepURL & MM_joinChar(MM_keepURL) & "CustID=" & rsCust.Fields.Item("CustID&quot.Value %>">Modify
Record</A> | <A HREF="/insert.asp?<%= MM_keepURL & MM_joinChar(MM_keepURL) & "CustID=" & rsCust.Fields.Item("CustID&quot.Value %>">Insert
New Record</A> | <A HREF="/delete.asp?<%= MM_keepURL & MM_joinChar(MM_keepURL) & "CustID=" & rsCust.Fields.Item("CustID&quot.Value %>">Delete
Current Record</A> | Schedule Call | Invoice | 
 
 
<table border="0" width="797">
<tr>
<td align="right" width="113">
<div align="left">Customer
#</div>
</td>
<td colspan="2"><%=(rsCust.Fields.Item("CustID&quot.Value)%></td>
<td width="99">Address</td>
<td width="356"><%=(rsCust.Fields.Item("Address&quot.Value)%></td>
</tr>
<tr>
<td align="right" width="113">
<div align="left">Customer's
Name</div>
</td>
<td colspan="2"><%=(rsCust.Fields.Item("CompanyName&quot.Value)%></td>
<td width="99">Address line
2</td>
<td width="356"><%=(rsCust.Fields.Item("Address2&quot.Value)%></td>
</tr>
<tr>
<td align="right" width="113">
<div align="left">Contact</div>
</td>
<td colspan="2"><%=(rsCust.Fields.Item("ContactFirstName&quot.Value)%><%=(rsCust.Fields.Item("ContactLastName&quot.Value)%></td>
<td width="99">Address line
3</td>
<td width="356"><%=(rsCust.Fields.Item("Address3&quot.Value)%></td>
</tr>
<tr>
<td align="right" width="113">
<div align="left">Alternate
Contact</div>
</td>
<td colspan="2"></td>
<td width="99">City</td>
<td width="356"><%=(rsCust.Fields.Item("City&quot.Value)%></td>
</tr>
<tr>
<td align="right" width="113">
<div align="left">Phone
#</div>
</td>
<td colspan="2"> <%=(rsCust.Fields.Item("PhoneNumber&quot.Value)%></td>
<td width="99">State</td>
<td width="356"><%=(rsCust.Fields.Item("State&quot.Value)%></td>
</tr>
<tr>
<td align="right" width="113">
<div align="left">Alternate
Phone #</div>
</td>
<td colspan="2"> <%=(rsCust.Fields.Item("AltPhone&quot.Value)%></td>
<td width="99">Zip Code</td>
<td width="356"><%=(rsCust.Fields.Item("ZipCode&quot.Value)%></td>
</tr>
<tr>
<td align="right" width="113">
<div align="left">Fax #</div>
</td>
<td colspan="2"> <%=(rsCust.Fields.Item("FaxNumber&quot.Value)%></td>
<td width="99">eMail</td>
<td width="356"></td>
</tr>
</table>
 
 | ','InsertNote','fullscreen=no,toolbar=no,location=no,status=no,menubar=yes,scrollbars=no,resizable=yes',400,300,'center','','',0,'');return document.MM_returnValue">Insert
Note | Activities | Quote | Invoice |
</form>
 Account History
 

<table width="73%" border="0">
<tr bgcolor="#66CCFF">
<td width="10%">Date</td>
<td width="10%">Time</td>
<td width="52%">Notes</td>
<td width="14%">Salesman</td>
</tr>
<%
While ((Repeat1__numRows <> 0) AND (NOT rsCust.EOF))
%>
<%If (Repeat1__numRows Mod 2) Then%>
<tr bgcolor="#CCCCCC">
<%Else%>
<tr bgcolor="#FFFFFF">
<%End If%>
<td width="10%"><%=(rsCust.Fields.Item("Date&quot.Value)%></td>
<td width="10%"><%=(rsCust.Fields.Item("Time&quot.Value)%></td>
<td width="52%"><%=(rsCust.Fields.Item("Notes&quot.Value)%></td>
<td width="14%"><%=(rsCust.Fields.Item("Employee&quot.Value)%></td>
</tr>
<%
Repeat1__index=Repeat1__index+1
Repeat1__numRows=Repeat1__numRows-1
rsCust.MoveNext()
Wend
%>
</table>
</body>
</html>
<%
rsCust.Close()
%>
FrOg 8)

derren · Mar 18, 2002

Hi

I know we normally ask for more code from people but ...

Look, you are establishing a relationship between your two tables with your JOIN, but you are not then filtering the data. You need to add a "WHERE customers.custID=" clause to filter your recordset.

Also, with your join, try

Code:

FROM Customers LEFT JOIN Notes ON (Customers.nCustID = Notes.CustID)

The order that the relationship is specified can be cruicial. Derren
[The only person in the world to like Word]

frogjumps · Mar 18, 2002

as far as filtering the rs notes, how would I do this...

as for the WHERE clause, I need to return ALL records and the associated Notes related to these records (if any).

Why should I use the Left Join, instead of the Left Outer Join?

FrOg 8)

derren · Mar 18, 2002

If you are not after all notes and just require the notes relating to one specific customer you need to "filter" the records. Sorry about that, but this is just a term used for only showing the records you require. To do this you just need to use the WHERE clause of the SQL. This is in addition to the join which you have already set up which will return every related record.

As far as your join goes, your join may still work, try the where clause first

You just need to change your SQL to

Code:

FROM Customers LEFT OUTER JOIN Notes ON (Notes.nCustID = Customers.CustID) WHERE customers.custid=&quot; & valueof customeridyouwant&quot;
 Derren
[The only person in the world to like Word]

frogjumps · Mar 18, 2002

this :

WHERE customers.custid=" & valueof customeridyouwant"

How could I change this to the currently displayed record? or the current rs returned CustID value?

FrOg 8)

Tek-Tips is the largest IT community on the Internet today!

Members share and learn making Tek-Tips Forums the best source of peer-reviewed technical information on the Internet!

display related table info also

frogjumps

IS-IT--Management

derren

Programmer

frogjumps

IS-IT--Management

derren

Programmer

frogjumps

IS-IT--Management

Similar threads

Part and Inventory Search

Sponsor