constructive criticism wanted please.

[unborn]

well i have my news script finally finished and seeing ive only read 3 chapters in the book i think i did pretty good. but i would love it if one/some of you php pro's would look over my code and tell me some things that i shouldnt do anymore or maybe suggest a better way.. i just got started in this language and want to know what habbits to squash asap and maybe what habbits i should keep. i tried maken the script easier for other people because i have a few people who want the script so i put the variables up top so i can basically give them the script and then they can handle the rest just from the top.

thanks for those of you who do it.

view post script:

http://error-prone.org/distorted/news/news.phps

post / edit / delete script:

http://error-prone.org/distorted/news/editnews.phps

thanks again.

in the begining man created code.
in the end code will create man.
clones are coming only matter of time.
examples?

http://planetsourcecode.com

 

[unborn]

btw i wrote the code in dreamweavers pad so the indents and formating looked alot nicer there... sorry it isnt as clean as in dreamweaver.

in the begining man created code.
in the end code will create man.
clones are coming only matter of time.
examples?

http://planetsourcecode.com

 

[gizmicek]

I see that you have learned a good thing by commenting the code . Thats very good habbit especially when you need to modify the code about half year after you created it. I'm creating pages for the game development team where I'm the game engine programmer and it has about 1000 lines of code at the moment (all functionality is on one page using modules) so it is sometimes a little confusing (especialy the areas of code which aren't commented). Unfortunately you won't be able to see the pages since it is on Czech free webhosting server which is probably behind some firewall.

The best thing you can do is to tell some people to use your scripts and they will tell you any bugs they will encounter. So do it I ;-)

 

[unborn]

hehe thanks, yeah ive programed in visual basic for a while and well i lost 5 yrs worth of source codes and work and the bas file i made with massive function i used alot.. -sigh so i decided im done with vb ill learn php then maybe c/c++ sence they are alike i heard. commenting is always a good idea hehe .. thanks for commenting back

in the begining man created code.
in the end code will create man.
clones are coming only matter of time.
examples?

http://planetsourcecode.com