Checking for file

Mute101 · Oct 1, 2001

Hi peeps,

I am running a web application which I can track orders from a unique order number, I am trying to stop my application from adding one to the order no when it has already done it once. (ie I dont want the orderno to go up if a user hits the refresh button). The code generates a .dat file holding all the order info so I check to see if the file is created.

This is the code I am using but it doesn't work!!!

It does seem to function to a degree but it is very unstable. Any ideas?

#Get OrderNo for filename
open(INFILE,"$ENV{'DOCUMENT_ROOT'}/compaq/orderno.dat&quot

or die "Can not open KPorderNo data file";
$orderno = <INFILE>;
close(INFILE);

#Check for data file
$file = "$ENV{'DOCUMENT_ROOT'}/compaq/orders/$orderno.dat";

unless(-e $file)
{
#Move order number on
open(INFILE,">$ENV{'DOCUMENT_ROOT'}/compaq/orderno.dat&quot

or die "Can not open KPorderNo data file";
$neword = sprintf("%06d",$orderno+1);
print INFILE "$neword";
close(INFILE);
}

stakadush · Oct 1, 2001

you also need to create the file itself, no?

open(INFILE,">$ENV{'DOCUMENT_ROOT'}/compaq/$orderno.dat&quot

or die "Can not create order file";
close(INFILE);

Mute101 · Oct 1, 2001

Sorry I just posted a fragment of code showing the check for file section, the file itself is created after this code is run therefore the first time it runs it won' tfind the file but every time after it will and will skip the orderno+1 bit

Mute101 · Oct 1, 2001

Full RELEVANT code

sub Load()
{
#Get OrderNo for filename
open(INFILE,"$ENV{'DOCUMENT_ROOT'}/compaq/orderno.dat&quot

or die "Can not open KPorderNo data file";
$orderno = <INFILE>;
close(INFILE);

#Check for data file
$file = "$ENV{'DOCUMENT_ROOT'}/compaq/orders/$orderno.dat";

unless(-e $file)
{
#Move order number on
open(INFILE,">$ENV{'DOCUMENT_ROOT'}/compaq/orderno.dat&quot

or die "Can not open KPorderNo data file";
$neword = sprintf("%06d",$orderno+1);
print INFILE "$neword";
close(INFILE);
}

#check referer
$refer = $query->param("From&quot

;
if ($refer eq "recert&quot

{
$Prodtemplate = "$ENV{'DOCUMENT_ROOT'}/compaq/products/products.data";
}
elsif ($refer eq "ilp&quot

{
$Prodtemplate = "$ENV{'DOCUMENT_ROOT'}/compaq/products/ilp.data";
}
else
{
#redirect????
die "Where the hell did you come from???"
}

open(PROD,"$Prodtemplate&quot

or die "Can not open products file";
$a = 1;
while ($line = <PROD>)
{
($prodcode[$a], $prodname[$a], $webcode[$a]) = split /;/, $line;
$a++
};
close(PROD);

open(PRICE,"$ENV{'DOCUMENT_ROOT'}/compaq/kpplfcr/plrc.dat&quot

or die "Can not open recert price file";
$p = 1;
while ($line = <PRICE>)
{
($accno[$p], $pricel[$p], $pricem[$p], $priceh[$p]) = split /;/, $line;
$p++
};
close(PRICE);

open(ILPPRICE,"$ENV{'DOCUMENT_ROOT'}/compaq/kpplfcr/ilppl.dat&quot

or die "Can not open ilp price file";
$q = 1;
while ($line = <ILPPRICE>)
{
($accno[$q], $price[$q]) = split /;/, $line;
$q++
};
close(ILPPRICE);
};

****************
Calc sub HIDDEN STUFF

open(DATFILE,">$ENV{'DOCUMENT_ROOT'}/compaq/orders/$orderno.dat&quot

or die "Can not open Order Data file";

@names = $query->param;

foreach $name (@names)
{
$kitprice = "";
$unitprice = "";

if ($name =~ /....SSK/)
{
if ($query->param($name) > 0)
{
if ($query->param($name) < 21)
{
$kitprice = $query->param($name) * $phigh;
$unitprice = "£$phigh";
}

elsif ($query->param($name) < 51)
{
$kitprice = $query->param($name) * $pmed;
$unitprice = "£$pmed";
}

else
{
$kitprice = $query->param($name) * $plow;
$unitprice = "£$plow";
}

#Store variables
$quantity = $query->param($name);
print DATFILE "$name;$quantity;$kitprice;$unitprice;";
print DATFILE "\n";

$b = 1;
while ($b < $a)
{
if ($webcode[$b] eq $name)
{
$code = $prodcode[$b];
$name = $prodname[$b];
}
$b++;
}

$table .= "<tr><td class=\"ul\" align=\"left\">$name</td><td class=\"ul\" align=\"center\" width=\"60\"><b>$unitprice</b></td><td class=\"ul\" align=\"center\" width=\"60\"><b>$quantity</b></td><td class=\"ul\" align=\"center\" width=\"60\"><b>£$kitprice</b></td></tr>";
$hiddendata .= "<input type=\"hidden\" name=\"$name\" value=\"$quantity\">";
}
}

if ($name =~ /....RET/)
{
if ($query->param($name) > 0)
{
$kitprice = $query->param($name) * 30.00;
$unitprice = "£30";

#Store variables
$quantity = $query->param($name);
print DATFILE "$name;$quantity;$kitprice;$unitprice;";
print DATFILE "\n";

$b = 1;
while ($b < $a)
{
if ($webcode[$b] eq $name)
{
$code = $prodcode[$b];
$name = $prodname[$b];
}
$b++;
}

$table .= "<tr><td class=\"ul\" align=\"left\">$name</td><td class=\"ul\" align=\"center\" width=\"60\"><b>$unitprice</b></td><td class=\"ul\" align=\"center\" width=\"60\"><b>$quantity</b></td><td class=\"ul\" align=\"center\" width=\"60\"><b>£$kitprice</b></td></tr>";
$hiddendata .= "<input type=\"hidden\" name=\"$name\" value=\"$quantity\">";
}
}

if ($name =~ /....ILP/)
{
if ($query->param($name) > 0)
{
$kitprice = $query->param($name) * $price;
$unitprice = "£$price";

#Store variables
$quantity = $query->param($name);
print DATFILE "$name;$quantity;$kitprice;$unitprice;";
print DATFILE "\n";

$b = 1;
while ($b < $a)
{
if ($webcode[$b] eq $name)
{
$code = $prodcode[$b];
$name = $prodname[$b];
}
$b++;
}

$table .= "<tr><td class=\"ul\" align=\"left\">$name</td><td class=\"ul\" align=\"center\" width=\"60\"><b>$unitprice</b></td><td class=\"ul\" align=\"center\" width=\"60\"><b>$quantity</b></td><td class=\"ul\" align=\"center\" width=\"60\"><b>£$kitprice</b></td></tr>";
$hiddendata .= "<input type=\"hidden\" name=\"$name\" value=\"$quantity\">";
}
}

}
close(DATFILE);
};

There is more to the beginnig of the second sub but I can't post it here im afraid

stakadush · Oct 1, 2001

this is long man

try comparing between the order no. sent by the user and the filename.
so instead of this:
$file = "$ENV{'DOCUMENT_ROOT'}/compaq/orders/$orderno.dat";

do this:
$file = "$ENV{'DOCUMENT_ROOT'}/compaq/orders/". $query->param("orderno&quot

. ".dat";

Mute101 · Oct 1, 2001

I control the order number, nothing is sent from the user, it is mearly an auto incrementing number that is used as a reference for the customers.

OK this is what I want

every time the script runs it should:

#####~~START~~#####

get orderno from ordernofile

if file "orderno.dat" exists
SKIP
else
add 1 to the number stored in ordernofile
end if

create orderno.dat

fill it with orderinfo.

#####~~END~~#####

this means after the first time the script runs if the user refreshes or uses the back button on his browser they wont be able to increment my orderno.

The script fragment at the top of this thread is what I think should work but it is erratic.

Any more ideas?

Why doesn't :

unless(-e $file)
{
#Move order number on
open(INFILE,">$ENV'DOCUMENT_ROOT'}/compaq/orderno.dat&quot

or die "Can not open KPorderNo data file";
$neword = sprintf("%06d",$orderno+1);
print INFILE "$neword";
close(INFILE);
}

stakadush · Oct 1, 2001

but you can't know that the order was already sent because you have no reference between the user and the data file. how do you know that it's the same user pressing reload and not a new user? you have to have a session id or cart id or something like this coming from the user, in order to know that this order, from this user, was submitted.
i hope i understood what you want.
try using Apache::Session

Mute101 · Oct 2, 2001

OK thanks thats what I needed a push in the right direction.

I didn't think about the script being multi threaded

Once I have some code together I will post it here to make this thread worthwile

Thanks again.
Mute

Mute101 · Oct 2, 2001

OK some clarification required please.

Here is my sub routine order

&lock;
&Load;
&unlock;
&Calc;
&Data;

So in essence I lock the orderno.dat file while I am pulling numbers or updating it. Does this not mean that multi threads don't actually make any difference to the script. Once a session has started it will update the order no..............................

Wait a minute!!!!

While thinking of the way my script works I have gotten the answer myself!

first time through the script I pull the orderno then add 1 to it in the dat file. Second time (refresh) I pull the orderno and check to see if a file exists with that number but it DOESN'T yet I need to take 1 from the second pull of the order no and check for that number!

Aaaaaarrrrggg! SO simple!

Thanks for making me think about what I have written.

Yours

Noobie Mute

Mute101 · Oct 2, 2001

I could do with an edit post on this forum Ikeep thinking about something else just asI submit the last post

).

Is there a session level variable I can use that doesn't involve and 'special' modules?

stakadush · Oct 2, 2001

nope.
but you can use rand to generate a random string that will be unique. i can't write a sample code right now but let me know if you need one and i'll do it later...

Mute101 · Oct 3, 2001

Creating a random number isn't a problem but how do I make that number persist over the session?

Aarrrrgg! please dont MAKE me use cookies!!

Mute101 · Oct 3, 2001

OK a theory.

I have 2 scripts 1 to display products and 1 to display selected product/totals ect.

##script1
create random number in first script
pass number to hidden form input
create file with number as name
file contains 0
##script1 end

##script2
pull number from hidden form data
check file with number
contains 0
pull orderno
add 1 to orderno
set file to 1
contains 1
pull orderno-1
end check
##script2 end

atm my script relys on a formmail set up by my ISP so the problem is where do I destroy the temp randomno file??

Im gonna go try tis and see what I get.

Mute101 · Oct 5, 2001

Hi peeps this it NOT a bump

just so there is something useful in here here id the code I used.

### ~~ Script 1 ~~ ###

sub createSession()
{
$sn = int(rand(1000));
$uid = $sn.$$;
open(S, ">$ENV{'DOCUMENT_ROOT'}/compaq/seskpno/$uid.session&quot

;
print S "0";
close(S);
$session = "<input type=\"hidden\" name=\"session\" value=\"$uid\">";
}

### ~~ Script 2 ~~ ###

sub Load()
{
#Get OrderNo for filename
open(INFILE,"$ENV{'DOCUMENT_ROOT'}/compaq/orderno.dat&quot

or die "Can not open KPorderNo data file";
$orderno = <INFILE>;
close(INFILE);

#Check for data file

$file = $query->param("session&quot

;

open(S,"$ENV{'DOCUMENT_ROOT'}/compaq/seskpno/$file.session&quot

or die "Can not open KPorderNo data file";
$sesinf = <S>;
close(S);

if($sesinf eq "1&quot

{
$orderno = sprintf("%06d",$orderno-1);
}
else
{
#Move order number on
open(INFILE,">$ENV{'DOCUMENT_ROOT'}/compaq/orderno.dat&quot

or die "Can not open KPorderNo data file";
$neword = sprintf("%06d",$orderno+1);
print INFILE "$neword";
close(INFILE);

open(SI,">$ENV{'DOCUMENT_ROOT'}/compaq/seskpno/$file.session&quot

or die "Can not open KPorderNo data file";
$sesinf = "1";
print SI "$sesinf";
close(SI);
}

Dunno if its any use to anyone but its there anyhoo.

Thanks Stakadush for your patience.

stakadush · Oct 9, 2001

my post might be a bit late but...

you can pass the session id through the links of the webste. just add to every link something like ?sid=$session_id. for example:

http://www.yoursite.com/?sid=session_id

this way you can track the user through the website. but it's a much better idea to use cookies.
you can store the ip in a temp file so if a user is browsing your website try looking for the ip to see if there's an open session for this user already (although using ip is not safe).
hope this helps

Tek-Tips is the largest IT community on the Internet today!

Members share and learn making Tek-Tips Forums the best source of peer-reviewed technical information on the Internet!

Checking for file

Mute101

Programmer

stakadush

Programmer

Mute101

Programmer

Mute101

Programmer

stakadush

Programmer

Mute101

Programmer

stakadush

Programmer

Mute101

Programmer

Mute101

Programmer

Mute101

Programmer

stakadush

Programmer

Mute101

Programmer

Mute101

Programmer

Mute101

Programmer

stakadush

Programmer

Similar threads

Part and Inventory Search

Sponsor