CFSET on Conditional Form

NeoTurtle · Aug 27, 2000

Hi everyone. I'm having a bit of a problem with this:

I've made a conditional form to Update or Add a category. I've tried just about everything. I'm using ColdFusion 4.0. This is what I have:

<CFIF IsDefined("CatID&quot

>
<CFSET NewCat="No">

<CFELSE>
<CFSET NewCat="Yes">
</CFIF>

<CFIF NewCat>
<CFSET PageTitle = "JinMAU - Add a Category">
<CFSET ButtonText = " A d d ">
<CFSET Category = " ">

<CFELSE>
<CFQUERY DATASOURCE="jinmau" NAME="Edit">
SELECT CatID, Category
FROM Categories
WHERE CatID=#CatID#
</CFQUERY>
<CFSET PageTitle = "JinMau - Update a Category">
<CFSET ButtonText = " U p d a t e ">
<CFSET Category = "Trim(Categories.Category)">
</CFIF>

<CFOUTPUT QUERY="Edit">

The error occurs when I try to add a new category. Tells me that the QUERY is not named. So I just put <CFOUTPUT> without the query name. Then I get an "error" when trying to update a category. Well, not a error, but I get the words Trim(Categories.Category) instead of the value of the field. I tried putting the <CFOUTPUT> in the <CFIF NewCat> and <CFOUTPUT QUERY="Edit"> in the <ELSE> with no success.

Thanks in advance,
-NeoTurtle

onirike · Aug 28, 2000

Hi!

I modified your code a bit and you will have to put the CFOUTPUT into the else statement. I fixed also that line that was wrong: <CFSET Category = Trim(Categories.Category)>

<CFIF IsDefined("CatID&quot

>
<CFSET NewCat="No">

<CFELSE>
<CFSET NewCat="Yes">
</CFIF>

<CFIF NewCat>
<CFSET PageTitle = "JinMAU - Add a Category">
<CFSET ButtonText = " A d d ">
<CFSET Category = " ">

<CFELSE>
<CFQUERY DATASOURCE="jinmau" NAME="Edit">
SELECT CatID, Category
FROM Categories
WHERE CatID=#CatID#
</CFQUERY>
<CFSET PageTitle = "JinMau - Update a Category">
<CFSET ButtonText = " U p d a t e ">
<CFSET Category = Trim(Categories.Category)>
[tab][tab]<CFOUTPUT QUERY="Edit">
[tab][tab]...
[tab][tab]</CFOUTPUT>
</CFIF>

NeoTurtle · Aug 28, 2000

Thanks for your reply onirike. I'm still having problems with the code. The error is:

Invalid end tag on line 126 at position 1. Cold Fusion was looking at the following text:

</CFOUTPUT>

The likely cause of the problem is the presence of an end tag without a corresponding start tag

That's because I already have a </CFOUTPUT> at the end of the page. I took out the </CFOUTPUT> in the ELSE tag. Then I get this:

An extraneous end tag </CFOUTPUT> has been encountered at document position (124:1) to (124:11). End tags cannot be present in CFML templates without a matching start tag.

The last successfully parsed CFML construct was static text occupying document position (117:53) to (123:1).

Also, the reason I used "Trim(Categories.Category)" is because if I don't use the quotes, the INPUT TEXT BOX puts in Trim(Categories.Category) as the defaul text instead of the actual value. Perhaps posting the entire page and the page leading to the troubled page might help:

The page leading to the troubled page

<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN">

<CFIF NOT ISDEFINED("session.logged&quot

>
<CFLOCATION URL="login.cfm">
</CFIF>

<CFQUERY DATASOURCE="jinmau" NAME="categories">
SELECT Category, CatID
FROM Categories
ORDER BY Category
</CFQUERY>

<HTML>
<HEAD>
<LINK REL="stylesheet" HREF="../JinMAU.css" TYPE="text/css">
<TITLE>JinMAU - Edit Web Directory</TITLE>
</HEAD>


<STYLE>

</STYLE>

</HEAD>

<BODY>
<BR><BR>

<TABLE WIDTH="80%" CELLSPACING="0" CELLPADDING="0" ALIGN="CENTER" NOWRAP STYLE="border-left-width: thin; border-right-width: thin; border-top-width: thin; border-bottom-width: thin; border-width: thin; border-color: 000080; border-style: solid;" CLASS="JinMAU">
<TR>
<TD WIDTH="10%" ALIGN="CENTER" BGCOLOR="000080">
<A HREF="editcat.cfm?CFID=#CFID#&CFTOKEN=#CFTOKEN#">
<FONT COLOR="FFFFFF">
<B>
Add Category
</B>
</FONT>
</A>
</TD>
<TD COLSPAN="2" BGCOLOR="000080">
<FONT SIZE="+2" COLOR="FFFFFF">
<B>
Edit the Web Directory:
</B>
</FONT>
</TD>
</TR>
<CFOUTPUT QUERY="categories">
<TR>

<TD ALIGN="CENTER" BGCOLOR="###Iif(((CurrentRow MOD 2) is 0),de('FFFFFF'),de('CCCCCC'))#" WIDTH="10%">
<A HREF="editcat.cfm?CatID=#CatID#&CFID=#CFID#&CFTOKEN=#CFTOKEN#" STYLE="text-decoration: none">
Edit
</A>
</TD>
<TD BGCOLOR="###Iif(((CurrentRow MOD 2) is 0),de('FFFFFF'),de('CCCCCC'))#" WIDTH="60%" CLASS="JinMAU">
#Category#
</TD>
<TD ALIGN="CENTER" BGCOLOR="###Iif(((CurrentRow MOD 2) is 0),de('FFFFFF'),de('CCCCCC'))#" WIDTH="10%">
<A HREF="delcat.cfm?CatID=#CatID#&CFID=#CFID#&CFTOKEN=#CFTOKEN#" STYLE="text-decoration: none">
Delete
</A>
</TD>
</TR>
</CFOUTPUT>
</TABLE>
<BR>
<BR>

</BODY>
</HTML>

This is the page that's giving me problems.
<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN">

<CFIF NOT ISDEFINED("session.logged&quot

>
<CFLOCATION URL="login.cfm">
</CFIF>

<CFIF IsDefined("CatID&quot

>
<CFSET NewCat="No">

<CFELSE>
<CFSET NewCat="Yes">
</CFIF>

<CFIF NewCat>
<CFSET PageTitle = "JinMAU - Add a Category">
<CFSET ButtonText = " A d d ">
<CFSET Category = " ">

<CFELSE>
<CFQUERY DATASOURCE="jinmau" NAME="Edit">
SELECT CatID, Category
FROM Categories
WHERE CatID=#CatID#
</CFQUERY>
<CFSET PageTitle = "JinMau - Update a Category">
<CFSET ButtonText = " U p d a t e ">
<CFSET Category = Trim(Categories.Category)>
<CFOUTPUT QUERY="Edit">
</CFIF>

<HTML>

<HEAD>
<LINK REL="stylesheet" HREF="../JinMAU.css" TYPE="text/css">
<TITLE>#PageTitle#</TITLE>


<STYLE>

</STYLE>
</HEAD>

<BODY>

<CFIF NewCat IS "No">
<INPUT TYPE="HIDDEN" NAME="CatID" VALUE="#CatID#">
</CFIF>

<FORM ACTION="rencat.cfm?CFID=#CFID#&CFTOKEN=#CFTOKEN#" METHOD="POST">

<TABLE WIDTH="60%" BORDER="0" CELLSPACING="0" CELLPADDING="0" ALIGN="CENTER">
<TR>
<TD WIDTH="10%">
</TD>
<TD COLSPAN="2" ALIGN="CENTER" BGCOLOR="000080">
<FONT FACE="" SIZE="+1" STYLE="font-weight: bold;" COLOR="FFFFFF">
Edit Category
</FONT>
</TD>
<TD WIDTH="10%">
</TD>
</TR>
<TR>
<TD WIDTH="10%">

</TD>
<TD WIDTH="40%">

</TD>
<TD WIDTH="40%">

</TD>
<TD WIDTH="10%">

</TD>
</TR>
<CFIF NewCat IS "No">
<TR>
<TD WIDTH="10%">
</TD>
<TD WIDTH="40%">
Old Name:
</TD>
<TD WIDTH="40%">
#Category#
</TD>
<TD WIDTH="10%">
</TD>
</TR>
</CFIF>
<TR>
<TD WIDTH="10%">
</TD>
<TD WIDTH="40%">
New Name:
</TD>
<TD WIDTH="40%">
<INPUT TYPE="TEXT" NAME="Category" VALUE="#Category#">
</TD>
<TD WIDTH="10%">
</TD>
</TR>
<TR>
<TD WIDTH="10%">
</TD>
<TD WIDTH="10%">
</TD>
<TD WIDTH="40%">
<INPUT TYPE="SUBMIT" VALUE="#ButtonText#">
</TD>
<TD WIDTH="10%">
</TD>
<TD WIDTH="10%">
</TD>
</TR>
</CFOUTPUT>
</TABLE>

</FORM>

</BODY>
</HTML>

Once again . . . thanks in advance.
-NeoTurtle

onirike · Aug 29, 2000

Hi!

I fixed some stuff once again!
Not sure if it will fix everything but try it!

Chris

fixed code

<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN">

<CFIF NOT ISDEFINED("session.logged&quot>
<CFLOCATION URL="login.cfm">
</CFIF>

<CFIF IsDefined("CatID&quot>
<CFSET NewCat="No">

<CFELSE>
<CFSET NewCat="Yes">
</CFIF>

<CFIF NewCat>
<CFSET PageTitle = "JinMAU - Add a Category">
<CFSET ButtonText = " A d d ">
<CFSET Category = " ">

<CFELSE>
<CFQUERY DATASOURCE="jinmau" NAME="Edit">
SELECT CatID, Category
FROM Categories
WHERE CatID=#CatID#
</CFQUERY>
<CFSET PageTitle = "JinMau - Update a Category">
<CFSET ButtonText = " U p d a t e ">
<CFSET Category = Trim(Edit.Category)>
</CFIF>

<CFOUTPUT>

<HTML>

<HEAD>
<LINK REL="stylesheet" HREF="../JinMAU.css" TYPE="text/css">
<TITLE>#PageTitle#</TITLE>


<STYLE>

</STYLE>
</HEAD>

<BODY>

<CFIF NewCat IS "No">
<INPUT TYPE="HIDDEN" NAME="CatID" VALUE="#CatID#">
</CFIF>

<FORM ACTION="rencat.cfm?CFID=#CFID#&CFTOKEN=#CFTOKEN#" METHOD="POST">

<TABLE WIDTH="60%" BORDER="0" CELLSPACING="0" CELLPADDING="0" ALIGN="CENTER">
<TR>
<TD WIDTH="10%">
</TD>
<TD COLSPAN="2" ALIGN="CENTER" BGCOLOR="000080">
<FONT FACE="" SIZE="+1" STYLE="font-weight: bold;" COLOR="FFFFFF">
Edit Category
</FONT>
</TD>
<TD WIDTH="10%">
</TD>
</TR>
<TR>
<TD WIDTH="10%">

</TD>
<TD WIDTH="40%">

</TD>
<TD WIDTH="40%">

</TD>
<TD WIDTH="10%">

</TD>
</TR>
<CFIF NewCat IS "No">
<TR>
<TD WIDTH="10%">
</TD>
<TD WIDTH="40%">
Old Name:
</TD>
<TD WIDTH="40%">
#Category#
</TD>
<TD WIDTH="10%">
</TD>
</TR>
</CFIF>
<TR>
<TD WIDTH="10%">
</TD>
<TD WIDTH="40%">
New Name:
</TD>
<TD WIDTH="40%">
<INPUT TYPE="TEXT" NAME="Category" VALUE="#Category#">
</TD>
<TD WIDTH="10%">
</TD>
</TR>
<TR>
<TD WIDTH="10%">
</TD>
<TD WIDTH="10%">
</TD>
<TD WIDTH="40%">
<INPUT TYPE="SUBMIT" VALUE="#ButtonText#">
</TD>
<TD WIDTH="10%">
</TD>
<TD WIDTH="10%">
</TD>
</TR>
</CFOUTPUT>
</TABLE>

</FORM>

</BODY>
</HTML>

NeoTurtle · Aug 29, 2000

Thanks a lot Chris!! Works great!! Now I need to start a new thread regarding DarkMan's Login in page code . . . I think it's not secure.

-NeoTurtle

NeoTurtle · Aug 29, 2000

Never mind about DarkMan's Login page . . . I thought I could access my secured pages with ?CFID= at the end, it could it be that the session was still alive. I'm going to keep trying to break into my page. =)

Thanks again,
NeoTurtle

Tek-Tips is the largest IT community on the Internet today!

Members share and learn making Tek-Tips Forums the best source of peer-reviewed technical information on the Internet!

CFSET on Conditional Form

NeoTurtle

Programmer

onirike

Programmer

NeoTurtle

Programmer

onirike

Programmer

NeoTurtle

Programmer

NeoTurtle

Programmer

Similar threads

Part and Inventory Search

Sponsor