Can't close pipe error

[cb49747]

here is some code I use

my $outfile = "/data/home/xxx/xxx/holder_u.txt";

my $cmd = qq(/usr/bin/gpg --no-tty --passphrase-fd 0 -o $temp_path$p --decrypt $upload_path$p > $outfile 2>&1);
$| = 1;
open(FH, "| $cmd") || die qq(Can't open pipe to "$cmd".\n);
print FH "$pass\n";
close(FH) || die qq(Can't close pipe to "$cmd".\n);
open(FH, "<$outfile") || die qq(Can't open "$outfile" for read.\n);
my @rc = <FH>;
close(FH) || die qq(Can't close "$outfile" after read.\n);
$r = join '<br>', @rc; $return .= $r;

However hen I run this from a webbrowser I get this error

Can't close pipe to "/usr/bin/gpg --no-tty --passphrase-fd 0 -o /data/home/xxx/xxx/xxx/xxx/xxx/xxx.txt.pgp --decrypt /data/home/xxx/xxx/xxx/xxx/xxx/xxx/xxx.txt.pgp > /data/home/xxx/xxx/holder_u.txt 2>&1".

Any ideas?

 

[cb49747]

The dir are not really xxx I just changed for security reasons.

 

[Kirsle]

Quote from perlfunc:

close FILEHANDLE
close

Closes the file or pipe associated with the file handle, returning true only if IO buffers are successfully flushed and closes the system file descriptor. Closes the currently selected filehandle if the argument is omitted.

You don't have to close FILEHANDLE if you are immediately going to do another open on it, because open will close it for you. (See open.) However, an explicit close on an input file resets the line counter ($.), while the implicit close done by open does not.

If the file handle came from a piped open, close will additionally return false if one of the other system calls involved fails, or if the program exits with non-zero status. (If the only problem was that the program exited non-zero, $! will be set to 0.) Closing a pipe also waits for the process executing on the pipe to complete, in case you want to look at the output of the pipe afterwards, and implicitly puts the exit status value of that command into $?.

Prematurely closing the read end of a pipe (i.e. before the process writing to it at the other end has closed it) will result in a SIGPIPE being delivered to the writer. If the other end can't handle that, be sure to read all the data before closing the pipe.

Example:

        open(OUTPUT, '|sort >foo')  # pipe to sort
            or die "Can't start sort: $!";
        #...                        # print stuff to output
        close OUTPUT                # wait for sort to finish
            or warn $! ? "Error closing sort pipe: $!"
                       : "Exit status $? from sort";
        open(INPUT, 'foo')          # get sort's results
            or die "Can't open 'foo' for input: $!";

FILEHANDLE may be an expression whose value can be used as an indirect filehandle, usually the real filehandle name.

So that's why close would return false on your pipe handle. In the example code they did a warn on it because it may return false, rather than a die which kills the script.

 

[cb49747]

Thank you very much and I will try this out in the morning.

 

[cb49747]

Well the above worked, as it stoped the close pipe error. Thank you.