i am trying to make a simple database template(?). adding and deleting from the mysql database worked fine untill I tried to add edit, the edit wont work. also it always says 'Record has been deleted from database', its only supposed to say that when you delete from it. I also tried to use a switch to control everything but nothing worked after that. can someone look at my code and tell me whats wrong? (my webhost doesnt support php so its just a text file.)
Tek-Tips is the largest IT community on the Internet today!
Members share and learn making Tek-Tips Forums the best source of peer-reviewed technical information on the Internet!
-
Congratulations derfloh on being selected by the Tek-Tips community for having the most helpful posts in the forums last week. Way to Go!
bad control structures? 3
- Thread starter streetbmx
- Start date
-
2
- #2
gerrygerry
Technical User
Looking at your code, I have to recommend you start using seperate files for seperate tasks. I didn't notcie any errors though. Using seperate file for each task is the best way to do it though. Everything is handled by the index.php file. By default, the index.php file will just list all the entries.
This is untested - it should work though... just make each of the files. This uses mostly your code, I just reorganized it a bit.
index.php:
vars.php
header.php
add.php:
footer.php
edit.php:
delete.php:
save.php:
update.php:
list.php:
I hope this helps! This is usually how I make my programs. It seems a lot easier to keep track of things! Lemme know if you have any questions.
Good luck! -gerrygerry
Go To
This is untested - it should work though... just make each of the files. This uses mostly your code, I just reorganized it a bit.
index.php:
Code:
<?
require("vars.php");
Code:
// for database connection vars
Code:
switch($todo)
{
case
Code:
"add"
Code:
;
Code:
// display a blank form
Code:
$title = "
Code:
Add New Entry
Code:
";
Code:
// used by header
Code:
require("header.php");
Code:
// your page header
Code:
require("add.php");
Code:
// submits to index.php?todo=save
Code:
require("footer.php");
Code:
// your page footer
Code:
break;
case
Code:
"edit"
Code:
:
Code:
// pull the data from db and plugs into form
Code:
$title = "
Code:
Edit Existing Entry
Code:
";
Code:
// used by header
Code:
require("header.php");
Code:
// your page header
Code:
require("edit.php");
Code:
// edits $editid, submits to index.php?todo=update
Code:
require("footer.php");
Code:
// your page footer
Code:
break;
case
Code:
"delete"
Code:
:
require("delete.php");
Code:
// deletes $deleteid from the db
Code:
header("Location: index.php");
Code:
// go to listing
Code:
break;
case
Code:
"save"
Code:
:
require("save.php");
Code:
// add new entry to db
Code:
header("Location: index.php");
Code:
// go to listing
Code:
break;
case
Code:
"update"
Code:
:
require("update.php");
Code:
// update the db where id=$id
Code:
header("Location: index.php");
Code:
// go to listing
Code:
break;
default:
$title = "
Code:
Viewing All Entries
Code:
";
Code:
// used by header
Code:
require("header.php");
Code:
// your page header
Code:
require("list.php");
Code:
//show all entries
Code:
require("footer.php");
Code:
// your page footer
Code:
break;
}
?>vars.php
Code:
<?
$db_host = "
Code:
localhost
Code:
";
$db_user = "
Code:
YOUR_USERNAME
Code:
";
$db_pass = "
Code:
YOUR_PASSWORD
Code:
";
$db_name = "
Code:
address
Code:
";
$db_table = "
Code:
addresses
Code:
";
?>header.php
Code:
<HTML>
<HEAD>
<TITLE><?
echo "
Code:
$title
Code:
";
?></TITLE>
</HEAD>
<BODY>add.php:
Code:
<form method="post" action="index.php">
<input type="hidden" name="todo" value="save">
<table>
<tr>
<td>First Name:</td>
<td><input type="text" name="f_name"></td>
</tr>
<tr>
<td>Last Name:</td>
<td><input type="text" name="l_name"></td>
</tr>
<tr>
<td>Phone:</td>
<td><input type="text" name="phone"></td>
</tr>
<tr>
<td>Email:</td>
<td><input type="text" name="email"></td>
</tr>
<tr>
<td></td>
<td><input type="submit" name="submit" value="ADD"></td>
</tr>
</table>
</form>footer.php
Code:
</BODY>
</HTML>edit.php:
Code:
<?
mysql_connect($db_host, $db_user, $db_pass);
mysql_select_db($db_name);
$result = mysql_query("SELECT * FROM addresses WHERE id=$editid");
$edit = mysql_fetch_array($result);
?>
<form method="post" action="index.php">
<input type="hidden" name="todo" value="update">
<input type="hidden" name="id" value="<? echo $edit["id"] ?>">
<table>
<tr>
<td>First Name:</td>
<td><input type="text" name="f_name" value="<? echo $edit["f_name"] ?>"></td>
</tr>
<tr>
<td>Last Name:</td>
<td><input type="text" name="l_name" value="<? echo $edit["l_name"] ?>"></td>
</tr>
<tr>
<td>Phone:</td>
<td><input type="text" name="phone" value="<? echo $edit["phone"] ?>"></td>
</tr>
<tr>
<td>Email:</td>
<td><input type="text" name="email" value="<? echo $edit["email"] ?>"></td>
</tr>
<tr>
<td></td>
<td><input type="submit" name="submit" value="update"></td>
</tr>
</table>
</form>delete.php:
Code:
<?
mysql_connect($db_host, $db_user, $db_pass);
mysql_select_db($db_name);
$result = mysql_query("DELETE FROM addresses WHERE id=$deleteid");
?>save.php:
Code:
<?
mysql_connect($db_host, $db_user, $db_pass);
mysql_select_db($db_name);
$result = mysql_query("INSERT INTO addresses (id,f_name,l_name,phone,email) VALUES ('NULL', '$f_name', '$l_name', '$phone', '$email')");
?>update.php:
Code:
<?
mysql_connect($db_host, $db_user, $db_pass);
mysql_select_db($db_name);
$result = mysql_query("UPDATE addresses SET f_name=$f_name,l_name=$l_name,phone=$phone,email=$email WHERE id=$id");
?>list.php:
Code:
<div align="center">
<h2>Database Template</h2>
<a href="index.php?todo=add">Add a Record</a>
<br>
<br>
<table border="1">
<tr bgcolor="#DADADA" align="center">
<td><strong>ID</strong></td>
<td><strong>First Name</strong></td>
<td><strong>Last Name</strong></td>
<td><strong>Phone</strong></td>
<td><strong>Email</strong></td>
<td><strong>Delete</strong></td>
<td><strong>Edit</strong></td>
</tr>
<?php
mysql_connect($db_host, $db_user, $db_pass);
mysql_select_db($db_name);
$result = mysql_query("select * from addresses");
while($r=mysql_fetch_array($result))
{
$id=$r["id"];
$f_name=$r["f_name"];
$l_name=$r["l_name"];
$phone=$r["phone"];
$email=$r["email"];
?>
<tr>
<td><? echo $id ?></td>
<td><? echo $f_name ?></td>
<td><? echo $l_name ?></td>
<td><? echo $phone ?></td>
<td><a href="mailto:<? echo $email ?>"><? echo $email ?></a></td>
<td><a href="index.php?todo=delete&deleteid=<? echo $id ?>">delete</td>
<td><a href="index.php?todo=edit&editid=<? echo $id ?>">edit</td>
</tr>
<?
}
?>
</table>
<br>
<a href="#top">Top of Page</a>
</div>I hope this helps! This is usually how I make my programs. It seems a lot easier to keep track of things! Lemme know if you have any questions.
Good luck! -gerrygerry
Go To
gerrygerry
Technical User
Whoops! I meant to change each of your database queries to have a $db_table every place it said addresses. I did this for portability... if you every change the table name, have to change servers, or username/password, you'll only have to edit your vars.php file. -gerrygerry
Go To
Go To
gerrygerry
Technical User
Thanks karver! -gerrygerry
Go To
Go To
- Thread starter
- #7
DiamondLil
Technical User
gerrygerry !
Are you still around for a question on your code?
--L
Are you still around for a question on your code?
--L
-
1
- #9
danielhozac
Programmer
You could always ask and see if someone else can answer it. //Daniel
DiamondLil
Technical User
True, Daniel - I will.
I'm trying to look at doing a test of an updateable area with gerrygerrys *hellashisly * organized code to help me learn this. I first copied that code exacly darnit [other than changing the last break on the switch statements on the index.php pg to an endswitch and a ' ; ' to a ':' after ' add '] - but I'm getting an error (and I was getting the error before I started trying to touch any of his code):
Parse error: parse error, expecting `T_CASE' or `T_DEFAULT' or `'}'' in /usr/local/etc/httpd/htdocs/prologi/editbox/index.php on line 4
Pretty much same code as above - but I shall post it in case I did something dumb and don't realize it:
<?
require("vars.php"
; // for database connection vars
switch ($todo) {
case "add":
// display a blank form
$title = "Add New Entry"; // used by header
require("header.php" // your page header
require("add.php" // submits to index.php?todo=save
require("footer.php" // your page footer
break;
case "edit":
// pull the data from db and plugs into form
$title = "Edit Existing Entry"; // used by header
require("header.php" // your page header
require("edit.php" // edits $editid, submits to index.php?todo=update
require("footer.php" // your page footer
break;
case "delete":
require("delete.php" // deletes $deleteid from the db
header("Location: index.php" // go to listing
break;
case "save":
require("save.php" // add new entry to db
header("Location: index.php" // go to listing
break;
case "update":
require("update.php" // update the db where id=$id
header("Location: index.php" // go to listing
break;
default:
$title = "Viewing All Entries"; // used by header
require("header.php" // your page header
require("list.php" //show all entries
require("footer.php" // your page footer
endswitch;
}
?>
-L
I'm trying to look at doing a test of an updateable area with gerrygerrys *hellashisly * organized code to help me learn this. I first copied that code exacly darnit [other than changing the last break on the switch statements on the index.php pg to an endswitch and a ' ; ' to a ':' after ' add '] - but I'm getting an error (and I was getting the error before I started trying to touch any of his code):
Parse error: parse error, expecting `T_CASE' or `T_DEFAULT' or `'}'' in /usr/local/etc/httpd/htdocs/prologi/editbox/index.php on line 4
Pretty much same code as above - but I shall post it in case I did something dumb and don't realize it:
<?
require("vars.php"
; // for database connection varsswitch ($todo) {
case "add":
// display a blank form
$title = "Add New Entry"; // used by header
require("header.php"
; // your page headerrequire("add.php"
; // submits to index.php?todo=saverequire("footer.php"
; // your page footerbreak;
case "edit":
// pull the data from db and plugs into form
$title = "Edit Existing Entry"; // used by header
require("header.php"
; // your page headerrequire("edit.php"
; // edits $editid, submits to index.php?todo=updaterequire("footer.php"
; // your page footerbreak;
case "delete":
require("delete.php"
; // deletes $deleteid from the dbheader("Location: index.php"
; // go to listingbreak;
case "save":
require("save.php"
; // add new entry to dbheader("Location: index.php"
; // go to listingbreak;
case "update":
require("update.php"
; // update the db where id=$idheader("Location: index.php"
; // go to listingbreak;
default:
$title = "Viewing All Entries"; // used by header
require("header.php"
; // your page headerrequire("list.php"
; //show all entries require("footer.php"
; // your page footerendswitch;
}
?>
-L
danielhozac
Programmer
Remove the endswitch;. It shouldn't be there. That is only if you use the other "not-so-nice" (IMO) way of scripting in PHP. It looks like this if you're going to use that way:
Note the colon after the switch and that you don't use any {s or }s. //Daniel
Code:
switch ($statement):
case 'Somecase':
echo "Some text";
break;
default:
echo "Nothing else matched";
endswitch;gerrygerry
Technical User
Im still around... I guess I'm a little too late to help though... thanks for covering for me Daniel! I haven't had much time to post here lately... -gerrygerry
Standard response to one of my posts:
"No where in your entire rantings did you come anywhere close to what can be considered a rational answer. We are all now dumber from having heard that. I award you no points and may God have mercy on your soul."
Standard response to one of my posts:
"No where in your entire rantings did you come anywhere close to what can be considered a rational answer. We are all now dumber from having heard that. I award you no points and may God have mercy on your soul."
DiamondLil
Technical User
Hi guys.
Ok, I replaced the endswitch with the break;
but I still get the error:
parse error, expecting `T_CASE' or `T_DEFAULT' or `'}''
-L
Ok, I replaced the endswitch with the break;
but I still get the error:
parse error, expecting `T_CASE' or `T_DEFAULT' or `'}''
-L
danielhozac
Programmer
Could you post the exact error message you are getting? What version of PHP are you using? //Daniel
DiamondLil
Technical User
It's at least 4.0.1, I think, definitely not 4.1 yet.
The error is:
Parse error: parse error, expecting `T_CASE' or `T_DEFAULT' or `'}'' in /usr/local/etc/httpd/htdocs/prologi/editbox/index.php on line 4
But I don't know what to DO to on (or around) line 4...
The error is:
Parse error: parse error, expecting `T_CASE' or `T_DEFAULT' or `'}'' in /usr/local/etc/httpd/htdocs/prologi/editbox/index.php on line 4
But I don't know what to DO to on (or around) line 4...
danielhozac
Programmer
And what is line 4? Is it the case "add": line? //Daniel
gerrygerry
Technical User
It seems to me you might have an invisible control character in your code... sometimes you might accidentallly hit a ctrl+[SOMETHING] and it just isn't visible... try deleting the line, the line before it, and the line after it... then retype them. -gerrygerry
Standard response to one of my posts:
"No where in your entire rantings did you come anywhere close to what can be considered a rational answer. We are all now dumber from having heard that. I award you no points and may God have mercy on your soul."
Standard response to one of my posts:
"No where in your entire rantings did you come anywhere close to what can be considered a rational answer. We are all now dumber from having heard that. I award you no points and may God have mercy on your soul."
danielhozac
Programmer
I agree with gerrygerry on this one. That is the only thing that could cause this kind of trouble. //Daniel
DiamondLil
Technical User
ok, thanks, let me give it a shot.
-L
-L
- Status