ArrayList problem 1

[djam]

When I add MyObject into a ArrayList, the last MyObject when added copies itself into all the MyObjects in the ArrayList. So everything has the value of the last MyObject. I don't know why it does this.

any suggestions...

thanks

" ahhh computers, how they made our lives much simpler "

 

[JohnYingling]

Code?

I'll try remote viewing.

I'll bet you are changing MyObject after you add it to the the Arraylist and then adding MyObject again. Adding to an arraylist just adds a reference to the object into the arraylist, not a copy.

http://www.VBResizer.com

Forms/Controls Resizing/Tabbing

http://www.VBCompare.com

Compare Code

http://www.VBSortGen.com

Generate Sort Class in VB

http://www.Vbcompare.com/Check.Htm(1979

Check To MS)

 

[VenkatRastapuram]

Hi,

Please send the code so that I can clearly understand your problem.

Regards,
R.Venkatesh
MakeLogic

http://www.makelogic.com

venkat@makelogicmldb.com

 

[JCruz063]

djam,
I agree with JohnYingling. Objects are reference types and object variables store object references. It might be that you're storing the object references in your array and all the references are pointing to the same object. Let us see some of your code to see if this is indeed the case.

JC

_________________________________________________
To get the best response to a question, read faq222-2244.

 

[djam]

When I add the last one into the ArrayList it changes everything...

ArrayList ar = new ArrayList();

string sqlTemp = "select * from ELoaderRef";
reader = seDB.GetSqlResults(sqlTemp);

while (reader.Read())
{
CrisSSHolder ch = new CrisSSHolder();
ch.CustomerKey = reader["customerKey"].ToString();
ch.OrderType = reader["orderType"].ToString();
ar.Add(ch);
}

" ahhh computers, how they made our lives much simpler "

 

[djam]

How would I not add the reference of the object into the ArrayList?

" ahhh computers, how they made our lives much simpler "

 

[JohnYingling]

OK. Now where is the code at which point the "everthing changed" is discovered?

http://www.VBResizer.com

Forms/Controls Resizing/Tabbing

http://www.VBCompare.com

Compare Code

http://www.VBSortGen.com

Generate Sort Class in VB

http://www.Vbcompare.com/Check.Htm(1979

Check To MS)

 

[djam]

ar.Add(ch);

When I add the last element to the array list, everything changes in the arraylist

" ahhh computers, how they made our lives much simpler "

 

[JohnYingling]

How did you determine that? And what do you mean by "last"...the "just previously added changes all the previous ones" or "all are OK until I add the very last item from the datareader"?

http://www.VBResizer.com

Forms/Controls Resizing/Tabbing

http://www.VBCompare.com

Compare Code

http://www.VBSortGen.com

Generate Sort Class in VB

http://www.Vbcompare.com/Check.Htm(1979

Check To MS)

 

[djam]

sorry sorry, it changes everytime I add a new object to the arraylist. The data was named very similar to each other except for the last one and I thought it only changed for the last item.

But everytime I add a new item to the arraylist, it changes everything in the arraylist. This is probably bc its using the reference of the same object. How can I fix it so that it uses a different reference?

thanks

" ahhh computers, how they made our lives much simpler "

 

[JohnYingling]

According to
CrisSSHolder ch = new CrisSSHolder();
you are creating a new object.

We need to see the CrisSSHolder object. Please tell me that the fields are not defined as "Static".

http://www.VBResizer.com

Forms/Controls Resizing/Tabbing

http://www.VBCompare.com

Compare Code

http://www.VBSortGen.com

Generate Sort Class in VB

http://www.Vbcompare.com/Check.Htm(1979

Check To MS)

 

[djam]

The fields CrisSSHolder has is

1) CustomerKey
2) OrderType

" ahhh computers, how they made our lives much simpler "

 

[djam]

oh darn!! found the error, I copied some code from a different class when I created CrisSSHolder and the fields were declared static... changed it to non-static and it works...

thanks for your help

" ahhh computers, how they made our lives much simpler "

 

[JohnYingling]

Code!!!
I can see the names of the properties in
CrisSSHolder ch = new CrisSSHolder();
ch.CustomerKey = reader["customerKey"].ToString();
ch.OrderType = reader["orderType"].ToString();
but that means nothing. We must see the code showing how and where the data for the property is actually stored inside the class. Take NOTHING for granted.

When something criminal happens to someone in a "family", at whom do the police first direct all their attention, absent other evidence to the contrary? Answer: other family members. Well right now, you and your code are the prime suspects, not some mysterious "one armed" man (i.e. Microsoft .Net Framework) who might have wandered by

http://www.VBResizer.com

Forms/Controls Resizing/Tabbing

http://www.VBCompare.com

Compare Code

http://www.VBSortGen.com

Generate Sort Class in VB

http://www.Vbcompare.com/Check.Htm(1979

Check To MS)

 

[JohnYingling]

Ok,

I wrote the last reply before seeing your "Eureka". Remember this time...it will help shorten the time for discovering the next error. Your first thought should always be, "this error is so bizarre that it has to my fault." Sometimes it is not...but rarely.

http://www.VBResizer.com

Forms/Controls Resizing/Tabbing

http://www.VBCompare.com

Compare Code

http://www.VBSortGen.com

Generate Sort Class in VB

http://www.Vbcompare.com/Check.Htm(1979

Check To MS)