any ideas why this won't save

[UKmedia]

Dim strSQL As String

        'Update Existing
        strSQL = "UPDATE cashier SET FullName = '" & txtName.Text & "', Address = '" & txtAddress.Text & "', Telephone = '" & txtContact.Text & "', Age = '" & txtAge.Text & "', NI = '" & txtNI.Text & "', EContact = '" & txtEContact.Text & "', EName = '" & txtEName.Text & "', ERelationship = '" & txtERelationship.Text & "' WHERE Code=" & "'" & CLng(Me.lvEmployees.SelectedItems(0).Tag) & "'"
        Dim ocon As OleDbConnection = New OleDbConnection(DB_Connect)
        ocon.Open()

        Dim ocmd As OleDbCommand = New OleDbCommand(strSQL, ocon)
        ocmd.ExecuteNonQuery()

        ocmd.Dispose()
        ocon.Close()

        MessageBox.Show("Saved Details", "Saved", MessageBoxButtons.OK, MessageBoxIcon.Information)

I get error:

Data type mismatch in criteria expression.

 

[Andrzejek]

Do yourself a favor and try:

Dim strSQL As String

        'Update Existing
        strSQL = "UPDATE cashier SET FullName = '" & txtName.Text & "', Address = '" & txtAddress.Text & "', Telephone = '" & txtContact.Text & "', Age = '" & txtAge.Text & "', NI = '" & txtNI.Text & "', EContact = '" & txtEContact.Text & "', EName = '" & txtEName.Text & "', ERelationship = '" & txtERelationship.Text & "' WHERE Code=" & "'" & CLng(Me.lvEmployees.SelectedItems(0).Tag) & "'"

    [red][b]Debug.Print strSQL[/b][/red]

        Dim ocon As OleDbConnection = New OleDbConnection(DB_Connect)
        ocon.Open()

        Dim ocmd As OleDbCommand = New OleDbCommand(strSQL, ocon)
        ocmd.ExecuteNonQuery()

        ocmd.Dispose()
        ocon.Close()

        MessageBox.Show("Saved Details", "Saved", MessageBoxButtons.OK, MessageBoxIcon.Information)

and see what you are trying to execute.

Most of the time you can spot the problem in your SQL.


Have fun.

---- Andy

 

[UKmedia]

i have done this but cannot see where.

 

[SgtJarrow]

Two things jump out.....AGE and CODE. Are these truly text values??? You are passing them text and either of them could be numeric based on the names....

=======================================
People think it must be fun to be a super genius, but they don't realize how hard it is to put up with all the idiots in the world. (Calvin from Calvin And Hobbs)

Robert L. Johnson III
CCNA, CCDA, MCSA, CNA, Net+, A+, CHDP
VB.NET Programmer

 

[ZmrAbdulla]

The mistake should be here

strSQL = "UPDATE cashier SET FullName = '" & txtName.Text & "'
, Address = '" & txtAddress.Text & "'
, Telephone = '" & txtContact.Text & "'
, Age = '" & txtAge.Text & "'
, NI = '" & txtNI.Text & "'
, EContact = '" & txtEContact.Text & "'
, EName = '" & txtEName.Text & "'
, ERelationship = '" & txtERelationship.Text & "' 
[COLOR=red]WHERE Code=" & "'" & CLng(Me.lvEmployees.SelectedItems(0).Tag) & "'"[/color]

You are passing a Integer like string. try changing to

[COLOR=green]WHERE Code=" & CLng(Me.lvEmployees.SelectedItems(0).Tag) [/color]

________________________________________________________
Zameer Abdulla
Help to find Missing people

 

[UKmedia]

that worked cheers,

It was also down to me trying to enter in a text item into a number field too.