I see Mike already addressed your core problem.
You make use of macrosubstitution as someone being proud to know it and liking it a lot.
What you do can be done much more directly, still using macro substitution, but just for the control name itself:
Code:
cTextControl = 'myForm.text' + ALLTRIM(STR(i+3))
&cTextcontrol..ControlSource = nameCursor+"."+arField(i)
similar for the Labelcaption. What's true is, that no matter whether you build a string of a full line of code or just have a part like the control name as a macro, the compiler wil determine the full line and compile it. It also doesn't matter how many macros are used, it all ends up in onle line of code that is compiled. It's just often better to not make up the whole line, especially if building it up is more complicated than writing it down as is, without needing to think how to put it into a string, especially since string delimiters then become a problem.
Also, this only works provided Mike is right, nameCursor is a variable or parameter that has the name of the cursor/workarea, then you don't literally mean nameCursor, but it's a variable that contains the name and therefore you use it unquoted to get its value and not use its name.
Btw, it's not nice to have something like Text1,2,,3,4 and then even like in this situation, where I assume Text1,2 and 3 are for something else and the texboxes for the data start at Text4 for field1, etc.
This is not good style at all, I'll just let that stand alone, there are other ways to get this into a better way of addressing. But that's a longer lesson.
You can go one step further, when you make use of EVAL to get an object reference and then WITH
Code:
oTextControl = Eval('myForm.text' + ALLTRIM(STR(i+3)))
WITH oTextControl
.ControlSource = nameCursor+"."+arField(i)
ENDWITH
I won't make up an example to see if it even works shortened to
Code:
WITH Eval('myForm.text' + ALLTRIM(STR(i+3)))
.ControlSource = nameCursor+"."+arField(i)
ENDWITH
This way the compiler isn't needed to compile the line that has one or more macro substitutions.
Well, the far simplest way to get controls bound to fields is
1. open a table in the form dataaenvirnoment (at design time right click and pick data evironment)
2. Drag one field from the visual displayy of a table in the data environment to the form
3. done
This is not building up HTML at runtime, the form is ideally visually design and only needs to be run, not built up.
You have a textbox (usually) that already has controlsource set and a label in front of it with the field name as caption. And there are ways to make this even better.
The major point is actually not that it's easy to do as a drag&drop operation, you do smething in code that's better and easier one at design time. Once you have this all, you can rename the control, you can add controls that go
before it or after, and it all still works, while your code depends on no renumbering and is likely to fail one day someone has the idea of consolidating control names.
Chriss
