×
INTELLIGENT WORK FORUMS
FOR COMPUTER PROFESSIONALS

Log In

Come Join Us!

Are you a
Computer / IT professional?
Join Tek-Tips Forums!
  • Talk With Other Members
  • Be Notified Of Responses
    To Your Posts
  • Keyword Search
  • One-Click Access To Your
    Favorite Forums
  • Automated Signatures
    On Your Posts
  • Best Of All, It's Free!
  • Students Click Here

*Tek-Tips's functionality depends on members receiving e-mail. By joining you are opting in to receive e-mail.

Posting Guidelines

Promoting, selling, recruiting, coursework and thesis posting is forbidden.

Students Click Here

Jobs

bash nested loop not working?
2

bash nested loop not working?

bash nested loop not working?

(OP)
Struggling here to get both IPs in my arr1 to be blocked going to the URLs listed in arr2 In the future, I'd like to expand arr1 to add more IPs if needed.
Can someone please assist with my code below? Thanks in advance.

#!/bin/sh

arr1="192.168.1.12 192.168.1.14"
arr2="facebook.com twitter.com linkedin.com tumblr.com instagram.com"

for ((i=0;i<${#arr1[@]};++i)); do
for DOMAIN in $arr2; do
echo "-I FORWARD -p tcp -s "$arr[i]" --dport 443 -m string --string "$DOMAIN" --algo bm --to 65535 -j DROP"
done
done
exit

RE: bash nested loop not working?

2
Hi

You not declared variable $arr of type array ( at least not in the fragment you posted ).
If you intended to use $arr1, that is not of type array.

CODE --> bash

arr1=(192.168.1.12 192.168.1.14)
arr2="facebook.com twitter.com linkedin.com tumblr.com instagram.com"

for ((i=0;i<${#arr1[@]};++i)); do
    for DOMAIN in $arr2; do
        echo -I FORWARD -p tcp -s "${arr1[i]}" --dport 443 -m string --string "$DOMAIN" --algo bm --to 65535 -j DROP
    done
done 

Regarding the /bin/sh in your shebang, you know your script is not Bourne shell compatible, right ? ( The C-like for is Bash & Ksh specific extension. )

Feherke.
feherke.github.io

RE: bash nested loop not working?

(OP)
Thanks feherke,

I'm aware of the /bin/sh in my shebang. This script is being run on my linux router.

Thanks!

Red Flag This Post

Please let us know here why this post is inappropriate. Reasons such as off-topic, duplicates, flames, illegal, vulgar, or students posting their homework.

Red Flag Submitted

Thank you for helping keep Tek-Tips Forums free from inappropriate posts.
The Tek-Tips staff will check this out and take appropriate action.

Reply To This Thread

Posting in the Tek-Tips forums is a member-only feature.

Click Here to join Tek-Tips and talk with other members! Already a Member? Login

Close Box

Join Tek-Tips® Today!

Join your peers on the Internet's largest technical computer professional community.
It's easy to join and it's free.

Here's Why Members Love Tek-Tips Forums:

Register now while it's still free!

Already a member? Close this window and log in.

Join Us             Close