Tek-Tips is the largest IT community on the Internet today!

Members share and learn making Tek-Tips Forums the best source of peer-reviewed technical information on the Internet!

Register Log in
  • Congratulations bkrike on being selected by the Tek-Tips community for having the most helpful posts in the forums last week. Way to Go!

simplify the code pls 1

Status
Not open for further replies.
peac3

peac3

Technical User
Jan 17, 2009
226
AU
Hi guys,

The codes below are working but I don't it's the best efficient code as they are some repetitive code and I haven't figured out what the best the way to simplify it.
Appreciate your help on this codes below:

Code: 
                for (int i = 0; i < CodeList.Count; i++)
                {
                    if (!IsUpdateMode)
                    {
                        if (CodeList[i].CODE_ACTV_F.IsEqual("Y"))
                        {
                            KeyValuePairList.Add(new KeyValuePair<string, string>(CodeList[i].BRANCH_CODE, CodeList[i].BRANCH_CODE + " - " + CodeList[i].BRANCH_DESC + ")"));
                        }
                    }
                    else
                    {
                        if (CodeList[i].CODE_ACTV_F.IsEqual("Y") || CodeList[i].BRANCH_CODE.Trim() == sitecode.Trim())
                        {
                            KeyValuePairList.Add(new KeyValuePair<string, string>(CodeList[i].BRANCH_CODE, CodeList[i].BRANCH_CODE + " - " + CodeList[i].BRANCH_DESC + ")"));
                        }
                    }
                }
 
Sort by date Sort by votes
Code: 
if (CodeList[i].CODE_ACTV_F.IsEqual("Y") || (CodeList[i].BRANCH_CODE.Trim() == sitecode.Trim() && IsUpdateMode))
{
    KeyValuePairList.Add(new KeyValuePair<string, string>(CodeList[i].BRANCH_CODE, CodeList[i].BRANCH_CODE + " - " + CodeList[i].BRANCH_DESC + ")"));
}[code]

That evaluates exactly the same way..

The only time CodeList[i].BRANCH_CODE.Trim() == sitecode.Trim() is only ever evaluated if IsUpdateMode is true and CodeList[i].CODE_ACTV_F.IsEquals("Y") is false... so this should do the same thing.
 
Upvote 0 Downvote
Take two on posting code...

Code: 
[COLOR=#0000FF][/color][COLOR=#0000FF][highlight #FFFFFF]if[/color][COLOR=#000000] (CodeList[i].CODE_ACTV_F.IsEqual([/color][COLOR=#A31515]"Y"[/color][COLOR=#000000]) || (CodeList[i].BRANCH_CODE.Trim() == sitecode.Trim() && IsUpdateMode))
{
    KeyValuePairList.Add([/color][COLOR=#0000FF]new[/color][COLOR=#000000] [/color][COLOR=#2B91AF]KeyValuePair[/color][COLOR=#000000]<[/color][COLOR=#0000FF]string[/color][COLOR=#000000], [/color][COLOR=#0000FF]string[/color][COLOR=#000000]>(CodeList[i].BRANCH_CODE, CodeList[i].BRANCH_CODE + [/color][COLOR=#A31515]" - "[/color][COLOR=#000000] + CodeList[i].BRANCH_DESC + [/color][COLOR=#A31515]")"[/color][COLOR=#000000]));
}[/color][/highlight]
 
Upvote 0 Downvote
Status
Not open for further replies.

Similar threads

xarzu
  • Locked
  • Question
What is the proper way to declare a Microsoft class to use in my code. The quick and dirty way I am doing it here, I know, is not correct
Replies
0
Views
2K
xarzu
xarzu
WomanPro
  • Locked
  • Question
Crystal report doesn't display all records of the datagridview but olny the last one.
Replies
1
Views
1K
hilfy
hilfy
WomanPro
  • Locked
  • Question
TextBox of user control NavigationBar gives flickering during reducting the height of the form.
Replies
0
Views
939
WomanPro
WomanPro
justhumm
  • Locked
  • Question
Error CS0161 not all code paths return a value 1
Replies
2
Views
1K
justhumm
justhumm
Mahesh6109
  • Locked
  • Question
Convert C# Code to C++
Replies
1
Views
408
xwb
xwb

Part and Inventory Search

Sponsor

Back
Top