×
INTELLIGENT WORK FORUMS
FOR COMPUTER PROFESSIONALS

Log In

Come Join Us!

Are you a
Computer / IT professional?
Join Tek-Tips Forums!
  • Talk With Other Members
  • Be Notified Of Responses
    To Your Posts
  • Keyword Search
  • One-Click Access To Your
    Favorite Forums
  • Automated Signatures
    On Your Posts
  • Best Of All, It's Free!
  • Students Click Here

*Tek-Tips's functionality depends on members receiving e-mail. By joining you are opting in to receive e-mail.

Posting Guidelines

Promoting, selling, recruiting, coursework and thesis posting is forbidden.

Students Click Here

Jobs

unless eq versus if ne

unless eq versus if ne

unless eq versus if ne

(OP)
I am having a problem with the following puzzle.
The first version works fine, the second fails.
Is there a way to successfully make the if version work?


CODE --> perl

unless ( $command eq "ViewRecords"
    || "InsertRecordGroupForm"
    || "UpdateRecordForm"
    || "InsertRecordGroup"
    || "UpdateRecord"
    || "ShowColumns"
    || "ShowTables" )
{
etc
} 

but this does not

CODE --> perl

if ( $command ne "ViewRecords"
    || "InsertRecordGroupForm"
    || "UpdateRecordForm"
    || "InsertRecordGroup"
    || "UpdateRecord"
    || "ShowColumns"
    || "ShowTables" )
{
etc
} 


RE: unless eq versus if ne

Hi

None of your conditions work as you probably expect. I would rewrite them as

CODE --> Perl

@list=qw{ViewRecords InsertRecordGroupForm UpdateRecordForm InsertRecordGroup UpdateRecord ShowColumns ShowTables};

# with grep
if (! grep {$_ eq $command} @list) {
  print "etc\n";
}

# with smartmatch operator
if (! ($command~~@list)) {
  print "etc\n";
} 

Feherke.
http://feherke.github.com/

RE: unless eq versus if ne

(OP)
Thanks, that looks good.
I picked up the book Perl Best Practices, which has inspired me to rewrite a lot of the junk that was in my code.
There were a lot of inefficient SQL tests I had that I have now simplified without loops or extra variables.
This change is to make the test for valid commands and then run them.

I also have some subroutines that work, but are brutally difficult to re-use for table additions/changes. I am now going to rewrite those for clarity when using.

Very good book!

Red Flag This Post

Please let us know here why this post is inappropriate. Reasons such as off-topic, duplicates, flames, illegal, vulgar, or students posting their homework.

Red Flag Submitted

Thank you for helping keep Tek-Tips Forums free from inappropriate posts.
The Tek-Tips staff will check this out and take appropriate action.

Reply To This Thread

Posting in the Tek-Tips forums is a member-only feature.

Click Here to join Tek-Tips and talk with other members!

Close Box

Join Tek-Tips® Today!

Join your peers on the Internet's largest technical computer professional community.
It's easy to join and it's free.

Here's Why Members Love Tek-Tips Forums:

Register now while it's still free!

Already a member? Close this window and log in.

Join Us             Close