WHAT IS WRONG WITH THIS SP????

[hinchdog]

I'm just getting started with sp's. I wrote one to loop through a table of administrators, find the current admin (the one whose admin_current column is true), set the status to false (admin_current=0), then move to the next record and set the status to true. I can't seem to get it to work. Could someone examine my code? Thanks.

CREATE PROC sp_ChangeAdmin
AS
BEGIN
DECLARE @ThisID INT
DECLARE @ThisCurrent VARCHAR(18) <--is this right??
DECLARE ThisAdmin CURSOR FOR
SELECT admin_id, admin_current
FROM admin

WHILE @@FETCH_STATUS = 0
BEGIN
FETCH NEXT FROM ThisAdmin INTO @ThisID, @ThisCurrent
IF @ThisCurrent = 1
BREAK
ELSE
CONTINUE
END
UPDATE admin SET admin_current = 0 WHERE admin_id = @ThisID
-- get the next record after admin
FETCH NEXT FROM ThisAdmin INTO @ThisID, @ThisCurrent
-- check if end of records
IF @@FETCH_STATUS = 2
FETCH FIRST FROM ThisAdmin INTO @ThisID, @ThisCurrent
UPDATE admin SET admin_current = 1 WHERE admin_id = @ThisID

CLOSE ThisAdmin
DEALLOCATE ThisAdmin
END

 

[hinchdog]

nevermind - i forgot to open the cursor. duh!