Uploading large files = problem

DarkJedi · Aug 10, 2000

Hey, I posted about making new directories and the mkdir thing worked out after setting everything up correctly to work with the mkdir.  However, when I try to upload (really it's just coping to another folder on my computer while I test it) it doesnt work.  Whenever I try to upload files over 1 meg, my HTML doc works very slowly then after a long time finishes working, yet the file has not been copied.  Smaller files however, work fine. Please help. Source code below. ----------------------- ## path to where files uploaded. $basedir = "c:/test"; ## allow all file types?  yes/no $allowall = "yes"; ## If the above = "no"; then which is the only extention to allow? $theext = ".txt"; ## The page to forward to when done: $donepage = "<A HREF="

http://127.0.0.1/cgi-bin/test.pl&quot"

TARGET="_new">

http://127.0.0.1/cgi-bin/test.pl&quot</A>;; use

CGI; $onnum = 1; while ($onnum != 11) { my $req = new CGI; my $file = $req->param("FILE$onnum&quot

; my $filedir = $req->param("filedir&quot

; if ($file ne "&quot

{ my $fileName = $file; $fileName =~ s!^.*(\\¦\/)!!; $newmain = $fileName; if ($allowall ne "yes&quot

{ if (lc(substr($newmain,length($newmain) - 4,4)) ne $theext){ $filenotgood = "yes"; } } if ($filenotgood ne "yes&quot

{ mkdir ("$basedir/$filedir",0777); open (OUTFILE, ">$basedir/$filedir/$fileName&quot

; print "$basedir/$fileName "; while (my $bytesread = read($file, my $buffer, 1024)) { print OUTFILE $buffer; } close (OUTFILE); } } $onnum++; } print "Content-type: text/html\n"; print "Location:$donepage\n\n";

tanderso · Aug 10, 2000

You set your buffer for one meg. while (my $bytesread = read($file, my $buffer, 1024)) Set it higher.  Eg: 2048 = 2 megs. Sincerely, <a href=mailto: > </a> <a href=

http://www.oac-design.com>Tom

Anderson</a> CEO, Order amid Chaos, Inc.

http://www.oac-design.com

MikeLacey · Aug 11, 2000

Tom, I think you may be mistaken there (or *I* might be <grin> it's happened before). Read() takes 4 arguments read FILEHANDLE,SCALAR,LENGTH[,OFFSET] OFFSET is optional, LENGTH is in bytes - not K FILEHANDLE -- not a string containing a filename DarkJedi's code looks mostly ok to me, the logic is fine. Read() will return zero when there's nothing to read and the last time it *does* return data when it's probably not going to be LENGTH bytes long it shrinks SCALAR to fit. Try replacing the line: while (my $bytesread = read($file, my $buffer, 1024)) { with: open(INFILE,$file) or die "can't open $file, $!\n"; while (my $bytesread = read(INFILE, my $buffer, 1024)) { Mike <a href=mailto:michael.j.lacey@ntlworld.com>michael.j.lacey@ntlworld.com</a> <a href=

http://www.cargill.com/>

Cargill's Corporate Web Site</a>

tanderso · Aug 11, 2000

Mike, I'm sure you're right.  But if that is not where the problem is, then it's surely another buffer problem.  It almost always is when moving files around.  I bet the buffer is in the CGI module.  I think there is a $cgi->setbuffer() function or something similar.  Try inserting this code to see what's happening:     my $error = $req->cgi_error;     if ($error)     { print $req->header(-status=>$error),       $req->start_html('Problems'),               $req->h2('Request not processed'),       $req->strong($error);         exit 0;     } Sincerely, <a href=mailto: > </a> <a href=

http://www.oac-design.com>Tom

Anderson</a> CEO, Order amid Chaos, Inc.

http://www.oac-design.com

goBoating · Aug 11, 2000

I experimented with it this morning a was able to upload a 7 meg tar file from my PC via a Netscape browser to a Sun box w/ Apache.  I'm not doing anything special.???? $newFile = 'someName'; open(OPF,">$newFile&quot

¦¦ &showError("Failed to open OPF, $!&quot

; while ($bytesread=read($fileID,$buffer,1024)) { print OPF "$buffer"; } 'even tried setting the LENGTH to 1, and it still worked..... <a href=mailto: > </a> <a href= > </a> keep the rudder amid ship and beware the odd typo

MikeLacey · Aug 12, 2000

DarkJedi -- you still having the problem? Mike <a href=mailto:michael.j.lacey@ntlworld.com>michael.j.lacey@ntlworld.com</a> <a href=

http://www.cargill.com/>

Cargill's Corporate Web Site</a>

DarkJedi · Aug 14, 2000

man this is frustrating.  I;ve tried everything that you all have suggested and I;m still getting zilch.  Wheverver I try to get it to work, my browser just chugs slowly along as I note the little progress bar growing ever so slowly closer to the right side of its range, until it finally does, the page redirects itself to the approprite finish page, yet the file has not been copied.  RRRggghhhhh.... Anymore ideas anyone?  I'm opting to strap an EMP greande to my HD and be donw with it.

DarkJedi · Aug 14, 2000

Ok, this is weird.  After waiting..... a good 2 - 3 minutes for my browser to finish doing whatever it was that it was doing, the file finished coping...... sort of.  I went to check my target dir and my 8.something meg file was there.... as a 1Kb file.  The filename and extension was intact but it was, well.... 1Kb.  Any ideas on what's going on there?   Just in case I happen to stump all of you, I'll be charging up a few capacitors and wrapping some more cu wire around my gren.

MikeLacey · Aug 14, 2000

DarkJedi, How are you setting $fileID? Mike <a href=mailto:michael.j.lacey@ntlworld.com>michael.j.lacey@ntlworld.com</a> <a href=

http://www.cargill.com/>

Cargill's Corporate Web Site</a>

tanderso · Aug 14, 2000

Did you get a return value for cgi_error?  What was it? Sincerely, <a href=mailto: > </a> <a href=

http://www.oac-design.com>Tom

Anderson</a> CEO, Order amid Chaos, Inc.

http://www.oac-design.com

DarkJedi · Aug 14, 2000

When you ask about my $FileID, do you mean that if the file I want is C:\blah.exe then $FIleID = "blah.exe"     Or do you mean that my $FIleID would be "C:\blah.exe"  b/c right now it is the latter and not the former. As for Tom's question, all that heppened when I added your code was that I got a 500 internal server error.  I didn't get any specific error msg other than that.

tanderso · Aug 14, 2000

I don't know why you'd get a 500 error, the syntax look OK.  Did you check your error_log? Sincerely, <a href=mailto: > </a> <a href=

http://www.oac-design.com>Tom

Anderson</a> CEO, Order amid Chaos, Inc.

http://www.oac-design.com

DarkJedi · Aug 14, 2000

I checked out my log and it basically said that there was a problem where I put your code.  I dunno what the hell is going on with this thing. [Mon Aug 14 10:54:23 2000] [error] [client 127.0.0.1] Can't call method "cgi_error" on an undefined value at c:/program files/apache group/apache/cgi-bin/psupload.cgi Thats the error in my error_log file. *frantically tears out own hair, then realizes he has a date tonight and frantically searches for a bottle of Rogain.* Methinks I'll just go watch the matrix for a while then come back to this....

tanderso · Aug 14, 2000

That code should go toward the end of your program, after you have declared $req and after you have had the problem.  By "undefined value" it sounds like $req hadn't been declared yet. Sincerely, <a href=mailto: > </a> <a href=

http://www.oac-design.com>Tom

Anderson</a> CEO, Order amid Chaos, Inc.

http://www.oac-design.com

DarkJedi · Aug 14, 2000

Yeah, I realized my error as soon as I posted my last message and I corrected that. I'm not getting any errors now, not in my error log or as a result of the $error function that we added to the script. I almost wish I was getting some errors, then I'd at lest have some idea why my 8 meg files are mysteriously shrinking to 1 k after talking 4 minutes to copy.  RRGghhh.

MikeLacey · Aug 14, 2000

What I mean about $FileID is that (and forgive me if I'm being stupid here) the first arugument to read() is supposed to be a file-handle, not a string containing a filename... What am I missing? Mike <a href=mailto:michael.j.lacey@ntlworld.com>michael.j.lacey@ntlworld.com</a> <a href=

http://www.cargill.com/>

Cargill's Corporate Web Site</a>

goBoating · Aug 15, 2000

Mike, I see what you are talking (writing) about.  The documentation for the 'read' function says it operates on a HANDLE, not a file name.   However, when using CGI.pm.. when you do this to create the upload input field ... print $query->filefield(-name=>'upload_file',             -size=>'50',             -maxlength=>'80'); ....the file name that is returned upon submission is also a file HANDLE........a little slight of hand on Mr. Stein's part, don't you think.  So, you are correct.  The 'read' does operate on a HANDLE, it just appears to be operating on a name. 'hope this helps... <a href=mailto: > </a> <a href= > </a> keep the rudder amid ship and beware the odd typo

MikeLacey · Aug 15, 2000

Doh! <bang><bang><bang> (sound of head hitting desk), it's been a long week already... Mike <a href=mailto:michael.j.lacey@ntlworld.com>michael.j.lacey@ntlworld.com</a> <a href=

http://www.cargill.com/>

Cargill's Corporate Web Site</a>

Tek-Tips is the largest IT community on the Internet today!

Members share and learn making Tek-Tips Forums the best source of peer-reviewed technical information on the Internet!

Uploading large files = problem

IS-IT--Management

IS-IT--Management

MIS

IS-IT--Management

Programmer

MIS

IS-IT--Management

IS-IT--Management

MIS

IS-IT--Management

IS-IT--Management

IS-IT--Management

IS-IT--Management

IS-IT--Management

IS-IT--Management

MIS

Programmer

MIS

Similar threads

Log in

Part and Inventory Search

Sponsor