Update via checkbox 3

[samflex]

I created an update code that would update a boolean data type ( access db true/false) data type.

So far, this pair of scripts work:

on edit.asp:

<tr>
<td>
<b><font color="ffffff">Printed: </font></b></td><td><input type="text" size="60" name="show" value="<%=RS("show")%>"></td>
</tr>

on update.asp:

Set RS = DataConnection.execute("UPDATE shows SET show= '" & fshow& "' where id =" ID)

This works well.

However, On the edit page, it dispays:
Show = True (or show = False) depending on the situation.

The client has decided that rather than see True or False, they just want to see a checkbox so they if they box is checked meaning True and they want to change the value to False, all they need to do is uncheck the box, click update and the database will be updated.

So far, when I uncheck a checked box and click update, I get an error.

Below is the code I am playing with.
Can I ask for your assistance, please?
Thanks in advance

	<%
	    IF trim(rs("show")) = "True" then
			Response.Write("<INPUT NAME='fshow' CHECKED TYPE=checkbox VALUE=" & rs("show") & " checked>
		ELSE
			Response.Write("<INPUT NAME='fshow' CHECKED TYPE=checkbox VALUE=" & rs("show") & " >
		END IF
	%>

 

[FesterSXS]

try this instead...

<%
If LCase(Trim(rs("show"))) = "true" Then
  strChecked = " CHECKED"
Else
  strChecked = ""
End If

Response.Write "<INPUT name='fshow' type='checkbox' value='" & Trim(rs("show")) & "'" & strChecked & ">"
%>

Tony
________________________________________________________________________________

http://www.SpiraxSarco.com

 

[samflex]

hi Tony,
I am still getting the same error I was getting with the code I posted.

Microsoft JET Database Engine (0x80040E14)
Syntax error in UPDATE statement.

 

[samflex]

I forgot to mention that the error occurs on my update code posted above.

With this code:

<tr>
<td>
<b><font color="ffffff">Printed: </font></b></td><td><input type="text" size="60" name="show" value="<%=RS("show")%>"></td>
</tr>

The update statement works but as I indicated earlier, it works with value = True rather checking and unchecking the checkbox.

 

[FateFirst]

I think thats because if you unselect a checkbox it doesnt pass through anything, so you may want to do a check on update page.

If LCase(Trim(request("fshow"))) = "true" Then
bShow = "True"
Else
bShow = "False"
End If

- FateFirst

 

[FateFirst]

oops..and then:

Set RS = DataConnection.execute("UPDATE shows SET show= '" & bShow & "' where id =" ID)

- FateFirst

 

[Tarwn]

One more problem:
If your value is originally false then there will be no way to turn it back true

Watch:
If you output your checkbox like so: Response.Write "<INPUT name='fshow' type='checkbox' value='" & Trim(rs("show")) & "'" & strChecked & ">"

Then when show is False the checkbox will have the value false. if it is then checked it will pass that False value to the next page, if it isn't checked it won't pass a value to the next page.

On the next page you have:
If LCase(Trim(request("fshow"))) = "true" Then
bShow = "True"
Else
bShow = "False"
End If

Whether or not you check that checkbox, an initial false value cannot be changed to true as both cases will end up in the else portion of your if statement.

The solution is rather simple, just remove the rs("show") from the checkbox value and pass a hard-coded value. if the value is passed then the box was checked, if no value was passed then it wasn't chcked:
Response.Write "<INPUT name='fshow' type='checkbox' value='True'" & strChecked & ">"

Now when the checkbox is checked it sends true, the rest of the time it doens't send anything. Your if statment will now work consistently and all is well

_{01000111 01101111 01110100 00100000 01000011 01101111 01100110 01100110 01100101 01100101 00111111}
Help, the rampaging, spear-waving, rabid network gnomes are after me!

 

[FateFirst]

very true...didnt notice that.

I assumed (yep..made an ass outta myself) that default value being used is true and only checked would be the changing value...guess I should read peoples posts in more detail.

- FateFirst

 

[samflex]

Great point Tarwn!

I was just coming back to say exactly that even though it works when you uncheck a box, it doesn't work when you attempt to check the box.

No Tarwn, I have tried your solution,
It is still not checking the box when you attempt to update the database by checking a previously unchecked box.

I just love you guys understanding of asp.

 

[FateFirst]

Tarwns solutions should work.

EDIT PAGE

<%
If lcase(Trim(RS("show"))) = "true" then
	strChecked = " checked"
Else
	strChecked = ""
End If
%>
<INPUT name="fshow" type="checkbox" value="True"<%=strChecked%>>

UPDATE PAGE

<%
If LCase(Trim(request("fshow"))) = "true" Then
  bShow = "True"
Else
  bShow = "False"
End If

Set RS = DataConnection.execute("UPDATE shows SET show= '" & bShow & "' where id =" ID)
%>

- FateFirst

 

[samflex]

Thanks to both of you again for all the assistance.

If I use the code with single quotes like this:

'"&bShow&"' I get this error:

Microsoft JET Database Engine (0x80040E07)
Data type mismatch in criteria expression.

If I use it without the single quotes like this:

"&bShow&" it will uncheck the box but will not check it.

As usual, I must be doing something wrong.

I am using exactly you guys code, nothing was changed.

 

[DreXor]

more than likely your db environment will store T/F as True False OR 1 and 0 .. try removing the quotes and changing the true to 1 and false to zero and see if you still get errors.

DreX
aKa - Robert

 

[Tarwn]

Double-check in your database that the field is definately set for True/false, not Yes/No or something like that.

-T

_{01000111 01101111 01110100 00100000 01000011 01101111 01100110 01100110 01100101 01100101 00111111}
Help, the rampaging, spear-waving, rabid network gnomes are after me!

 

[samflex]

It is working now.

Thanks Tarwn as usual for not only coming up with solutions but explaining the problems and possible solutions.
Your style makes asp very easy to understand.

DreXor, thanks for your input.

Most of all, special thanks to FateFirst for coming up with the original code.

 

[FateFirst]

hrmm

on the edit page can you write:

response.write("<b>" & RS("show") & "</b>")

put it before the code that reads:

If lcase(Trim(RS("show"))) = "true" then
    strChecked = " checked"
Else
    strChecked = ""
End If

then tell me what you get back

- FateFirst

 

[FateFirst]

damnit...you guys are too fast...i was just getting to that..hehe

- FateFirst

 

[Tarwn]

Fate:
Challenge a couple DreamWeaver "specialists" to see who can create the more colid app in the least amunt of time, that'll speed you up a bit

Sam: Glad we were able to be of assistance, group hug time

Drex: Good call, I think that would work without the change to True/False in the DB, believe I remember that working for true/false, yes/No, etc. ...But I still like my answer better

_{01000111 01101111 01110100 00100000 01000011 01101111 01100110 01100110 01100101 01100101 00111111}
Help, the rampaging, spear-waving, rabid network gnomes are after me!

 

[FateFirst]

I know this is off-topic, so sorry, but is anyone else have slight issues with tek-tips being unavailable sometimes.

- FateFirst

 

[DreXor]

of course we have, we just dont talk about it *shhh* the tek gods might become angry

DreX
aKa - Robert

 

[Tarwn]

They are still working on the upgrades to the site, so you may see some oddities now and then, especially when they mke changes to major portions of the stylesheets, etc.

-T

_{01000111 01101111 01110100 00100000 01000011 01101111 01100110 01100110 01100101 01100101 00111111}
Help, the rampaging, spear-waving, rabid network gnomes are after me!