$ SUBSTITUTION NOT BEING DONE

[madaxe2]

I HAVE A PIECE OF CODE FOR READING A TEXT FILE AND EXTRACTING INFO BUT THE SCRIPT IS BEING SENT A URL POST I.E

<a href="lookatthread.cgi?link=March-27-2005+CGI IS NOT LOGICAL+33">

THIS TELLS MY SCRIPT WHICH FILE TO GO AND READ THE NEXT STEP IS

if ($ENV{'REQUEST_METHOD'} eq 'GET')
{
    @pairs = split(/&/, $ENV{'QUERY_STRING'});
}
else
{
	read(STDIN, $buffer, $ENV{'CONTENT_LENGTH'});
	@pairs = split(/&/, $buffer);
}	
foreach $pair (@pairs) 
{
	($name, $value) = split(/=/, $pair);
	$value =~ tr/+/ /;
	$value =~ s/%([a-fA-F0-9][a-fA-F0-9])/pack("C", hex($1))/eg;
	$FORM{$name} = $value;	
}


my $link = $FORM{link};

my $dbdata = "../Logs/FORUMPOSTS/$link.cgi";

I KNOW THE URL POST IS BEING EXTRACTED I PRINTED THIS TO SCREEN TO CHECK.

ALL MY TEXT FILES HAVE THE EXTENSION .cgi FOR SECURITY.

THE NEXT PART OF MY SCRIPT IS

open(INF,"$dbdata") or &dienice("$dbdata: $! \n");
flock(INF, LOCK_SH);    # shared lock
seek(INF, 0, SEEK_SET); # rewind to beginning
my(@data) = <INF>;
close(INF);

ITS AT THIS POINT I KNOW THE SUBSTITUTION IS NOT WORKING AS IT COMPLAINS THAT THE SUBROUTEEN DOES NOT EXIST AS I HAVE NOT ADDED IT YET SO OBVIOUSLY IT CANT FIND THE FILE TO READ.

HOWEVER THIS DOES NOT WORK ---- BUT WHEN I DO THE SUBSTITUTION MY SELF IE CHANGE "$link" FOR "March-27-2005+CGI IS NOT LOGICAL+33" WHICH IN THIS CASE IS WHAT "$link" SHOULD EQUAL IT WORKS

WHY IS THIS SUBSTITUTION NOT WORKING.

MADAXE

 

[KevinADC]

use CGI.pm, do not use that method of parsing your form data. CGI.pm also has some built in security features you should take advantage of. Read the CGI.pm documents for details or ask more questions.

 

[madaxe2]

WHAT IS CGI.pm

MADAXE

 

[KevinADC]

CGI.pm is pretty much the standard for fetching form data from web forms:

http://search.cpan.org/~lds/CGI.pm-3.05/CGI.pm

it has many options and features or can be used in its simplest form to just fetch form data into your perl scripts.