Strange difficulty adding info to MYSQL

fishspan · Nov 25, 2003

Hi,

I have what seems to be a strange problem. I have an online form that works fine as long as I don't have the command in my script:

ACTION=MembershipConfirmation.php

If I take this single command out, all of my data enters my database no problem. But add it in....nothing.

Strangest thing is: It does lilnk to /membershipconfirmation.php upon submission of the form when this command is included. The data simply doesn't enter the database.

Any suggestions??? I'm assuming that it must be a really simple, stupid problem, but for the life of me I can't figure it out.

Thanks,
Matt

Bastien · Nov 26, 2003

show the code that creates the form...there might be an issue with quotes or something else...let us have alook

Bastien

Any one have a techie job in Toronto, I need to work...being laid off sucks!

fishspan · Nov 26, 2003

Hey Bastien - I'm in Toronto too.

Here's the form code. I apologize for its relative mess: blame Frontpage. I'm a relative newbie who felt Frontpage would make my life easier. The code is now a Frontpage hybrid, because I've begun trying to add my own code to it....I'm beginning to see the light.

Again, the problem is that when I add ACTION=membershipconfirmation.php to the code, the link to this page works...but the membership form doesn't enter my MySql database.

# connect to database
$cid = mysql_connect($host,$usr,$pwd);
if (!$cid) { echo("ERROR: " . mysql_error() . "\n&quot

; }

?>
<HTML>
<HEAD>
<TITLE>Membership Form</TITLE>

</HEAD>

<?
# this is processed when the form is submitted
# back on to this page (POST METHOD)
if ($REQUEST_METHOD=="POST&quot

{

# double-up apostrophes
$description = str_replace("'","''",$description);
$sitename = str_replace("'","''",$sitename);

# setup SQL statement
$SQL = " INSERT INTO Members ";
$SQL = $SQL . " (firstname, lastname, address1, address2, city, province, postalcode, home, work, email, gender, age, height, weight, hair, eye, smoker, children, status, religion, reason, samereligion, wantnosmoker, wantother, how_heard ) VALUES ";
$SQL = $SQL . " ('$firstname', '$lastname','$address1','$address2', '$city', '$province', '$postalcode', '$home', '$work', '$email', '$gender', '$age', '$height', '$weight', '$hair', '$eye', '$smoker', '$children', '$status', '$religion', '$reason', '$samereligion', '$wantnosmoker', '$wantother', '$how_heard') ";

#execute SQL statement
$result = mysql_db_query($db,"$SQL",$cid);

# check for error
if (!$result) { echo("ERROR: " . mysql_error() . "\n$SQL\n&quot

; }

}

?>
<form method="POST" ACTION=MembershipConfirmation.php>
<table border="0" cellpadding="0" cellspacing="0" style="border-collapse: collapse; line-height: 100%" bordercolor="#111111" width="103%" id="AutoNumber1" height="40">
<tr>
<td width="25%" height="15"></td>
<td width="79%" height="15"><b>
<font face="Verdana" color="#C0C0C0" style="font-size: 9pt"> 
</font></b>
<p style="margin-top: 6; margin-bottom: 6"><b><font face="Verdana" style="font-size: 9pt" color="#C0C0C0">&nbsp
</font></b></p>
<p style="margin-top: 6; margin-bottom: 6"><b>
<font face="Verdana" style="font-size: 9pt" color="#C0C0C0">&nbsp

First Name</font><font face="Verdana" color="#C0C0C0"><span style="font-size: 9pt">:</span></font></b><font face="Verdana"><b><font color="#C0C0C0"><span style="font-size: 9pt">        
<input type="text" name="firstname" size="18"></span></font><font color="#C0C0C0" style="font-size: 9pt">   

Last Name:   
<input type="text" name="lastname" size="21"></font></b></font></td>
</tr>
<tr>
<td width="25%" height="16"></td>
<td width="79%" height="16"></p>
<p style="margin-top: 6; margin-bottom: 6">  <b>
<font face="Verdana" color="#C0C0C0" style="font-size: 9pt">   Street

Address:</font></b><font face="Verdana" color="#C0C0C0"><b><span style="font-size: 9pt"> 
<input type="text" name="address1" size="61"></span></b></font></td>
</tr>
<tr>
<td width="25%" height="16"></td>
<td width="79%" height="16"></p>
<p style="margin-top: 6; margin-bottom: 6">  <b>
<font face="Verdana" color="#C0C0C0" style="font-size: 9pt">  

City: 
<input type="text" name="city" size="11"></font><font face="Verdana" size="2" color="#C0C0C0" style="font-size: 9pt">  

Province: <select size="1" name="province">
<option>BC</option>
<option>ON</option>
<option>QC</option>
</select>  
Postal Code:  
<input type="text" name="postalcode" size="7"></font></b></p>
<p style="margin-top: 6; margin-bottom: 6"><b>
<font face="Verdana" color="#C0C0C0" style="font-size: 9pt"> 
<input type="text" name="home" size="16"></font><font face="Verdana" size="2" color="#C0C0C0" style="font-size: 9pt">    Work

Phone:  <input type="text" name="work" size="22"></font></b></td>
</tr>
<tr>
<td width="25%" height="16"></td>
<td width="79%" height="16">
<p style="margin-top: 6; margin-bottom: 6">  <b>
<font face="Verdana" color="#C0C0C0" style="font-size: 9pt">  
Email:                 
<input type="text" name="email" size="60"></font></td>
</tr>
<tr>
<td width="25%" height="16"></td>
<td width="79%" height="16"><![if !vml]><span style='mso-ignore:vglayout;position:
absolute;z-index:1;left:230px;top:908px;width:282px;height:47px'><img
width=282 height=47 src="new_page_1_files/image023.gif" v:shapes="_x0000_s1120"></span><![endif]><![if !vml]><span style='mso-ignore:vglayout;position:
absolute;z-index:1;left:228px;top:570px;width:220px;height:47px'><img
width=220 height=47 src="new_page_1_files/image024.gif" v:shapes="_x0000_s1121"></span><![endif]></td>
</tr>
</table>
<p> </p>
<table border="0" cellpadding="0" cellspacing="0" style="border-collapse: collapse" bordercolor="#111111" width="115%" id="AutoNumber2" height="88">
<tr>
<td width="22%" valign="top" height="26"> </td>
<td width="78%" valign="top" height="26" colspan="2"> </td>
</tr>
<tr>
<td width="22%" valign="top" height="22"> </td>
<td width="78%" valign="top" height="22" colspan="2"><b>
<font face="Verdana" color="#C0C0C0" style="font-size: 9pt">Gender: 
<input type="radio" value="Male" name="gender" checked> Male  
<input type="radio" name="gender" value="Female"></font><font face="Verdana" size="2" color="#C0C0C0" style="font-size: 9pt"> Female                         Age:   <select size="1" name="age">
<option>20</option>
<option>21</option>
<option>22</option>
<option>23</option>
<option>24</option>
<option>25</option>
<option>26</option>
<option>27</option>
<option>28</option>
<option>29</option>
<option>30</option>
<option>31</option>
<option>32</option>
<option>33</option>
<option>34</option>
<option>35</option>
<option>36</option>
<option>37</option>
<option>38</option>
<option>39</option>
<option>40</option>
<option>41</option>
<option>42</option>
<option>43</option>
<option>44</option>
<option>45</option>
<option>46</option>
<option>47</option>
<option>48</option>
<option>49</option>
<option>50</option>
<option>51</option>
<option>52</option>
<option>53</option>
<option>54</option>
<option>55</option>
<option>56</option>
<option>57</option>
<option>58</option>
<option>59</option>
<option>60</option>
<option>61</option>
<option>62</option>
<option>63</option>
<option>64</option>
<option>65</option>
</select><font face="Verdana" size="2" color="#C0C0C0" style="font-size: 8pt">           
</font>
</font></b></td>
</tr>
<tr>
<td width="22%" valign="top" height="19"> </td>
<td width="78%" valign="top" height="19" colspan="2"><b>
<font face="Verdana" color="#C0C0C0" style="font-size: 9pt">                                                         
</font></b></td>
</tr>
<tr>
<td width="22%" valign="top" height="22"> </td>
<td width="78%" valign="top" height="22" colspan="2">
<p style="margin-top: 2; margin-bottom: 2"><b>
<font face="Verdana" color="#C0C0C0" style="font-size: 9pt">Height:  
<select size="1" name="height">
<option>>5'0"</option>
<option>5'4"-5'6"</option>
<option>5'7"-5'9"</option>
<option>5'10"-6'0"</option>
<option>6'1"-6'3"</option>
<option>6'3"-6'5"</option>
<option>>6'5"</option>
<option>5'1"-5'3"</option>
</select>                                      
Eye:  <select size="1" name="eye">
<option>Brown</option>
<option>Blue</option>
<option>Green</option>
<option>Hazel</option>
<option>Grey</option>
<option>Other</option>
</select>      
</font></b></td>
</tr>
<tr>
<td width="22%" valign="top" height="22"> </td>
<td width="78%" valign="top" height="22" colspan="2">
<p style="margin-top: 2; margin-bottom: 2"><b>
<font face="Verdana" color="#C0C0C0" style="font-size: 9pt">Weight: 
<select size="1" name="weight">
<option><100 lbs</option>
<option>100lbs - 110lbs</option>
<option>111lbs - 120lbs</option>
<option>121lbs - 130lbs</option>
<option>131lbs - 140lbs</option>
<option>141lbs - 150lbs</option>
<option>151lbs - 160lbs</option>
<option>161lbs - 170lbs</option>
<option>171lbs - 180lbs</option>
<option>181lbs - 190lbs</option>
<option>191lbs - 200lbs</option>
<option>201lbs - 210lbs</option>
<option>211lbs - 220lbs</option>
<option>221lbs - 230lbs</option>
<option>231lbs-240lbs</option>
<option>241lbs - 250lbs</option>
<option>>250lbs</option>
</select>                              
Hair Colour:  <select size="1" name="hair">
<option>Brown</option>
<option>Black</option>
<option>Blonde</option>
<option>Red</option>
<option>None</option>
<option>Other</option>
</select>  
<tr>
<td width="22%" valign="top" height="23"> </td>
<td width="78%" valign="top" height="23" colspan="2">
<p style="margin-top: 2; margin-bottom: 2"><b>
<font face="Verdana" color="#C0C0C0" style="font-size: 9pt">Do you smoke?            
<input type="radio" name="smoker" value="Yes">Yes  
<input type="radio" name="smoker" value="No">No</font></b></td>
</tr>
<tr>
<td width="22%" valign="top" height="22"> </td>
<td width="78%" valign="top" height="22" colspan="2">
<p style="margin-top: 2; margin-bottom: 2"><b>
<font face="Verdana" color="#C0C0C0" style="font-size: 9pt">Do you have children? 
<input type="radio" name="children" value="Yes">Yes  
<input type="radio" name="children" value="No">No
</font>
</b></td>
</tr>
<tr>
<td width="22%" valign="top" height="20"> </td>
<td width="78%" valign="top" height="20" colspan="2">
<p style="margin-top: 2; margin-bottom: 2"><b>
<font face="Verdana" color="#C0C0C0" style="font-size: 9pt">What is your
marital status?    <select size="1" name="status">
<option>Single</option>
<option>Separated</option>
<option>Divorced</option>
</select></font><font face="Verdana" color="#C0C0C0" style="font-size: 9pt" size="2"> </font></b></td>
</tr>
<tr>
<td width="22%" valign="top" height="22"> </td>
<td width="78%" valign="top" height="22" colspan="2">
<p style="margin-top: 2; margin-bottom: 2"><b>
<font face="Verdana" color="#C0C0C0" style="font-size: 9pt">What is your
religion?               
<select size="1" name="religion">
<option>Catholic</option>
<option>Christian</option>
<option>Jewish</option>
<option>Muslim</option>
<option>Hindu</option>
<option>Asian</option>
<option>Native American</option>
<option>Other</option>
</select></font><font face="Verdana" color="#C0C0C0" style="font-size: 9pt" size="2">   </font></b></td>
</tr>
<tr>
<td width="22%" valign="top" height="22"> </td>
<td width="78%" valign="top" height="22" colspan="2"> </td>
</tr>
<tr>
<td width="22%" valign="top" height="22"> </td>
<td width="23%" valign="top" height="22"><b>
<font face="Verdana" color="#C0C0C0" style="font-size: 9pt">What is your main
reason for trying out our service? </font></b></td>
<td width="71%" valign="top" height="22"><b>
<font face="Verdana" color="#C0C0C0" style="font-size: 9pt">         <select size="1" name="reason">
<option>To make new friends</option>
<option>To try to find a romantic partner</option>
<option>To increase my social circle</option>
<option>Just to have some fun</option>
<option>Pure curiosity</option>
<option>Other</option>
</select></font></b></td>
</tr>
<tr>
<td width="22%" valign="top" height="22"> </td>
<td width="23%" valign="top" height="22"> </td>
<td width="71%" valign="top" height="22"> </td>
</tr>
</table>
<p> </p>
<table border="0" cellpadding="0" cellspacing="0" style="border-collapse: collapse" bordercolor="#111111" width="100%" id="AutoNumber3" height="41">
<tr>
<td width="25%" height="20"> </td>
<td width="28%" height="20"><b>
<font face="Verdana" color="#C0C0C0" style="font-size: 9pt">
Someone from your own religion?
</font></b></td>
<td width="47%" height="20"><b>
<font face="Verdana" color="#C0C0C0" style="font-size: 9pt"> 
<input type="radio" name="samereligion" value="Yes">Yes   
<input type="radio" name="samereligion" value="No">No   
<input type="radio" name="samereligion" value="Doesn't Matter" size="20">Doesn't matter</font></b></td>
</tr>
<tr>
<td width="25%" height="20"> </td>
<td width="28%" height="20"><b>
<font face="Verdana" color="#C0C0C0" style="font-size: 9pt">
A non-smoker?                                       
</font></b></td>
<td width="47%" height="20"><b>
<font face="Verdana" color="#C0C0C0" style="font-size: 9pt"> 
<input type="radio" name="wantnosmoker" value="Yes">Yes   
<input type="radio" name="wantnosmoker" value="No">No   
<input type="radio" name="wantnosmoker" value="Doesn't Matter">Doesn't matter</font></b></td>
</tr>
<tr>
<td width="25%" height="21"> </td>
<td width="28%" height="21"> </td>
<td width="47%" height="21"> </td>
</tr>
<tr>
<td width="25%" height="5"></td>
<td width="28%" height="5"><b>
<font face="Verdana" color="#C0C0C0" style="font-size: 9pt">Do you have any other
special characteristics you are looking for?</font></b><span style="font-size: 9pt"><![if !vml]><span
style='mso-ignore:vglayout;position:absolute;z-index:-6;left:13px;top:31px;
width:768px;height:1299px'><img width=768 height=1299
src="new_page_1_files/image025.gif" v:shapes="_x0000_s1123"></span><![endif]></span></td>
<td width="47%" height="5"><b>
<font face="Verdana" color="#C0C0C0" style="font-size: 9pt">   
<textarea rows="2" name="other" cols="20"></textarea></font></b></td>
</tr>
<tr>
<td width="25%" height="15"></td>
<td width="28%" height="15"></td>
<td width="47%" height="15"></td>
</tr>
<tr>
<td width="25%" height="8"></td>
<td width="28%" height="8"></td>
<td width="47%" height="8"></td>
</tr>
<tr>
<td width="25%" height="36"> </td>
<td width="28%" height="36"> </td
<td width="44%" height="6"> </td>
</tr>
<tr>
<td width="25%" height="1"></td>
<td width="28%" height="1"></td>
<td width="47%" height="1"></td>
</tr>
</table>
<p><![if !vml]><span style='mso-ignore:vglayout;position:
absolute;z-index:3;left:254px;top:1073px;width:643px;height:79px'><img
width=643 height=79 src="new_page_1_files/image026.gif" v:shapes="_x0000_s1117"></span><![endif]><span style="font-size: 9pt"></span></p>
<table border="0" cellpadding="0" cellspacing="0" style="border-collapse: collapse" bordercolor="#111111" width="109%" id="AutoNumber4" height="68">
<tr>
<td width="23%" height="49"> </td>
<td width="30%" height="49"><b>
<font face="Verdana" color="#C0C0C0" style="font-size: 9pt">Lastly, please let us
know how you heard about us:   </font></b>
</td>
<td width="57%" height="49">
<span style="font-size: 9pt">  
<select size="1" name="how_heard">
<option>From a friend</option>
<option>From a family member</option>
<option>A flyer at my gym</option>
<option>A flyer, but not at my gym</option>
<option>Toronto Star</option>
<option>Toronto Sun</option>
<option>Globe and Mail</option>
<option>Metro Today</option>
<option>Eye Magazine</option>
<option>Now Magazine</option>
<option>Other</option>
</select></span></td>
</tr>

</table>
<p>                                                      
             <input type="submit" value="That's it. Click here to submit your membership" name="B2"></p>
</form>

Bastien · Nov 26, 2003

Remind me again why i hate FP, oh yeah, the above is why

Here the problem(s) are:
1. that the code to insert is done before the form is shown
2. you are not using $_POST/$_GET to access the form variables. You may have register_globals on, which is why you are not using/required to use $_POST/$_GET, but for future proofing, its best to make the switch now

Solution
1. use functions to separate out the pieces of the page. This will allow you to add functionality later and makes it easier to follow as all items related in in a function together

ex. (for this to work, please add the name="submit" attribute to the submit button, required for the initial control flow)

Code:

<?
//main code
//
if ($_POST['submit']){
     //the above checks to see if the submit button has been pressed
     //if yes, call the insert function
     do_insert();
}else{
     //submit not pressed so show form
     show_form();
}//end if
//end main code block

function do_insert()
{
   //your code to do the insert here
   //note: you show all the input elements to variables and test them to see if they are correct for input, don't forget to use $_POST or $_GET

}//end function

function show_form()
{
   //all the code for the form here
   //simply cut and paste the code in here
?>
<!--#Code here-->

<?
}//end function

?>

Bastien

Any one have a techie job in Toronto, I need to work...being laid off sucks!

fishspan · Nov 26, 2003

Thanks Bastien,

I'm getting pretty frustrated here though: interested in a little project? I'm just about ready to outsource as I just don't have any more time to waste fiddling around with it. Cost permitting, of course...as I was fiddling in the first place to save myself some cash!

I don't believe it's a terribly large project: Email me at matthew@psych.utoronto.ca if you're interested, and we can discuss.

Cheers,
Matt

Tek-Tips is the largest IT community on the Internet today!

Members share and learn making Tek-Tips Forums the best source of peer-reviewed technical information on the Internet!

Strange difficulty adding info to MYSQL

fishspan

Technical User

Bastien

Programmer

fishspan

Technical User

Bastien

Programmer

fishspan

Technical User

Similar threads

Part and Inventory Search

Sponsor