Replace function 1

[kathyc20]

I have the following code and would like to do a global replace of chars in a string but it only replaces the first occurrence. How do I get it to replace all occurrences?


sBadChars[0] = "+";
sBadChars[1] = "%2B";
sBadChars[2] = "%20";
sBadChars[3] = "%2520";
sBadChars[4] = "%22";

for (iCount = 0; iCount < sBadChars.length; iCount++)
{
iFound = sTemp.indexOf(sBadChars[iCount])

if (iFound > -1)
{
sFinal = sTemp.replace(sBadChars[iCount], " ");
}
}

return sFinal;

 

[theniteowl]

Your loop only loops through each array element.
indexOf only finds the first instance of the item so I setup a while loop that will continue performing the replace of that text until none remain then it loops to your next array element.

Note that it is now returning sTemp not sFinal. The way it was setup sTemp would never get updated, only sFinal so every iteration of the loop it would be starting over with the original sTemp string and you would never get anywhere.

for (iCount = 0; iCount < sBadChars.length; iCount++)
{
  while (sTemp.indexOf(sBadChars[iCount]) != -1)
  {
    sTemp = sTemp.replace(sBadChars[iCount], " ");
  }
  return sTemp;
}

Google, you're my hero!

 

[tsuji]

An alternative is this.
[tt]
var rx=new RegExp("(\\"+sBadChars.join("|\\")+")","g");
return sTemp.replace(rx," ");
[/tt]
It looks general, but actually, it is not as general as it looks. It is based on some data made known to scripter on the what appears in sBadChars.

 

[theniteowl]

Nice one tsuji.

Google, you're my hero!