RegEx Woes 3

[1DMF]

I can't seem to get the syntax right on this regex

my $var =~ s/['\@\\\/=?]//g;

I want to replace the following characters with nothing
' @ \ / = ?

thanks 1DMF

"In complete darkness we are all the same, only our knowledge and wisdom separates us, don't let your eyes deceive you.

 

[AMiSM]

Brackets around charactors mean to match one or more of the charactors in the brackets, in any position or sequence.

Try this:

my $var = "abc'\@\\\/=?xyz";
$var =~ s/'\@\\\/=\?//g;

print "$var\n";

 

[AMiSM]

Correction, brackets mean to match ONE of the charactors.

 

[ishnid]

Don't use `my' in the regexp line or it tries to redeclare $var. If you've warnings enabled, it should complain about that. The regexp itself is fine (though there's no need to escape the @ symbol).

Another (more efficient) way of doing that:

$var =~ tr/'@\\\/=?//d;

 

[AMiSM]

Oh, the charactors individually, not the string? I don't think you need to escape charactors inside brackets.
Sorry, I'm really out of it today.

 

[1DMF]

hey ishnid, i wasn't actual declaring the var with my it was a habit when posting to always put my, stops the moaning about not using strict and declaring vars ;-) (which I 100% now do) I even find myself writing 'my' when posting in the JavaScript or other forums, it's that engrained now - lol

the actual reason I was not getting a match was a stupid school boy error, the regex works fine!

I was doing this...

my $userid = $cgi->param('userid');
$userid =~ s/['\@\\\/\=?]//g;
if($userid ne $cgi->param('userid')){
    $msg .= "UserID : ('@\\/=?) not allowed.<br />";
}

but the dumb ass that I am forgot the form has <input name="USERID"> d'oh!

that's why it didn't work, got the case wrong - lol , but have a star anyway!

"In complete darkness we are all the same, only our knowledge and wisdom separates us, don't let your eyes deceive you.

 

[KevinADC]

seems like an unusual way to go about that, this is a more straight forward approach:

my $userid = $cgi->param('userid');
if ($userid =~ /['@\\\/=?]/;){
    $msg .= "UserID : ('@\\/=?) not allowed.<br />";
}

but that still leaves plenty of non alpha-numeric characters that can be included.

 

[KevinADC]

oops, that ';' shouldn't be in this line:

if ($userid =~ /['@\\\/=?]/;){

should be:

if ($userid =~ /['@\\\/=?]/){

 

[1DMF]

You just woke up Kevin?, how does that meet my requesite

I want to replace the following characters with nothing ' @ \ / = ?

and you can't run a replace/substitute on $cgi as it is read only, so why is my method strange?





"In complete darkness we are all the same, only our knowledge and wisdom separates us, don't let your eyes deceive you.

 

[KevinADC]

it's unusual in the context of the code you posted:

if($userid ne $cgi->param('userid')){
    $msg .= "UserID : ('@\\/=?) not allowed.<br />";
}

but it might make perfect sense in the overall script.

 

[1DMF]

it's a post back to an AJAX JavaScript call, complaining about invalid submision and removing it at the same time!

"In complete darkness we are all the same, only our knowledge and wisdom separates us, don't let your eyes deceive you.

 

[ishnid]

'my' with JavaScript - bet that confuses the people on *that* forum. Glad you got it sorted. Cheers for the star.

 

[1DMF]

I sometimes catch myself before actualy submitting, what the JS forum doesn't do though is moan at you for not using var variablename = "xyz"; , so i've learnt to be a better PERL coder than JS thanks to you guys

"In complete darkness we are all the same, only our knowledge and wisdom separates us, don't let your eyes deceive you.

 

[1DMF]

i gave your example a try Kevin as I decided not to replace the chars and simply just flag up the invalid chars but your code doesn't work.

why does a substitute work but not a match using the same regex?

"In complete darkness we are all the same, only our knowledge and wisdom separates us, don't let your eyes deceive you.

 

[KevinADC]

the code will find the invalid characters, for example:

my $userid = 'foo@bar';
if ($userid =~ /['@\\\/=?]/){
    print "UserID : ('@\\/=?) not allowed.<br />";
}
else {
   print "UserID is OK.<br />";
}

 

[1DMF]

agh it must have been because I was using the CGI->param object the match didn't work as i was doing..

if ($cgi->param('userid') =~ /['@\\\/=?]/){
    print "UserID : ('@\\/=?) not allowed.<br />";
}

It was always true with this, do i need $$cgi->param('userid') or can i not use the $cgi object with a match in this manner ?


"In complete darkness we are all the same, only our knowledge and wisdom separates us, don't let your eyes deceive you.

 

[KevinADC]

>> or can i not use the $cgi object with a match in this manner

No you can't because that is a reference to the cgi object, you have to dereference it first.