regex question

[dmazzini]

Regex Question

I have different valid Radio Frequency Modules Type:FRGA,FRIA,FREA,FRCA,FRDA,FRFA and FRGC

 if  ($module =~ /FR(G|I|E|C|D|F)A/)  # This regex covers FRGA,FRIA,FREA,FRCA,FRDA and FRFA

Now, I want to match module FRGC within regex, is it possible or I have to add "or" condition ?

Testing it

if  ($module =~ /FR(G|I|E|C|D|F)A|C/). # This regex works but it could give me non-valid RF module. e.g FRCC would pass.

Any advices?

dmazzini
GSM/UMTS System and Telecomm Consultant

 

[dmazzini]

Sorted guys

if  ($module =~ /FR(GA|IA|EA|CA|DA|FA|GC)/) 

[code]

Opps!

dmazzini
GSM/UMTS System and Telecomm Consultant

 

[ishnid]

When you find yourself using the | operator for single-character options, you should be using a character class. If I were to do this with a regexp (though I'd personally prefer to use a hash of valid values, which makes it more extensible in future), I'd do:

 if  ($module =~ /FR[GIECDF]A|FRGC/)