Question 3

PhoenixDown · Jul 11, 2001

I'm making a variable database file (I was going to use hash format) which will store data like:

somthing|somthing|somthing|somthing

How do I take the content between the pipes?

http://www.puremadnezz.com/

- Go there!

PhoenixDown · Jul 13, 2001

I have another problem. :-(

Here is what my sub routine looks like:

sub get_entries {

open(DATA,"<$vars_gen{'CGIPath'}/variables/vars_entries.cgi&quot

or die ("Unable to open guestbook entry file.&quot

;
@line = <DATA>;
close(DATA);
foreach $line (@line) {
$line =~ s/\n//g;
($var1,$var2,$var3,$var4,$var5,$var6,$var7,$var8,$var9,$var10,$var11,$var12,$var13,$var14,$var15) = split(/\|/,$line);

if ( $var1 !~ /[a-zA-Z0-9]+/) {
$Field1 = "<tr bgcolor=\"$vars_styles{'AltColor1'}\"><td width=35% valign=top><FONT SIZE=\"2\" FACE=\"$vars_styles{'FontFace'}\"><B>$var1</b></font><BR><BR></font></td>";
} else {
$Field1 = "";
}

print<<THIS;
<table border=0 cellpadding=0 cellspacing=0 width="$vars_styles{'TableWidth'}"><TR><td bgcolor="$vars_gen{'TableBorderColor'}">
<table border=0 cellpadding=4 border=0 cellspacing=1 width=100%>
<TR bgcolor="$vars_styles{'TableHeaderStripBackgroundColor'}"><TD align=center colspan=2>
<FONT SIZE="$vars_styles{'TextSize'}" FACE="$vars_styles{'FontFace'}" COLOR="$vars_styles{'TableHeaderStripTextColor'}"><B>Guestbook Entries</B></FONT>
</td></tr>
$Field1
</table>
THIS

}
exit;

}

When I go to the gb.cgi file, the web page looks like:

If that image doesn't work, go to:

http://www.puremadnezz.com/gb.gif

Please tell me what's wrong.

Also here is the sub where I call the entries file in case someone wants to see it:

sub intro {

$Copyright = &Copyright;

print<<THIS;

<HTML>
<HEAD>
<TITLE>Guestbook</TITLE>
$vars_gen{'Header'}
</HEAD>
<BODY BGCOLOR="$vars_styles{'BGColor'}" LINK="$vars_styles{'LinkColor'}" ALINK="$vars_styles{'ActiveLinkColor'}" VLINK="$vars_styles{'VisitedLinkColor'}" TEXT="$vars_styles{'TextColor'}">
<BR>
<FONT FACE="$vars_styles{'FontFace'}" SIZE="$vars_styles{'TextSize'}"><A HREF="

http://www.puremadnezz.com/cgi-bin/...y">$vars_gen{'IntroText'}</A></FONT><BR>

<BR>
<CENTER>
THIS
&get_entries;
print<<THIS;
<BR>
$Copyright
</CENTER>
</BODY>
</HTML>
</HTML>

THIS

}

Thank you.

http://www.puremadnezz.com/

- Go there!

PhoenixDown · Jul 14, 2001

top

http://www.puremadnezz.com/

- Go there!

PhoenixDown · Jul 15, 2001

Can someone please help me? :-(

http://www.puremadnezz.com/

- Go there!

Kiehlster · Jul 16, 2001

You've got the "Guestbook Entries" table information printing inside your foreach loop, so obviously you have three entires in your guestbook??? So it's printing that table for every entry in your guestbook. Try moving it out of the foreach loop.
Steve Kiehl
webmaster@nanovox.com

http://www.nanovox.com/

goBoating · Jul 16, 2001

There are at least two remaining problems.
One - your HTML table structure is wacked. When you output $Field, it has no table
row or table definition around it.
<tr><td>$Field</td></tr>

Two - you are calling [red]exit;[/red] at the end of this sub. This exits the entire
program! If you want to explicitly return from your sub, then use 'return',
not 'exit'.

Additionally, using 'die' when you fail to open a file, hides the failure from you in a
CGI context. I use a very short sub, to print the error to the browser and then die.

open(IPF,"<some_file&quot

or ooops("Failed to open input file, $!&quot

;
sub oooops { print "<p>@_</p>"; die; }

That way, the error may not showup on the page but it will be viewable in the page source.

print<<THIS;
<table border=0 cellpadding=0 cellspacing=0 width="$vars_styles{'TableWidth'}">
<TR>
<td bgcolor="$vars_gen{'TableBorderColor'}">
<table border=0 cellpadding=4 border=0 cellspacing=1 width=100%>
<TR bgcolor="$vars_styles{'TableHeaderStripBackgroundColor'}">
<TD align=center colspan=2>
<FONT SIZE="$vars_styles{'TextSize'}" FACE="$vars_styles{'FontFace'}"
COLOR="$vars_styles{'TableHeaderStripTextColor'}"><B>Guestbook Entries</B></FONT>
</td>
</tr>
[red]$Field1[/red]
</table>
THIS
}
[red]exit;[/red]

HTH

keep the rudder amid ship and beware the odd typo

PhoenixDown · Jul 16, 2001

It still doesn't work, and I have no idea what I'm doing wrong... :-(

sub get_entries {

open(DATA,"<$vars_gen{'CGIPath'}/variables/vars_entries.cgi&quot

or die ("Unable to open guestbook entry file.&quot

;
@line = <DATA>;
close(DATA);
foreach $line (@line) {
$line =~ s/\n//g;
($var1,$var2,$var3,$var4,$var5,$var6,$var7,$var8,$var9,$var10,$var11,$var12,$var13,$var14,$var15) = split(/\|/,$line);

if ( $var1 !~ /[a-zA-Z0-9]+/) {
$Field1 = "<tr bgcolor=\"$vars_styles{'AltColor1'}\"><td width=35% valign=top><FONT SIZE=\"2\" FACE=\"$vars_styles{'FontFace'}\"><B>$var1</b></font><BR><BR></font></td>";
} else {
$Field1 = "";
}

print<<THIS;
<table border=0 cellpadding=0 cellspacing=0 width="$vars_styles{'TableWidth'}">
<TR>
<td bgcolor="$vars_gen{'TableBorderColor'}">
<table border=0 cellpadding=4 border=0 cellspacing=1 width=100%>
<TR bgcolor="$vars_styles{'TableHeaderStripBackgroundColor'}">
<TD align=center colspan=2>
<FONT SIZE="$vars_styles{'TextSize'}" FACE="$vars_styles{'FontFace'}"
COLOR="$vars_styles{'TableHeaderStripTextColor'}"><B>Guestbook Entries</B></FONT>
</td>
</tr>
$Field1
</table>
THIS
}
exit;

}

My variable file looks like:

"

Calvin|<A HREF="mailto:calvin@puremadnezz.com">calvin@puremadnezz.com</A>|<A HREF="

http://www.puremadnezz.com/">h...st|216.130.72.133|c-72-133-res1.mts.net"

Yes, there is a space there.

I'm sorry for this long topic.

http://www.puremadnezz.com/

- Go there!

goBoating · Jul 16, 2001

Please be more descriptive with the error. What symptoms are you having? Do you get anything or nothing or something but the format is wrong or the content is wrong?

If the code above is still what you are trying to run, then you are STILL printing $Field inside a table without a table row or table definition and you are still calling exit at the bottom of your subroutine. The EXIT will EXIT before the rest of your HTML is sent to the browser and would make the page incomplete. Use return there or nothing. You can just let the sub routine finish and it will automatically go back to the next line after the line that called the sub.

</td>
</tr>
<tr><td> [red]$Field1[/red]</td></tr>
</table>
THIS
}
[red]exit;[/red] # loose this completely.

HTH

keep the rudder amid ship and beware the odd typo

PhoenixDown · Jul 16, 2001

It's not printing $var1. I removed exit; and it's still not working.

...

<B>Guestbook Entries</B></FONT>
</td>
</tr>
<tr><td>$Field1</td></tr>
</table></td></tr></table>
THIS
}

...

http://www.puremadnezz.com/

- Go there!

PhoenixDown · Jul 17, 2001

^

http://www.puremadnezz.com/

- Go there!

goBoating · Jul 18, 2001

Sorry to leave you hanging.......
Is this logic backwards?
if ( $var1 [red]!~[/red] /[a-zA-Z0-9]+/)
{
$Field1 = "<tr bgcolor=\"$vars_styles{'AltColor1'}\">
<td width=35% valign=top><FONT SIZE=\"2\" FACE=\"$vars_styles{'FontFace'}\">
<B>$var1</b></font><BR><BR></font></td>";
}
else
{
$Field1 = "";
}

It appears that you are checking to see if $var1 does NOT contain letters or numbers. If it does not ( it may be null), then, build the table row stuff with $var1 containing nothing. Therefore, $Field has HTML tags but no content. ELSE, $var1 does contain alpha or numerics, so set it to null. ?????? huh?

maybe change the '!~' to '=~'

keep the rudder amid ship and beware the odd typo

PhoenixDown · Jul 18, 2001

Thanks! That worked! It works good now. I made a few modifications to some subroutines and it works perfectly:

sub intro {

$Copyright = &Copyright;

print<<THIS;

<HTML>
<HEAD>
<TITLE>Guestbook</TITLE>
$vars_gen{'Header'}
</HEAD>
<BODY BGCOLOR="$vars_styles{'BGColor'}" LINK="$vars_styles{'LinkColor'}" ALINK="$vars_styles{'ActiveLinkColor'}" VLINK="$vars_styles{'VisitedLinkColor'}" TEXT="$vars_styles{'TextColor'}">
<BR>
<FONT FACE="$vars_styles{'FontFace'}" SIZE="$vars_styles{'TextSize'}"><A HREF="

http://www.puremadnezz.com/cgi-bin/...y">$vars_gen{'IntroText'}</A></FONT><BR>

<BR>
<CENTER>
<table border=0 cellpadding=0 cellspacing=0 width="$vars_styles{'TableWidth'}">
<TR>
<td bgcolor="$vars_styles{'TableBorderColor'}">
<table border=0 cellpadding=4 border=0 cellspacing=1 width=100%>
<TR bgcolor="$vars_styles{'TableHeaderStripBackgroundColor'}">
<TD align=center colspan=2>
<FONT SIZE="$vars_styles{'TextSize'}" FACE="$vars_styles{'FontFace'}"
COLOR="$vars_styles{'TableHeaderStripTextColor'}"><B>Guestbook Entries</B></FONT>
</td>
</tr>
THIS
&get_entries;
print<<THIS;
</table></td></tr></table>
<BR><BR>
$Copyright
</CENTER>
</BODY>
</HTML>
</HTML>

THIS

}

sub get_entries {

open(DATA,"<$vars_gen{'CGIPath'}/variables/vars_entries.cgi&quot

or die ("Unable to open guestbook entry file.&quot

;
@line = <DATA>;
close(DATA);
foreach $line (@line) {
$line =~ s/\n//g;
($var1,$var2,$var3,$var4,$var5,$var6,$var7,$var8,$var9,$var10,$var11,$var12,$var13,$var14,$var15) = split(/\|/,$line);

if ( $var1 =~ /[a-zA-Z0-9]+/) {
$Field1 = "<tr bgcolor=\"$vars_styles{'AltColor1'}\">
<td width=35% valign=top><FONT SIZE=\"2\" FACE=\"$vars_styles{'FontFace'}\">
<B>$var1</b></font><BR><BR></font></td>";
} else {
$Field1 = "";
}

print<<THIS;
$Field1
THIS
}

}

I just wanted to know one more thing. For if ( $var1 =~ /[a-zA-Z0-9]+/) { is there a way to do that so it will check if any characters are there?

Thanks again!! :-D

http://www.puremadnezz.com/

- Go there!

tsdragon · Jul 18, 2001

What do you mean by any characters? If you just mean "is it non-null", this will work if ($var1 ne "&quot. If you mean something like "any non-whitespace character" try this if ($var1 !~ /\A\w*\Z/). Tracy Dryden
tracy@bydisn.com

Meddle not in the affairs of dragons,
For you are crunchy, and good with mustard.

goBoating · Jul 18, 2001

if ($var1 =~ /\w/) { print "Found a word char"; }

or

if (length($var1) > 0) { print "var1 had something in it."; }

or...... TIMTOWTDI ;-)

keep the rudder amid ship and beware the odd typo

tsdragon · Jul 18, 2001

OOPS! You're right! \w is a "word char" not a "whitespace char"! I always do that! :~/ The second example should have been if ($var1 !~ /\A\s*\Z/). It means "$var1 is not ALL whitespace (or null)". It will allow some spaces, tabs, etc., but it must have at least one non-whitespace character.

Generally I'd rather use $var ne "" than length($var) > 0. I think it's probably more efficient, since it doesn't do the function call. Tracy Dryden
tracy@bydisn.com

Meddle not in the affairs of dragons,
For you are crunchy, and good with mustard.

PhoenixDown · Jul 18, 2001

Thanks I got it to work. I'm still working on it and thanks to your help I'll be done very soon.

What does "ne" mean?

http://www.puremadnezz.com/

- Go there!

tsdragon · Jul 18, 2001

ne means "not equal to", in a string comparison. It's the opposite of eq. Tracy Dryden
tracy@bydisn.com

Meddle not in the affairs of dragons,
For you are crunchy, and good with mustard.

Tek-Tips is the largest IT community on the Internet today!

Members share and learn making Tek-Tips Forums the best source of peer-reviewed technical information on the Internet!

Question 3

PhoenixDown

Programmer

PhoenixDown

Programmer

PhoenixDown

Programmer

PhoenixDown

Programmer

Kiehlster

MIS

goBoating

Programmer

PhoenixDown

Programmer

goBoating

Programmer

PhoenixDown

Programmer

PhoenixDown

Programmer

goBoating

Programmer

PhoenixDown

Programmer

tsdragon

Programmer

goBoating

Programmer

tsdragon

Programmer

PhoenixDown

Programmer

tsdragon

Programmer

Similar threads

Part and Inventory Search

Sponsor