Need help with a form and delete function

cs7536 · Jun 18, 2003

I have a page called viewdb.php that displays images and articles that I posted. Along with the image and article there is a radio select button that is displayed with each article posted.

<input name="id" type="radio" value="id">

well the idea is to select an article by way of the radio button and then choose an option of an update, delete or view button.

my delete button points to this page called delete.php with the following code:

<?php
$id= "id";

$db = mysql_connect("localhost", "***", "***&quot

;
mysql_select_db("userdb",$db);
mysql_query("DELETE FROM Portfolio WHERE id=$id LIMIT 1",$db);
echo "Information Deleted";
?>

the button that points to the delete page is not a submit button so it does not use a form element. it is a regular button with a tag that directs you to a the delete page with the obove delete code. the idea is to know what article I selected and allow me to update, delete or view that article.

my problem is that when I hit delete it deletes all of my articles not just the one I selected, and if I add the LIMIT 1 to the script then it only deletes 1 article but not the selected one, it deletes the first article displayed on the page.

does anybody have any idea how I can get this working correctly?

Thanks in advance.
Max

Nothing is hard when you realy want to learn it.

Max

spookie · Jun 18, 2003

hi,
$id= "id";//?? try printing $id and see if it gets the ID value of the selected article.

Print the query before executing and see if it exactly like u want..

--------------------------------------------------------------------------
I never set a goal because u never know whats going to happen tommorow.

DRJ478 · Jun 19, 2003

If you do not submit you need to pass the ID parameter as a GET string attached to the URL of delete.php

You could also use a session to achieve that.

You can handle the update/delete etc. in one PHP file and post all actions to the same file. All buttons would be submit buttons with different names, e.g. <input type="submit" name="delete" value="Delete">

In the script then just enclose the appropriate action in an if statement that checks for the button that was used to submit the form. $_POSt['delete'] is set when the button was used to sumit the form.

cs7536 · Jun 19, 2003

ok I see that makes lots of scenece, on both I will try thm both.. I will post If I have any more problems,, thanks alot..

Max

Nothing is hard when you realy want to learn it.

Max

cs7536 · Jun 19, 2003

I am still having problems, I got it to work to a certain point. my view.php page looks like this:

<?php
$imagedir= "images/";
$imagename= "image";
$select= "$select";
$Warning= "Warning";

$db = mysql_connect("localhost", "***","***&quot

;
mysql_select_db("userdb",$db);

$result = mysql_query ("SELECT image, text FROM $select&quot

;

if ($select =="nothing&quot

{
echo "<strong>$Warning:</strong>";
echo "<br>";
echo "You must choose a category first before proceeding. A category to view was not selected.
<br><strong><br>Please click on one of the links below to continue.</strong>";
}

elseif ($row = mysql_fetch_array($result)) {

do {
echo '
<html>
<body>
<tr><td><input name="id" type="radio" value="id">
</body>
</html>';
echo "<td>";
echo "<img src=".$imagedir.$row["image"]." width='67' height='100'>";
echo "<br>";
echo "<p>";
echo "<td>";
echo $row["text"];

} while($row = mysql_fetch_array($result));

} else {print "Sorry, no article posted at this time!";
}
?>

and my editpage.php looks like this:

<?php
if($View){
$imagedir= "images/";
$db = mysql_connect("localhost", "***", "***&quot

;
mysql_select_db("userdb",$db);
$result = mysql_query("SELECT * FROM Portfolio WHERE id=$id",$db);

echo "<TABLE BORDER=0>"; //this is the thickness of the table border
echo"<TR><TD><B></B><TD><B></B></TR>";

$myrow = mysql_fetch_array($result);
echo "<tr><td><br><img src=".$imagedir.$myrow["image"]." width='288' height='432'>";
echo "<td><br>".$myrow["text"];

}
?>

my view.php page has an edit, delete and view submit button that call the editpage.php by way of a form submit. now like DRJ478 said I put all of the edit code on one page but for this post I am only displaying the view part at this time. Now it calls the approriot part of the code rather it be edit, updat or view, but it is not working the article that I am selecting via the radio button on the view.php page. No matter what radio button I select it is defaulting to the top article displayed and not the one I select.

does any body know what I am doing wrong?

Max

Nothing is hard when you realy want to learn it.

Max

spookie · Jun 20, 2003

And how the edit.php is getting called?
I assume that u have a form tag in ur view.php
how ru passinf the actuall id of the article?

Code:

$result = mysql_query (&quot;SELECT id,image,text FROM $select&quot;);// select id as well

if ($select ==&quot;nothing&quot;){
        echo &quot;<strong>$Warning:</strong>&quot;;
        echo &quot;<br>&quot;;
        echo &quot;You must choose a category first before proceeding. A category to view was not selected.
        <br><strong><br>Please click on one of the links below to continue.</strong>&quot;;
}

elseif ($row = mysql_fetch_array($result)) {

do {
  echo '
<html>
    <body>
            <tr><td><input name=&quot;id&quot; type=&quot;radio&quot; value=&quot;<? echo $row[id]; ?>&quot;><!-- the value ur gettin frm DB
    ...
    ....

--------------------------------------------------------------------------
I never set a goal because u never know whats going to happen tommorow.

aniruthan99 · Jun 20, 2003

Code:

How do you retrieve the id value? If you retrieve the value using $id and not by $_POST['id'] make sure register_globals
 is ON

cs7536 · Jun 26, 2003

I am not understanding how to utilize the $_POST['id'] I read php.net but can not understand it, can someone please explain so that I can understand base on the code that I have posted.

Thanks
Max

Nothing is hard when you realy want to learn it.

Max

cs7536 · Jun 26, 2003

The radio button has the id of id=$id
when I select the radio button and select the view button this is what I get:

http://localhost/domain_name.com/view.php?action=View&id=$id

instead of:

http://localhost/hiltronbailey.com/view.php?action=View&id=16

I don't understand what I am doing wrong. can someone explain?.

Nothing is hard when you realy want to learn it.

Max

DRJ478 · Jun 26, 2003

You can see that what is encoded is $id, the literal, as urlencoded string - %24 is a dollar sign.
That is an indication that the variable is not substituted i.e.
1. it's not in a <? ?> PHP section.
2. or you echo the whole thing out and have it it single quotes.

Code:

echo '<input name=&quot;id&quot; type=&quot;radio&quot; value=&quot;$id&quot;>';

will not work because PHP does not substitute variables within single quoted strings.
For a full echo statemenmt you need

Code:

echo '<input name=&quot;id&quot; type=&quot;radio&quot; value=&quot;'.$id.'&quot;>';

Concatenate the variable and the rest of the print/echo statement.

Spookie's code also works:

Code:

<input name=&quot;id&quot; type=&quot;radio&quot; value=&quot;<? echo $row[id]; ?>&quot;>

cs7536 · Jun 26, 2003

Hello DRJ478 and all the other developers that answered my request, I appreciate the guidance that you are giving me to assist me in resolving my php issue here.

DRJ478

I read carefully what you said above and what sppok said as well, I tried tem both but the results are still nothing I must e doing something wrong sme where and can figure it out. It is fustrating cause I have working on this issue for 3 weeks now.

Nothing is hard when you realy want to learn it.

Max

DRJ478 · Jun 26, 2003

Let's see your latest code.
I'll have another look.

Don't be discouraged!

cs7536 · Jun 26, 2003

when I use spooks solution it retures

http://localhost/hiltronbailey.com/view.php?action=View&id=<?+echo+$row[id];+?>

and the "'.$id.'" returns:

http://localhost/hiltronbailey.com/view.php?action=View&id=

Nothing is hard when you realy want to learn it.

Max

cs7536 · Jun 26, 2003

<?php
$imagedir= "images/";
$imagename= "image";
$select= "$select";
$Warning= "Warning";

$db = mysql_connect("localhost", "***","***&quot

;
mysql_select_db("user",$db);

$result = mysql_query ("SELECT id, image, text FROM $select&quot

;

//echo "<TABLE BORDER=1>";

if ($select =="nothing&quot

{
echo "<strong>$Warning:</strong>";
echo "<br>";
echo "You must choose a category first before proceeding. A category to view was not selected.
<br><strong><br>Please click on one of the links below to continue.</strong>";
}

elseif ($row = mysql_fetch_array($result)) {

do {
echo '<input name="id" type="radio" value="'.$id.'">';

$title = "$select";

$_SESSION['pagetitle'] = $title;
//$num = $row["id"];
//$_SESSION['id'] = $id;

echo "<tr><td>";
echo "<img src=".$imagedir.$row["image"]." width='67' height='100'>";
//echo "<hr>"; //add a line devider code
echo "<br>";
echo "<p>"; // Skip a line and go to next
//echo "<li>"; adds a bullet dot
//echo "<ul>"; Add a indent before the text
echo "<td>";
echo $row["text"];

echo "<TD><a href=view.php?action=view&id=".$row['id'].">View</a><p>";
echo "<br>";
//echo "<a href=addedit.php?action=edit&id=".$row['id'].">Edit</a><p>";
echo "<a href=delete.php?action=delete&id=".$row['id'].">Delete</a><p>";

/* echo ("<br>&quot

; go to next line */

} while($row = mysql_fetch_array($result));

} else {print "Sorry, no article posted at this time!";
}
?>

now notice towards the lower part of the code I have created a code that does exactly what I need, but that id by way of links, I need that out come to be done by way of a button. now does the method setting have anything to do with it, I have it set on default.

Nothing is hard when you realy want to learn it.

Max

cs7536 · Jun 26, 2003

DRJ478

I got it, I used the "'.$is.'"
and I created a Variable that $id = $row["id"]; and that did tha trick I had not defined a variable and that was the problem but also when I did do this before I did not Concatenate the id on the radio script..

Thanks alot, now I know what to do and what nbot todo..

Thank you everybody that assist me in working through this.
Musch appreciated.
Max

Nothing is hard when you realy want to learn it.

Max

Tek-Tips is the largest IT community on the Internet today!

Members share and learn making Tek-Tips Forums the best source of peer-reviewed technical information on the Internet!

Need help with a form and delete function

cs7536

Programmer

spookie

Programmer

DRJ478

IS-IT--Management

cs7536

Programmer

cs7536

Programmer

spookie

Programmer

aniruthan99

Programmer

cs7536

Programmer

cs7536

Programmer

DRJ478

IS-IT--Management

cs7536

Programmer

DRJ478

IS-IT--Management

cs7536

Programmer

cs7536

Programmer

cs7536

Programmer

Similar threads

Part and Inventory Search

Sponsor