Javascript in cfform 1

olmos · Feb 12, 2001

I used a javascript which uses regular expressions to check input for an ip address, a pop box alerts you if you have not entered the IP address format correctly . It works fine with a regular html form but does not work in my cold fusion form. I placed it between the Head tags I also have other cold fusion processing stuff in the same page and have required fields in my form for example: <INPUT TYPE="hidden" NAME="SYSTEM_LOCATION_required" VALUE="Missing System Location">. Is it because I am also using the required fields on the same page or other processing?

Thanks in advance ,
olmos

GunJack · Feb 12, 2001

Hey Olmos,

Adding the CF validation fields shouldn't affect the JS validation for the other field(s) unless you have it set to check all inputs. If you can post the JS along with everything between your form tags, I or someone else in the forums should be able to help.

GJ

olmos · Feb 12, 2001

Here's the code below and I do have it set to check all inputs since the fields are all required. This may be the problem. I would really appreciate if someone can check it and let me know what's wrong. By the way, thanks GunJack for your help with my previous post on formatting an IP . I decided to change the datatype to CHAR makes it easier to retrieve and am using this javascript to check for formatting the IP.

thanks,
Olmos

<CFPARAM NAME="action" DEFAULT=" ">

<CFQUERY NAME="qry_fn_id" DATASOURCE="IT" dbtype="Oracle80">

SELECT max(FN_ID) AS maxFN_ID
FROM scott.f_natl

</CFQUERY>

<CFSET l_fn_id = qry_fn_id.maxFN_ID>

<CFIF action EQ "insert">

<CFTRANSACTION>

<CFQUERY NAME="qry_fn_id" DATASOURCE="IT" dbtype="Oracle80">

SELECT max(FN_ID) AS maxFN_ID
FROM scott.f_natl

</CFQUERY>

<CFSET l_fn_id = qry_fn_id.maxFN_ID>

<CFQUERY NAME="ADDCOMPUTER" DATASOURCE="IT" dbtype="Oracle80">

INSERT INTO scott.fn_computer

( FN_ID, COMPUTER_NO, SYSTEM_NAME, SYSTEM_IP )

VALUES
( #l_fn_id#, '#Form.COMPUTER_NO#', '#Form.SYSTEM_NAME#', '#Form.SYSTEM_IP#')

</CFQUERY>
</CFTRANSACTION>

</CFIF>

<CFIF #ParameterExists(EditComputer)# IS "Yes">

<CFQUERY NAME="UpdateComputer" DATASOURCE="IT" dbtype="Oracle80">

UPDATE scott.fn_computer

SET FN_ID=#l_fn_id#, COMPUTER_NO = '#form.COMPUTER_NO#', SYSTEM_NAME = '#form.SYSTEM_NAME#', SYSTEM_IP= #form.SYSTEM_IP#

WHERE fn_computer.FN_COMPUTER_ID = #form.FN_COMPUTER_ID#

</CFQUERY>

</CFIF>

<CFIF #ParameterExists(DeleteComputer)# IS "Yes">

<CFQUERY NAME="DeleteComputer" DATASOURCE="IT" dbtype="Oracle80">

DELETE FROM scott.fn_computer

WHERE fn_computer.FN_COMPUTER_ID = #form.FN_COMPUTER_ID#

</CFQUERY>

</CFIF>

<CFTRANSACTION>

<CFQUERY NAME="qry_fn_id" DATASOURCE="IT" dbtype="Oracle80">

SELECT max(FN_ID) AS maxFN_ID
FROM scott.f_natl
</CFQUERY>

<CFSET l_fn_id = qry_fn_id.maxFN_ID>

<CFQUERY NAME="SHOWRECORDS" DATASOURCE="IT" dbtype="Oracle80">

SELECT f_natl.sponsor_name, f_natl.visitor_name, fn_computer.FN_COMPUTER_ID, fn_computer.FN_ID, fn_computer.COMPUTER_NO , fn_computer.SYSTEM_NAME, fn_computer.SYSTEM_IP

FROM scott.f_natl , scott.fn_computer

WHERE f_natl.FN_ID = fn_computer.FN_ID

AND fn_computer.FN_ID = #l_fn_id#

</CFQUERY>

</CFTRANSACTION>

<HTML>
<HEAD>
<TITLE>
</TITLE>

<script language="JavaScript1.2"><!--

function validate(form) {

var str = form.system_ip.value;

var re = /^[1-9]{3}\.[0-9]{1,}\.[0-9]{1,}\.[0-9]{1,}/;

if (form.system_ip.value == "&quot

{
alert("Please enter your System IP address.&quot

;
form.system_ip.focus();
return false;
}
if (re.test(str)) {
return true;
}
alert("" + str + " is an invalid IP Address!&quot

;
form.system_ip.select();
form.system_ip.focus();
return false;
}

// --></script>

</HEAD>

<BODY>

<form ACTION="formgrid.cfm" method="post" onSubmit="return validate(this)">
<INPUT TYPE="hidden" NAME="action" VALUE="edit">
<INPUT TYPE="hidden" NAME="action" VALUE="#qry_fn_id.l_fn_id#">
<CENTER>
<H1>Computer Access</H1>
</CENTER>
<P>
<CFOUTPUT QUERY="SHOWRECORDS">

<H2>Computer List: </h2>
<INPUT TYPE= "hidden" NAME="fn_computer_id" VALUE= "#fn_computer_id#">
<TABLE border="1">
<TR>
<TH></TH>
<TH></TH>
<TH>FN_ID</TH>
<TH>COMP. NUMBER</TH>
<TH>SYSTEM NAME</TH>
<TH>SYSTEM IP</TH>
</TR>

<TR>
<TD><A HREF="editformgrid2.cfm?fn_computer_id=#fn_computer_id#"><FONT SIZE=-1>[EDIT]</FONT></A></TD>

<TD><A HREF="deleteformgrid2.cfm?fn_computer_id=#fn_computer_id#"><FONT SIZE=-1>[DELETE]</FONT></A></TD>

<TD>#FN_ID#</TD>
<TD>#COMPUTER_NO#</TD>
<TD>#SYSTEM_NAME#</TD>
<TD>#SYSTEM_IP#</TD>
</TR>
</form>

<FORM ACTION="submitcomplete2.cfm" method="post" >

Click done when computer list is complete <INPUT TYPE="submit" VALUE="Done">

</form>
</CFOUTPUT>
</TABLE>
</form>

<HR>

<H2>Enter New Computer Information:</H2>

<p>
<FORM NAME = "computerinfo" ACTION="formgrid2.cfm" method="post" onSubmit="return validate(this)">

<INPUT TYPE="hidden" NAME="action" VALUE="insert">
<INPUT TYPE= "hidden" NAME="fn_id" VALUE= "#fn_id#">
<INPUT TYPE= "hidden" NAME="fn_computer_id" VALUE= "#fn_computer_id#">

<INPUT TYPE="hidden" NAME="COMPUTER_NO_required" VALUE="Missing Computer Number">
<INPUT TYPE="hidden" NAME="SYSTEM_NAME_required" VALUE="Missing System Name">
<INPUT TYPE="hidden" NAME="SYSTEM_IP_required" VALUE="Missing System IP">

<table width="100%" align = "center" border = "1" cellpadding=2 cellspacing=2 bgcolor=#ffffcc>

<INPUT TYPE= "hidden" NAME="fn_id" VALUE= "#fn_id#">
<INPUT TYPE= "hidden" NAME="fn_computer_id" VALUE= "#fn_computer_id#">

<tr>
<td>
<font size=-1><a href="computer_no.html" target="_blank">* COMPUTER_</a></font><br>
<input type=text size=15 maxlength=9 name="COMPUTER_NO" >
</td>
<td><font size=-1><a href="system_ip.html" target="_blank">* IP ADDRESS OF SYSTEMS</a></font><br>
<input type=text size=15 maxlength=15 name="SYSTEM_IP" >
</td>
<td><font size=-1><a href="name_of_systems.html" target="_blank">* NAME OF SYSTEM</a></font><br>
<input type=text size=30 maxlength=30 name="SYSTEM_NAME" >
</td>
</tr>

</table>

<INPUT TYPE="submit" VALUE="Add Computer to list" >

</FORM>

<FORM ACTION="submitcomplete2.cfm" method="post">

Click done when computer list is complete

<INPUT TYPE="submit" VALUE="Done">

</form>

</BODY>
</HTML>

iza · Feb 13, 2001

what is not working ? which browser do you use ? and you didn't need to post ALL the code for the page (for instance cfquery's are irrelevant !) - javascript and form parts would have been enough !

GunJack · Feb 13, 2001

Hey Olmos,

The only problem I see is that the first form to use your validation

<form ACTION="formgrid.cfm" method="post" onSubmit="return
validate(this)">

doesn't have an input "system_ip". This would cause the validation to fail for this form. The second form that uses the validation does have an input and I don't see any reason why it wouldn't work. Can you tell me what happens when you submit the form? Iow, does it not submit because the validation fails, does it always submit even with invalid IPs, etc... I need to know what you're seeing a problem with so I know where to look.

GJ

olmos · Feb 13, 2001

I am using netscape 4.7 and this will be the browser that the users will be using.
It submits to the action page even with invalid IP's. I never see the alert box. I took off the ...onSubmit="return validate(this)"> for the first form. It still isn't working.

thanks,
olmos

GunJack · Feb 13, 2001

Hey Olmos,

I didn't spot it at first and had to re-create your script to see what was happening. Since JS is case sensitive, you need to make sure your input variable name is the same as what you're referencing in your validation function. In validate(), you reference the field as "form.system_ip" but you define it as "SYSTEM_IP". If you change the input box to this,

<input type=text size=15 maxlength=15 name="system_ip" >

I think it will work for you as it did with my browser.

Let me know if you still have problems,
GJ

olmos · Feb 14, 2001

Thanks alot for your help . It worked!!

olmos

Tek-Tips is the largest IT community on the Internet today!

Members share and learn making Tek-Tips Forums the best source of peer-reviewed technical information on the Internet!

Javascript in cfform 1

olmos

Technical User

GunJack

ISP

olmos

Technical User

iza

Programmer

GunJack

ISP

olmos

Technical User

GunJack

ISP

olmos

Technical User

Similar threads

Part and Inventory Search

Sponsor