javascript checkbox toggle with PHP not working for array 1

[webslinga]

Hi all,
I have a javascript function such as this:

function checkAll(checkName, exby)
{
	document.write(checkName)
	document.write(exby)
  for (i = 0; i < checkname.length; i++)
  	checkname[i].checked = exby.checked? true:false
}

And my php script is like this:

<table border=0>
<tr><th colspan="2">[b]<input type="checkbox" name="all" onClick="checkAll(document.doAssignRolesForm.credID,this)">Check/Uncheck All[/b]</th><th colspan=<?php echo $numColsspan ?>>Role</th></tr>

	$count = 0;
	foreach($Roles as $role){ ?>
	<?php if(in_array($role->getCredUnid(), $credBank)){?>
	<?php if(($count % $numCols) == 0){?>
	<tr>
	<?php } ?>
	<td><?php [b]echo checkbox_tag('credID[]', $role->getCredUnid(), true); [/b]?></td>
	<td><?php echo $role->getDescription();?></td>
	<?php $count++; ?>
	<?php if(($count % $numCols) == 0){?>
	</tr>
	<?php } ?>
	<?php }
	else { ?>
	<?php if(($count % $numCols) == 0){?>
	<tr>
	<?php } ?>
	<td><?php echo checkbox_tag('credID[]', $role->getCredUnid(), false); ?></td>
	<td><?php echo $role->getDescription(); ?></td>
	<?php $count++; ?>
	<?php if(($count % $numCols) == 0){?>
	</tr>
	<?php } ?>
	<?php } ?>
	<?php  }

This check/uncheck box does not work and I believe the problem is because i am dynamically creating an array of checkboxes called credID. BTW if anyone doesn't understand why I subtituted a funcion checkbox_tag() for an HTML tag it is because this PHP script is following the symfony framework... I just want to know about the js problem. Any way around this? Thanks.

 

[BillyRayPreachersSon]

In your checkAll function, you refer to "checkname" and "checkName". JS is case-sensitive, so you must correct any anomalies like this.

Hope this helps,
Dan



Coedit Limited - Delivering standards compliant, accessible web solutions

[tt]Dan's Page [blue]@[/blue] Code Couch

http://www.codecouch.com/dan/

[/tt]

 

[webslinga]

Good catch BillyRay!

Still not the result that I want though.

function checkAll(checkName, exby)
{
	document.write(checkName)
	document.write(exby)
  for (i = 0; i < checkName.length; i++)
  	checkName[i].checked = exby.checked? true:false
}

 

[BillyRayPreachersSon]

Oh... it was glaring me in the face. You should remove the two document.write lines. If you use document.write after a page has loaded, it will overwrite all content.

Hope this helps,
Dan

Coedit Limited - Delivering standards compliant, accessible web solutions

[tt]Dan's Page [blue]@[/blue] Code Couch

http://www.codecouch.com/dan/

[/tt]

 

[webslinga]

Sorry Dan,
I was using document.write() just for debugging purposes. I know to take them off.

 

[BillyRayPreachersSon]

Oh. It's possibly that JS doesn't like the name of your control array having '[' or ']' in it...

If you remove them, does the JS start working?

Dan



Coedit Limited - Delivering standards compliant, accessible web solutions

[tt]Dan's Page [blue]@[/blue] Code Couch

http://www.codecouch.com/dan/

[/tt]